joseph/ta-fix-commits-failed - Branch - codecov/umbrella

fix: "commits where fail" number calculation

#354

Comparing

joseph/ta-fix-commits-failed

(

872724d

) with

main

(

45e74cc

)

Improvements: 0

Regressions: 0

Untouched: 9

New: 0

Dropped: 0

Ignored: 0

No successful run was found on main ( c49bce6) during the generation of this report, so 45e74cc was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Benchmarks

Passed

test_report_merge

libs/shared/tests/benchmarks/test_report.py::test_report_merge

2.7 s

test_report_serialize

libs/shared/tests/benchmarks/test_report.py::test_report_serialize

5.7 ms

test_report_diff_calculation[FilteredReport]

libs/shared/tests/benchmarks/test_report.py::test_report_diff_calculation[FilteredReport]

2.8 ms

2.9 ms

test_report_filtering

libs/shared/tests/benchmarks/test_report.py::test_report_filtering

2.3 s

test_parse_full

libs/shared/tests/benchmarks/test_report.py::test_parse_full

487.9 ms

488.4 ms

test_report_diff_calculation[Report]

libs/shared/tests/benchmarks/test_report.py::test_report_diff_calculation[Report]

1.9 ms

test_parse_shallow

libs/shared/tests/benchmarks/test_report.py::test_parse_shallow

9.5 ms

test_process_totals

libs/shared/tests/benchmarks/test_report.py::test_process_totals

591.4 ms

593.3 ms

test_report_carryforward

libs/shared/tests/benchmarks/test_report.py::test_report_carryforward

-1%

5.4 ms

5.5 ms

Commits

Click on a commit to change the comparison range

Base

main

45e74cc

fix: commits where fail number calculation we have to store the individual commit shas in the aggregate to be able to get an accurate number, otherwise we might double count and inflate the number so we have to re-define the CAs to use an array_agg(distinct ...) then use our custom array_merge_dedup aggregate function in the query that's run against the CAs and we end up with a list of all the commit shas where there were failures then we take the cardinality and coalesce with 0 in case a null appeared at any point of the computation

872724d

7 days ago

by joseph-sentry

Home Terms Privacy Docs