Comparing
joseph/warnings
(f129010
) withmain
(14fe3d7
)0%
- Improvements
- 0
- Regressions
- 0
- Untouched
- 6
- New
- 0
- Dropped
- 0
- Ignored
- 0
Benchmarks
Passed
update_same
benches/binary.rs::benches::binary::binary::update_same+1%
390.7 ms
387.4 ms
update_different
benches/binary.rs::benches::binary::binary::update_different+1%
380 ms
377.3 ms
create_and_serialize
benches/binary.rs::benches::binary::binary::create_and_serialize0%
298.1 ms
297.1 ms
merge
benches/binary.rs::benches::binary::binary::merge0%
580.3 ms
580.6 ms
merge_rewrite
benches/binary.rs::benches::binary::binary::merge_rewrite0%
584.1 ms
584.5 ms
read_aggregation
benches/binary.rs::benches::binary::binary::read_aggregation0%
27.5 ms
27.6 ms
Commits
Click on a commit to change the comparison rangeBase
main
14fe3d7
0%
feat: return warnings in parsing info
we want to be able to return warnings when parsing a file, this is for
cases where we want to let the user know something's wrong but
continue parsing the rest of the JUnit XML because it may be partially
valid
this is being implemented because I realized that failing to parse the
entire file because one test case might have a really long name is not
ideal for users, but we shouldn't silently skip including that test
case either, we still want to let them know that something's in their
JUnit XML isn't being parsed
this commit also includes changes to the attribute parsing so we can
error when we fail to parse attributes, and return warnings when we
fail to validate the attribute's value (see AttrsOrWarning)
this also means that i added logic for signalling that we're ignoring
the test case we're currently parsing by making saved_testrun an enum
(see TestrunOrSkipped)
I'm not sure if making warnings an Option<Vec<String>> would be better
than making it a Vec<String> and having it be empty
also the fact that we have to pass WarningInfo objects back from the
use_reader function then format it to include location info is
unfortunate but it lets us avoid iterating over the buffer to get the
line/col every time we want to create a warning
also the decision to include the warnings in the parsing info is to
avoid breaking the interface of the parse_raw_upload function, which
still returns the same tuple
cc400ac
3 months ago
by joseph-sentry0%
fix: improve warning location accuracy
90b426d
2 months ago
by joseph-sentry0%
fix: address feedback
parse_testcase_attrs returns a custom Result<ParseAttrsError> now
and the calling function is responsible for ignoring the Error that's
actually a warning
f129010
2 months ago
by joseph-sentry