joseph/update-minio - Branch - codecov/shared

feat: add metadata to MinioStorageService

#590Merged

Comparing

joseph/update-minio

(

a211c6f

) with

main

(

04c17e8

)

Untouched: 9

Benchmarks

Passed

test_report_serialize

tests/benchmarks/test_report.py

5.9 ms5.8 ms

test_report_diff_calculation[FilteredReport]

tests/benchmarks/test_report.py

3.1 ms3.1 ms

test_parse_full

tests/benchmarks/test_report.py

535.4 ms535.1 ms

test_report_diff_calculation[Report]

tests/benchmarks/test_report.py

1.9 ms1.9 ms

test_report_filtering

tests/benchmarks/test_report.py

2.6 s2.6 s

test_report_merge

tests/benchmarks/test_report.py

2.7 s2.7 s

test_parse_shallow

tests/benchmarks/test_report.py

9.8 ms9.8 ms

test_process_totals

tests/benchmarks/test_report.py

639.8 ms641.7 ms

test_report_carryforward

tests/benchmarks/test_report.py

2.9 ms2.9 ms

Commits

Click on a commit to change the comparison range

Base

main

04c17e8

-0.08%

feat: add metadata to MinioStorageService GCS/S3 objects allow you to add metadata to them when writing, and you can read that metadata back. This is done via request/response headers. The reason I chose to pass in a metadata_container instead of changing the return type of read_file is because I wanted to offer the option to not care about an object's metadata, and this also makes it so this PR won't involve a bunch of changes in worker and API to accept 2 args as the return instead of 1.

a211c6f

10 months ago

by joseph-sentry

Home Terms Privacy Docs