pjdurden:fix/pop-address-const-eval-panic - Branch - bluealloy/revm

fix(interpreter): use IntoAddress in pop_address to avoid const-eval panic

#3735Merged

Comparing

pjdurden:fix/pop-address-const-eval-panic

(

32b4008

) with

main

(

16aab94

)

Untouched: 176

Ignored: 6

Skipped: 1

Benchmarks

183 total

ecrecover precompile

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks

+1%

200.3 µs199.1 µs

p256verify precompile

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks

1 ms1 ms

g2_add

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks

43.5 µs43.5 µs

g2_msm (size 2)

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks

2.7 ms2.7 ms

bn254 mul precompile

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks

337.5 µs337.4 µs

EXTCODECOPY_50

bins/revme/benches/evm.rs::benches::evm

51.7 µs51.7 µs

transact_1000tx_commit_inner_every_40

bins/revme/benches/evm.rs::benches::evm

2.3 ms2.3 ms

g1_msm (size 1)

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks

714.3 µs714.3 µs

ecpairing precompile

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks

4.8 ms4.8 ms

EXTCODEHASH_50

bins/revme/benches/evm.rs::benches::evm

37 µs37 µs

g2_msm (size 128)

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks

88.2 ms88.2 ms

g1_msm (size 2)

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks

1.4 ms1.4 ms

g2_msm (size 1)

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks

1.3 ms1.3 ms

g2_msm (size 256)

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks

162.3 ms162.3 ms

g1_msm (size 128)

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks

47 ms47 ms

g1_msm (size 256)

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks

89.2 ms89.2 ms

RETURN_50

bins/revme/benches/evm.rs::benches::evm

109.3 µs109.3 µs

pairing (8 pairs)

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks

19.4 ms19.4 ms

pairing (2 pairs)

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks

6.5 ms6.5 ms

snailtracer

bins/revme/benches/evm.rs::benches::evm

177.3 ms177.3 ms

CREATE_50

bins/revme/benches/evm.rs::benches::evm

397.6 µs397.6 µs

snailtracer-inspect

bins/revme/benches/evm.rs::benches::evm

191 ms191 ms

pairing (1 pairs)

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks

4.4 ms4.4 ms

transact_commit_1000txs

bins/revme/benches/evm.rs::benches::evm

2.8 ms2.8 ms

pairing (16 pairs)

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks

36.5 ms36.5 ms

Commits

Click on a commit to change the comparison range

Base

main

16aab94

+0.01%

test(interpreter): drop pop_address regression test per review

32b4008

2 months ago

by pjdurden

Home Terms Privacy Docs