aggregate-prs-2867-2874 - Branch - bluealloy/revm

Aggregate cleanup changes from PRs #2866, #2867, and #2874

#2876Merged

Comparing

aggregate-prs-2867-2874

(

a791066

) with

main

(

f3c794b

)

-3%

Improvements: 0

Regressions: 1

Untouched: 170

New: 0

Dropped: 0

Ignored: 6

Benchmarks

Failed

ecrecover precompileRegression

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks::ecrecover precompile

-3%

198.4 µs

204.6 µs

Passed

DELEGATECALL_50

bins/revme/benches/evm.rs::benches::evm::DELEGATECALL_50

+1%

92.2 µs

91.5 µs

NUMBER_50

bins/revme/benches/evm.rs::benches::evm::NUMBER_50

+1%

18.2 µs

18.1 µs

PUSH1_50

bins/revme/benches/evm.rs::benches::evm::PUSH1_50

+1%

18.2 µs

18.1 µs

PUSH2_50

bins/revme/benches/evm.rs::benches::evm::PUSH2_50

+1%

18.3 µs

18.2 µs

PUSH3_50

bins/revme/benches/evm.rs::benches::evm::PUSH3_50

+1%

18.4 µs

18.3 µs

RETURN_50

bins/revme/benches/evm.rs::benches::evm::RETURN_50

+1%

111.4 µs

110.8 µs

STATICCALL_50

bins/revme/benches/evm.rs::benches::evm::STATICCALL_50

97.2 µs

96.8 µs

PUSH28_50

bins/revme/benches/evm.rs::benches::evm::PUSH28_50

19 µs

18.9 µs

CALL_50

bins/revme/benches/evm.rs::benches::evm::CALL_50

98 µs

97.7 µs

PUSH4_50

bins/revme/benches/evm.rs::benches::evm::PUSH4_50

18.3 µs

PUSH11_50

bins/revme/benches/evm.rs::benches::evm::PUSH11_50

18.6 µs

18.5 µs

PUSH13_50

bins/revme/benches/evm.rs::benches::evm::PUSH13_50

18.7 µs

18.6 µs

PUSH14_50

bins/revme/benches/evm.rs::benches::evm::PUSH14_50

18.7 µs

18.6 µs

PUSH26_50

bins/revme/benches/evm.rs::benches::evm::PUSH26_50

19 µs

18.9 µs

SELFBALANCE_50

bins/revme/benches/evm.rs::benches::evm::SELFBALANCE_50

20.7 µs

20.6 µs

CLZ_50

bins/revme/benches/evm.rs::benches::evm::CLZ_50

22.8 µs

transact_1000tx_commit_inner_every_40

bins/revme/benches/evm.rs::benches::evm::transact_1000tx_commit_inner_every_40

2 ms

EXTCODESIZE_50

bins/revme/benches/evm.rs::benches::evm::EXTCODESIZE_50

37.1 µs

37 µs

transact_commit_1000txs

bins/revme/benches/evm.rs::benches::evm::transact_commit_1000txs

2.8 ms

REVERT_50

bins/revme/benches/evm.rs::benches::evm::REVERT_50

112.7 µs

112.5 µs

CREATE_50

bins/revme/benches/evm.rs::benches::evm::CREATE_50

403.3 µs

402.6 µs

EXTCODECOPY_50

bins/revme/benches/evm.rs::benches::evm::EXTCODECOPY_50

46.6 µs

46.5 µs

CALLVALUE_50

bins/revme/benches/evm.rs::benches::evm::CALLVALUE_50

18.2 µs

18.1 µs

TIMESTAMP_50

bins/revme/benches/evm.rs::benches::evm::TIMESTAMP_50

18.2 µs

GASLIMIT_50

bins/revme/benches/evm.rs::benches::evm::GASLIMIT_50

18.2 µs

CHAINID_50

bins/revme/benches/evm.rs::benches::evm::CHAINID_50

18.2 µs

RETURNDATASIZE_50

bins/revme/benches/evm.rs::benches::evm::RETURNDATASIZE_50

18.2 µs

ORIGIN_50

bins/revme/benches/evm.rs::benches::evm::ORIGIN_50

18.3 µs

PC_50

bins/revme/benches/evm.rs::benches::evm::PC_50

18.4 µs

18.3 µs

PUSH5_50

bins/revme/benches/evm.rs::benches::evm::PUSH5_50

18.4 µs

DIFFICULTY_50

bins/revme/benches/evm.rs::benches::evm::DIFFICULTY_50

18.4 µs

PUSH9_50

bins/revme/benches/evm.rs::benches::evm::PUSH9_50

18.5 µs

PUSH23_50

bins/revme/benches/evm.rs::benches::evm::PUSH23_50

19 µs

PUSH27_50

bins/revme/benches/evm.rs::benches::evm::PUSH27_50

19 µs

SWAP14_50

bins/revme/benches/evm.rs::benches::evm::SWAP14_50

21.1 µs

21 µs

SWAP15_50

bins/revme/benches/evm.rs::benches::evm::SWAP15_50

21.4 µs

DUP10_50

bins/revme/benches/evm.rs::benches::evm::DUP10_50

23.3 µs

DUP9_50

bins/revme/benches/evm.rs::benches::evm::DUP9_50

23.3 µs

DUP12_50

bins/revme/benches/evm.rs::benches::evm::DUP12_50

23.3 µs

DUP13_50

bins/revme/benches/evm.rs::benches::evm::DUP13_50

23.4 µs

23.3 µs

DUP8_50

bins/revme/benches/evm.rs::benches::evm::DUP8_50

23.4 µs

DUP11_50

bins/revme/benches/evm.rs::benches::evm::DUP11_50

23.5 µs

SMOD_50

bins/revme/benches/evm.rs::benches::evm::SMOD_50

27 µs

ADDMOD_50

bins/revme/benches/evm.rs::benches::evm::ADDMOD_50

27.7 µs

27.6 µs

g2_add

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks::g2_add

43.4 µs

CALLDATACOPY_50

bins/revme/benches/evm.rs::benches::evm::CALLDATACOPY_50

57 µs

56.9 µs

CALLDATALOAD_50

bins/revme/benches/evm.rs::benches::evm::CALLDATALOAD_50

57.8 µs

RETURNDATACOPY_50

bins/revme/benches/evm.rs::benches::evm::RETURNDATACOPY_50

105.9 µs

analysis

bins/revme/benches/evm.rs::benches::evm::analysis

43.5 µs

KECCAK256_50

bins/revme/benches/evm.rs::benches::evm::KECCAK256_50

144.3 µs

144.2 µs

g2_msm (size 2)

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks::g2_msm (size 2)

2.7 ms

map_fp2_to_g2

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks::map_fp2_to_g2

861.1 µs

pairing (8 pairs)

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks::pairing (8 pairs)

19.4 ms

pairing (16 pairs)

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks::pairing (16 pairs)

36.5 ms

kzg precompile

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks::kzg precompile

7.5 ms

burntpix

bins/revme/benches/evm.rs::benches::evm::burntpix

469.4 ms

ADDRESS_50

bins/revme/benches/evm.rs::benches::evm::ADDRESS_50

18.3 µs

CALLDATASIZE_50

bins/revme/benches/evm.rs::benches::evm::CALLDATASIZE_50

18.2 µs

COINBASE_50

bins/revme/benches/evm.rs::benches::evm::COINBASE_50

18.3 µs

DUP14_50

bins/revme/benches/evm.rs::benches::evm::DUP14_50

23.4 µs

DUP15_50

bins/revme/benches/evm.rs::benches::evm::DUP15_50

23.3 µs

DUP16_50

bins/revme/benches/evm.rs::benches::evm::DUP16_50

23.7 µs

DUP7_50

bins/revme/benches/evm.rs::benches::evm::DUP7_50

23.4 µs

EQ_50

bins/revme/benches/evm.rs::benches::evm::EQ_50

23.6 µs

EXP_50

bins/revme/benches/evm.rs::benches::evm::EXP_50

30.8 µs

EXTCODEHASH_50

bins/revme/benches/evm.rs::benches::evm::EXTCODEHASH_50

37.3 µs

GT_50

bins/revme/benches/evm.rs::benches::evm::GT_50

23.8 µs

MCOPY_50

bins/revme/benches/evm.rs::benches::evm::MCOPY_50

20.5 µs

MULMOD_50

bins/revme/benches/evm.rs::benches::evm::MULMOD_50

28.1 µs

NOT_50

bins/revme/benches/evm.rs::benches::evm::NOT_50

23.3 µs

PUSH15_50

bins/revme/benches/evm.rs::benches::evm::PUSH15_50

18.7 µs

PUSH24_50

bins/revme/benches/evm.rs::benches::evm::PUSH24_50

18.9 µs

PUSH32_50

bins/revme/benches/evm.rs::benches::evm::PUSH32_50

19.1 µs

PUSH6_50

bins/revme/benches/evm.rs::benches::evm::PUSH6_50

18.4 µs

PUSH7_50

bins/revme/benches/evm.rs::benches::evm::PUSH7_50

18.5 µs

SGT_50

bins/revme/benches/evm.rs::benches::evm::SGT_50

24.3 µs

SHL_50

bins/revme/benches/evm.rs::benches::evm::SHL_50

24.5 µs

SHR_50

bins/revme/benches/evm.rs::benches::evm::SHR_50

24.7 µs

SWAP10_50

bins/revme/benches/evm.rs::benches::evm::SWAP10_50

21.2 µs

SWAP11_50

bins/revme/benches/evm.rs::benches::evm::SWAP11_50

21 µs

SWAP12_50

bins/revme/benches/evm.rs::benches::evm::SWAP12_50

21.1 µs

SWAP13_50

bins/revme/benches/evm.rs::benches::evm::SWAP13_50

21.1 µs

SWAP16_50

bins/revme/benches/evm.rs::benches::evm::SWAP16_50

21.3 µs

SWAP1_50

bins/revme/benches/evm.rs::benches::evm::SWAP1_50

21.1 µs

SWAP2_50

bins/revme/benches/evm.rs::benches::evm::SWAP2_50

21.1 µs

SWAP3_50

bins/revme/benches/evm.rs::benches::evm::SWAP3_50

21.1 µs

SWAP4_50

bins/revme/benches/evm.rs::benches::evm::SWAP4_50

21.1 µs

SWAP5_50

bins/revme/benches/evm.rs::benches::evm::SWAP5_50

21.1 µs

SWAP6_50

bins/revme/benches/evm.rs::benches::evm::SWAP6_50

21.1 µs

SWAP8_50

bins/revme/benches/evm.rs::benches::evm::SWAP8_50

21.1 µs

SWAP9_50

bins/revme/benches/evm.rs::benches::evm::SWAP9_50

21.1 µs

XOR_50

bins/revme/benches/evm.rs::benches::evm::XOR_50

23.4 µs

blake2/100K_rounds

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks::blake2/100K_rounds

9.4 ms

blake2/1024_rounds

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks::blake2/1024_rounds

100.1 µs

blake2/10_rounds

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks::blake2/10_rounds

4.3 µs

blake2/12_rounds

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks::blake2/12_rounds

4.5 µs

blake2/200K_rounds

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks::blake2/200K_rounds

18.9 ms

blake2/2_rounds

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks::blake2/2_rounds

3.1 µs

blake2/4_rounds

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks::blake2/4_rounds

3.4 µs

blake2/512_rounds

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks::blake2/512_rounds

51.8 µs

blake2/64_rounds

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks::blake2/64_rounds

9.5 µs

blake2/compress_12_rounds

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks::blake2/compress_12_rounds

3.3 µs

bn254 add precompile

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks::bn254 add precompile

21.2 µs

g1_add

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks::g1_add

28.3 µs

g1_msm (size 1)

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks::g1_msm (size 1)

714.4 µs

map_fp_to_g1

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks::map_fp_to_g1

243.8 µs

g2_msm (size 1)

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks::g2_msm (size 1)

1.3 ms

pairing (2 pairs)

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks::pairing (2 pairs)

6.5 ms

g1_msm (size 128)

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks::g1_msm (size 128)

47 ms

g2_msm (size 128)

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks::g2_msm (size 128)

88.2 ms

snailtracer-inspect

bins/revme/benches/evm.rs::benches::evm::snailtracer-inspect

387.8 ms

387.9 ms

pairing (1 pairs)

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks::pairing (1 pairs)

4.4 ms

snailtracer

bins/revme/benches/evm.rs::benches::evm::snailtracer

175.6 ms

g1_msm (size 256)

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks::g1_msm (size 256)

89.2 ms

MLOAD_50

bins/revme/benches/evm.rs::benches::evm::MLOAD_50

58 µs

g2_msm (size 256)

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks::g2_msm (size 256)

162.3 ms

bn254 mul precompile

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks::bn254 mul precompile

335.2 µs

335.3 µs

g1_msm (size 2)

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks::g1_msm (size 2)

1.4 ms

JUMP_50

bins/revme/benches/evm.rs::benches::evm::JUMP_50

17.8 µs

ecpairing precompile

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks::ecpairing precompile

4.7 ms

transfer

bins/revme/benches/evm.rs::benches::evm::transfer

12.7 µs

SDIV_50

bins/revme/benches/evm.rs::benches::evm::SDIV_50

27.2 µs

MOD_50

bins/revme/benches/evm.rs::benches::evm::MOD_50

25.8 µs

25.9 µs

DIV_50

bins/revme/benches/evm.rs::benches::evm::DIV_50

25.7 µs

25.8 µs

SAR_50

bins/revme/benches/evm.rs::benches::evm::SAR_50

24.9 µs

MCOPY_COLD_50

bins/revme/benches/evm.rs::benches::evm::MCOPY_COLD_50

24.6 µs

MUL_50

bins/revme/benches/evm.rs::benches::evm::MUL_50

24.6 µs

SIGNEXTEND_50

bins/revme/benches/evm.rs::benches::evm::SIGNEXTEND_50

24.4 µs

SLT_50

bins/revme/benches/evm.rs::benches::evm::SLT_50

24.3 µs

LT_50

bins/revme/benches/evm.rs::benches::evm::LT_50

23.8 µs

BYTE_50

bins/revme/benches/evm.rs::benches::evm::BYTE_50

23.7 µs

SUB_50

bins/revme/benches/evm.rs::benches::evm::SUB_50

23.6 µs

AND_50

bins/revme/benches/evm.rs::benches::evm::AND_50

23.4 µs

OR_50

bins/revme/benches/evm.rs::benches::evm::OR_50

23.4 µs

DUP1_50

bins/revme/benches/evm.rs::benches::evm::DUP1_50

23.3 µs

DUP2_50

bins/revme/benches/evm.rs::benches::evm::DUP2_50

23.3 µs

DUP5_50

bins/revme/benches/evm.rs::benches::evm::DUP5_50

23.3 µs

DUP6_50

bins/revme/benches/evm.rs::benches::evm::DUP6_50

23.3 µs

MSTORE_COLD_50

bins/revme/benches/evm.rs::benches::evm::MSTORE_COLD_50

22.9 µs

SWAP7_50

bins/revme/benches/evm.rs::benches::evm::SWAP7_50

21.2 µs

PUSH31_50

bins/revme/benches/evm.rs::benches::evm::PUSH31_50

19.2 µs

PUSH29_50

bins/revme/benches/evm.rs::benches::evm::PUSH29_50

19.1 µs

PUSH30_50

bins/revme/benches/evm.rs::benches::evm::PUSH30_50

19.1 µs

PUSH25_50

bins/revme/benches/evm.rs::benches::evm::PUSH25_50

19 µs

PUSH21_50

bins/revme/benches/evm.rs::benches::evm::PUSH21_50

18.9 µs

PUSH20_50

bins/revme/benches/evm.rs::benches::evm::PUSH20_50

18.7 µs

18.8 µs

PUSH18_50

bins/revme/benches/evm.rs::benches::evm::PUSH18_50

18.7 µs

PUSH17_50

bins/revme/benches/evm.rs::benches::evm::PUSH17_50

18.7 µs

PUSH16_50

bins/revme/benches/evm.rs::benches::evm::PUSH16_50

18.6 µs

MSTORE_50

bins/revme/benches/evm.rs::benches::evm::MSTORE_50

18.6 µs

PUSH10_50

bins/revme/benches/evm.rs::benches::evm::PUSH10_50

18.4 µs

18.5 µs

MSTORE8_50

bins/revme/benches/evm.rs::benches::evm::MSTORE8_50

55.2 µs

55.3 µs

PUSH8_50

bins/revme/benches/evm.rs::benches::evm::PUSH8_50

18.3 µs

18.4 µs

CALLER_50

bins/revme/benches/evm.rs::benches::evm::CALLER_50

18.3 µs

MSIZE_50

bins/revme/benches/evm.rs::benches::evm::MSIZE_50

18.2 µs

18.3 µs

GAS_50

bins/revme/benches/evm.rs::benches::evm::GAS_50

18.1 µs

18.2 µs

PUSH0_50

bins/revme/benches/evm.rs::benches::evm::PUSH0_50

18.1 µs

18.2 µs

ADD_50

bins/revme/benches/evm.rs::benches::evm::ADD_50

23.4 µs

23.5 µs

DUP4_50

bins/revme/benches/evm.rs::benches::evm::DUP4_50

23.3 µs

23.4 µs

DUP3_50

bins/revme/benches/evm.rs::benches::evm::DUP3_50

23.3 µs

POP_50

bins/revme/benches/evm.rs::benches::evm::POP_50

20.8 µs

20.9 µs

PUSH22_50

bins/revme/benches/evm.rs::benches::evm::PUSH22_50

18.9 µs

PUSH19_50

bins/revme/benches/evm.rs::benches::evm::PUSH19_50

18.8 µs

18.9 µs

PUSH12_50

bins/revme/benches/evm.rs::benches::evm::PUSH12_50

18.5 µs

18.6 µs

JUMPDEST_50

bins/revme/benches/evm.rs::benches::evm::JUMPDEST_50

15.5 µs

15.6 µs

GASPRICE_50

bins/revme/benches/evm.rs::benches::evm::GASPRICE_50

18.3 µs

18.4 µs

CODESIZE_50

bins/revme/benches/evm.rs::benches::evm::CODESIZE_50

18.2 µs

18.3 µs

ISZERO_50

bins/revme/benches/evm.rs::benches::evm::ISZERO_50

23.4 µs

23.5 µs

JUMPI_50

bins/revme/benches/evm.rs::benches::evm::JUMPI_50

23.2 µs

23.4 µs

transfer_finalize

bins/revme/benches/evm.rs::benches::evm::transfer_finalize

-1%

16.6 µs

16.7 µs

Ignored

LOG0_50Ignored

bins/revme/benches/evm.rs::benches::evm::LOG0_50

31.1 µs

31 µs

LOG1_50Ignored

bins/revme/benches/evm.rs::benches::evm::LOG1_50

37.3 µs

LOG2_50Ignored

bins/revme/benches/evm.rs::benches::evm::LOG2_50

+14%

46.7 µs

41 µs

LOG3_50Ignored

bins/revme/benches/evm.rs::benches::evm::LOG3_50

+1%

43.4 µs

43.1 µs

LOG4_50Ignored

bins/revme/benches/evm.rs::benches::evm::LOG4_50

-7%

48.5 µs

52 µs

evm-buildIgnored

bins/revme/benches/evm.rs::benches::evm::evm-build

15.7 µs

15.6 µs

Commits

Click on a commit to change the comparison range

Base

main

f3c794b

-3.01%

Aggregate changes from PRs #2866, #2867, and #2874 - PR #2866: Fix comment reference from calc_excess_blob_gas to calc_excess_blob_gas_osaka - PR #2867: Remove debug macro from test code in inspector lib - PR #2874: Replace len() == 0 with is_empty() for idiomatic Rust 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>

a791066

21 days ago

by rakita

Home Terms Privacy Docs