DaniPopes:ext-bytecode-hash - Branch - bluealloy/revm

chore: improve ExtBytecode hash handling

#2826Merged

Comparing

DaniPopes:ext-bytecode-hash

(

5c58604

) with

main

(

5f67c14

)

Untouched: 171

Ignored: 6

Benchmarks

Passed

transact_commit_1000txs

bins/revme/benches/evm.rs::benches::evm

+1%

2.8 ms2.8 ms

transfer_finalize

bins/revme/benches/evm.rs::benches::evm

+1%

16.6 µs16.5 µs

PUSH2_50

bins/revme/benches/evm.rs::benches::evm

+1%

18.4 µs18.3 µs

CALL_50

bins/revme/benches/evm.rs::benches::evm

+1%

97.3 µs96.5 µs

transact_1000tx_commit_inner_every_40

bins/revme/benches/evm.rs::benches::evm

+1%

2.1 ms2 ms

analysis

bins/revme/benches/evm.rs::benches::evm

+1%

44.6 µs44.2 µs

STATICCALL_50

bins/revme/benches/evm.rs::benches::evm

+1%

96.4 µs95.6 µs

EXTCODEHASH_50

bins/revme/benches/evm.rs::benches::evm

+1%

37.3 µs37 µs

PUSH27_50

bins/revme/benches/evm.rs::benches::evm

+1%

19.2 µs19.1 µs

transfer

bins/revme/benches/evm.rs::benches::evm

+1%

13 µs12.9 µs

SWAP1_50

bins/revme/benches/evm.rs::benches::evm

+1%

21.1 µs21 µs

SWAP4_50

bins/revme/benches/evm.rs::benches::evm

+1%

21.2 µs21 µs

SWAP2_50

bins/revme/benches/evm.rs::benches::evm

+1%

21.2 µs21 µs

DELEGATECALL_50

bins/revme/benches/evm.rs::benches::evm

+1%

91.3 µs90.8 µs

PUSH23_50

bins/revme/benches/evm.rs::benches::evm

+1%

19.2 µs19.1 µs

DUP7_50

bins/revme/benches/evm.rs::benches::evm

+1%

23.5 µs23.4 µs

NUMBER_50

bins/revme/benches/evm.rs::benches::evm

+1%

18.3 µs18.2 µs

RETURNDATASIZE_50

bins/revme/benches/evm.rs::benches::evm

+1%

18.3 µs18.2 µs

PC_50

bins/revme/benches/evm.rs::benches::evm

+1%

18.4 µs18.3 µs

PUSH4_50

bins/revme/benches/evm.rs::benches::evm

+1%

18.4 µs18.3 µs

PUSH3_50

bins/revme/benches/evm.rs::benches::evm

+1%

18.5 µs18.4 µs

PUSH20_50

bins/revme/benches/evm.rs::benches::evm

+1%

18.9 µs18.8 µs

PUSH22_50

bins/revme/benches/evm.rs::benches::evm

+1%

19 µs18.9 µs

PUSH28_50

bins/revme/benches/evm.rs::benches::evm

+1%

19.2 µs19.1 µs

PUSH32_50

bins/revme/benches/evm.rs::benches::evm

+1%

19.2 µs19.1 µs

REVERT_50

bins/revme/benches/evm.rs::benches::evm

112 µs111.4 µs

SWAP8_50

bins/revme/benches/evm.rs::benches::evm

21.1 µs21 µs

SWAP9_50

bins/revme/benches/evm.rs::benches::evm

21.1 µs21 µs

SWAP3_50

bins/revme/benches/evm.rs::benches::evm

21.1 µs21 µs

SWAP5_50

bins/revme/benches/evm.rs::benches::evm

21.1 µs21 µs

SWAP6_50

bins/revme/benches/evm.rs::benches::evm

21.2 µs21.1 µs

CLZ_50

bins/revme/benches/evm.rs::benches::evm

22.7 µs22.6 µs

AND_50

bins/revme/benches/evm.rs::benches::evm

23.4 µs23.3 µs

DUP8_50

bins/revme/benches/evm.rs::benches::evm

23.6 µs23.5 µs

SUB_50

bins/revme/benches/evm.rs::benches::evm

23.6 µs23.5 µs

LT_50

bins/revme/benches/evm.rs::benches::evm

23.8 µs23.7 µs

GT_50

bins/revme/benches/evm.rs::benches::evm

23.8 µs23.7 µs

SHL_50

bins/revme/benches/evm.rs::benches::evm

24.5 µs24.4 µs

GAS_50

bins/revme/benches/evm.rs::benches::evm

18.2 µs18.1 µs

GASLIMIT_50

bins/revme/benches/evm.rs::benches::evm

18.3 µs18.2 µs

TIMESTAMP_50

bins/revme/benches/evm.rs::benches::evm

18.3 µs18.2 µs

CALLDATASIZE_50

bins/revme/benches/evm.rs::benches::evm

18.3 µs18.2 µs

CHAINID_50

bins/revme/benches/evm.rs::benches::evm

18.3 µs18.2 µs

MSIZE_50

bins/revme/benches/evm.rs::benches::evm

18.3 µs18.3 µs

ORIGIN_50

bins/revme/benches/evm.rs::benches::evm

18.4 µs18.3 µs

PUSH6_50

bins/revme/benches/evm.rs::benches::evm

18.5 µs18.4 µs

PUSH10_50

bins/revme/benches/evm.rs::benches::evm

18.6 µs18.6 µs

PUSH12_50

bins/revme/benches/evm.rs::benches::evm

18.7 µs18.6 µs

PUSH16_50

bins/revme/benches/evm.rs::benches::evm

18.7 µs18.7 µs

PUSH18_50

bins/revme/benches/evm.rs::benches::evm

18.9 µs18.8 µs

PUSH19_50

bins/revme/benches/evm.rs::benches::evm

19 µs18.9 µs

PUSH24_50

bins/revme/benches/evm.rs::benches::evm

19 µs18.9 µs

PUSH26_50

bins/revme/benches/evm.rs::benches::evm

19.1 µs19 µs

PUSH29_50

bins/revme/benches/evm.rs::benches::evm

19.2 µs19.2 µs

PUSH30_50

bins/revme/benches/evm.rs::benches::evm

19.3 µs19.2 µs

PUSH31_50

bins/revme/benches/evm.rs::benches::evm

19.3 µs19.3 µs

MLOAD_50

bins/revme/benches/evm.rs::benches::evm

58 µs57.8 µs

POP_50

bins/revme/benches/evm.rs::benches::evm

20.9 µs20.8 µs

SELFBALANCE_50

bins/revme/benches/evm.rs::benches::evm

20.9 µs20.8 µs

SWAP11_50

bins/revme/benches/evm.rs::benches::evm

21.1 µs21.1 µs

SWAP13_50

bins/revme/benches/evm.rs::benches::evm

21.2 µs21.1 µs

SWAP12_50

bins/revme/benches/evm.rs::benches::evm

21.2 µs21.1 µs

EXTCODESIZE_50

bins/revme/benches/evm.rs::benches::evm

37 µs36.9 µs

DUP15_50

bins/revme/benches/evm.rs::benches::evm

23.4 µs23.3 µs

DUP1_50

bins/revme/benches/evm.rs::benches::evm

23.4 µs23.3 µs

DUP2_50

bins/revme/benches/evm.rs::benches::evm

23.4 µs23.3 µs

DUP4_50

bins/revme/benches/evm.rs::benches::evm

23.4 µs23.3 µs

DUP3_50

bins/revme/benches/evm.rs::benches::evm

23.4 µs23.3 µs

DUP10_50

bins/revme/benches/evm.rs::benches::evm

23.4 µs23.4 µs

DUP9_50

bins/revme/benches/evm.rs::benches::evm

23.4 µs23.4 µs

ISZERO_50

bins/revme/benches/evm.rs::benches::evm

23.5 µs23.4 µs

DUP14_50

bins/revme/benches/evm.rs::benches::evm

23.5 µs23.4 µs

DUP16_50

bins/revme/benches/evm.rs::benches::evm

23.8 µs23.7 µs

MCOPY_COLD_50

bins/revme/benches/evm.rs::benches::evm

24.5 µs24.4 µs

MUL_50

bins/revme/benches/evm.rs::benches::evm

24.6 µs24.5 µs

MSTORE8_50

bins/revme/benches/evm.rs::benches::evm

55.3 µs55.2 µs

CALLDATALOAD_50

bins/revme/benches/evm.rs::benches::evm

57.9 µs57.7 µs

EXP_50

bins/revme/benches/evm.rs::benches::evm

31.1 µs31 µs

PUSH0_50

bins/revme/benches/evm.rs::benches::evm

18.2 µs18.2 µs

CALLVALUE_50

bins/revme/benches/evm.rs::benches::evm

18.2 µs18.2 µs

PUSH1_50

bins/revme/benches/evm.rs::benches::evm

18.2 µs18.2 µs

COINBASE_50

bins/revme/benches/evm.rs::benches::evm

18.4 µs18.3 µs

PUSH8_50

bins/revme/benches/evm.rs::benches::evm

18.5 µs18.4 µs

DIFFICULTY_50

bins/revme/benches/evm.rs::benches::evm

18.5 µs18.5 µs

PUSH7_50

bins/revme/benches/evm.rs::benches::evm

18.6 µs18.6 µs

PUSH11_50

bins/revme/benches/evm.rs::benches::evm

18.7 µs18.6 µs

MSTORE_50

bins/revme/benches/evm.rs::benches::evm

18.7 µs18.6 µs

PUSH14_50

bins/revme/benches/evm.rs::benches::evm

18.8 µs18.7 µs

PUSH17_50

bins/revme/benches/evm.rs::benches::evm

18.8 µs18.8 µs

PUSH15_50

bins/revme/benches/evm.rs::benches::evm

18.9 µs18.8 µs

RETURN_50

bins/revme/benches/evm.rs::benches::evm

110.5 µs110.3 µs

PUSH21_50

bins/revme/benches/evm.rs::benches::evm

19 µs18.9 µs

PUSH25_50

bins/revme/benches/evm.rs::benches::evm

19 µs19 µs

MCOPY_50

bins/revme/benches/evm.rs::benches::evm

20.5 µs20.4 µs

SWAP14_50

bins/revme/benches/evm.rs::benches::evm

21.1 µs21.1 µs

SWAP7_50

bins/revme/benches/evm.rs::benches::evm

21.2 µs21.2 µs

NOT_50

bins/revme/benches/evm.rs::benches::evm

23.3 µs23.3 µs

DUP12_50

bins/revme/benches/evm.rs::benches::evm

23.4 µs23.4 µs

DUP6_50

bins/revme/benches/evm.rs::benches::evm

23.4 µs23.4 µs

XOR_50

bins/revme/benches/evm.rs::benches::evm

23.4 µs23.4 µs

OR_50

bins/revme/benches/evm.rs::benches::evm

23.4 µs23.4 µs

ADD_50

bins/revme/benches/evm.rs::benches::evm

23.4 µs23.4 µs

DUP13_50

bins/revme/benches/evm.rs::benches::evm

23.5 µs23.4 µs

DUP11_50

bins/revme/benches/evm.rs::benches::evm

23.6 µs23.5 µs

EQ_50

bins/revme/benches/evm.rs::benches::evm

23.6 µs23.6 µs

BYTE_50

bins/revme/benches/evm.rs::benches::evm

23.7 µs23.7 µs

SGT_50

bins/revme/benches/evm.rs::benches::evm

24.3 µs24.2 µs

SLT_50

bins/revme/benches/evm.rs::benches::evm

24.3 µs24.3 µs

SIGNEXTEND_50

bins/revme/benches/evm.rs::benches::evm

24.4 µs24.4 µs

SHR_50

bins/revme/benches/evm.rs::benches::evm

24.7 µs24.7 µs

DIV_50

bins/revme/benches/evm.rs::benches::evm

26.2 µs26.1 µs

SDIV_50

bins/revme/benches/evm.rs::benches::evm

27.4 µs27.3 µs

RETURNDATACOPY_50

bins/revme/benches/evm.rs::benches::evm

106.2 µs106.1 µs

CALLDATACOPY_50

bins/revme/benches/evm.rs::benches::evm

56.8 µs56.7 µs

KECCAK256_50

bins/revme/benches/evm.rs::benches::evm

144.2 µs144.2 µs

g2_add

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks

43.5 µs43.4 µs

JUMPDEST_50

bins/revme/benches/evm.rs::benches::evm

15.6 µs15.6 µs

JUMP_50

bins/revme/benches/evm.rs::benches::evm

17.9 µs17.9 µs

CODESIZE_50

bins/revme/benches/evm.rs::benches::evm

18.3 µs18.3 µs

ADDRESS_50

bins/revme/benches/evm.rs::benches::evm

18.3 µs18.3 µs

CALLER_50

bins/revme/benches/evm.rs::benches::evm

18.3 µs18.3 µs

GASPRICE_50

bins/revme/benches/evm.rs::benches::evm

18.5 µs18.4 µs

PUSH9_50

bins/revme/benches/evm.rs::benches::evm

18.5 µs18.5 µs

PUSH13_50

bins/revme/benches/evm.rs::benches::evm

18.7 µs18.7 µs

SWAP10_50

bins/revme/benches/evm.rs::benches::evm

21.3 µs21.3 µs

SWAP16_50

bins/revme/benches/evm.rs::benches::evm

21.3 µs21.3 µs

SWAP15_50

bins/revme/benches/evm.rs::benches::evm

21.4 µs21.4 µs

MSTORE_COLD_50

bins/revme/benches/evm.rs::benches::evm

22.9 µs22.9 µs

JUMPI_50

bins/revme/benches/evm.rs::benches::evm

23.4 µs23.4 µs

DUP5_50

bins/revme/benches/evm.rs::benches::evm

23.4 µs23.4 µs

SAR_50

bins/revme/benches/evm.rs::benches::evm

24.9 µs24.9 µs

MULMOD_50

bins/revme/benches/evm.rs::benches::evm

29.5 µs29.5 µs

bn254 mul precompile

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks

335.4 µs335.4 µs

ecpairing precompile

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks

4.7 ms4.7 ms

burntpix

bins/revme/benches/evm.rs::benches::evm

468.9 ms468.9 ms

pairing (1 pairs)

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks

4.4 ms4.4 ms

snailtracer

bins/revme/benches/evm.rs::benches::evm

175.8 ms175.8 ms

pairing (16 pairs)

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks

36.5 ms36.5 ms

g1_msm (size 256)

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks

89.2 ms89.2 ms

analysis-inspector

bins/revme/benches/evm.rs::benches::evm

385.8 ms385.8 ms

pairing (8 pairs)

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks

19.4 ms19.4 ms

kzg precompile

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks

7.5 ms7.5 ms

blake2/1024_rounds

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks

100.2 µs100.2 µs

blake2/10_rounds

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks

4.5 µs4.5 µs

blake2/2_rounds

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks

3.3 µs3.3 µs

blake2/64_rounds

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks

9.6 µs9.6 µs

blake2/512_rounds

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks

51.9 µs51.9 µs

blake2/4_rounds

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks

3.5 µs3.5 µs

blake2/200K_rounds

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks

18.9 ms18.9 ms

blake2/100K_rounds

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks

9.4 ms9.4 ms

blake2/12_rounds

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks

4.6 µs4.6 µs

bn254 add precompile

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks

21.3 µs21.3 µs

g2_msm (size 1)

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks

1.3 ms1.3 ms

g1_add

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks

28.4 µs28.4 µs

pairing (2 pairs)

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks

6.5 ms6.5 ms

map_fp_to_g1

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks

244.1 µs244.1 µs

blake2/compress_12_rounds

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks

3.3 µs3.3 µs

map_fp2_to_g2

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks

861.1 µs861.1 µs

g1_msm (size 1)

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks

714.7 µs714.7 µs

g2_msm (size 256)

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks

162.3 ms162.3 ms

g1_msm (size 128)

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks

47 ms47 ms

g2_msm (size 128)

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks

88.2 ms88.2 ms

g1_msm (size 2)

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks

1.4 ms1.4 ms

g2_msm (size 2)

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks

2.7 ms2.7 ms

ADDMOD_50

bins/revme/benches/evm.rs::benches::evm

31 µs31 µs

SMOD_50

bins/revme/benches/evm.rs::benches::evm

27.2 µs27.2 µs

MOD_50

bins/revme/benches/evm.rs::benches::evm

26.1 µs26.1 µs

PUSH5_50

bins/revme/benches/evm.rs::benches::evm

18.5 µs18.5 µs

CREATE_50

bins/revme/benches/evm.rs::benches::evm

400.4 µs401.7 µs

EXTCODECOPY_50

bins/revme/benches/evm.rs::benches::evm

-1%

45.9 µs46.3 µs

ecrecover precompile

crates/precompile/bench/main.rs::benches::benchmark_crypto_precompiles::Crypto Precompile benchmarks

-2%

201.1 µs204.6 µs

Ignored

evm-build

bins/revme/benches/evm.rs::benches::evm

Ignored

-1%

9.3 µs9.4 µs

LOG1_50

bins/revme/benches/evm.rs::benches::evm

Ignored

-13%

43.3 µs49.8 µs

LOG3_50

bins/revme/benches/evm.rs::benches::evm

Ignored

-13%

49.6 µs57.3 µs

LOG0_50

bins/revme/benches/evm.rs::benches::evm

Ignored

+1%

34.1 µs33.9 µs

LOG4_50

bins/revme/benches/evm.rs::benches::evm

Ignored

+11%

62.5 µs56.3 µs

LOG2_50

bins/revme/benches/evm.rs::benches::evm

Ignored

53 µs53 µs

Commits

Click on a commit to change the comparison range

Base

main

5f67c14

+0.23%

chore: improve ExtBytecode hash handling - Currently in foundry we check for None OR hash==zero to check if it's unset. Use `None` in all cases. - Provide a helper for `get_or_insert_with()` that calculates the hash if unset.

5c58604

2 months ago

by DaniPopes

Home Terms Privacy Docs