tt-a1i:fix/use-consistent-arrow-return-asi - Branch - biomejs/biome

fix(linter): prevent useConsistentArrowReturn from producing ASI-affected code

#8440

Comparing

tt-a1i:fix/use-consistent-arrow-return-asi

(

e4bc3f2

) with

main

(

a78774b

)

Untouched: 58

Ignored: 2

Skipped: 95

No successful run was found on main ( a392c06) during the generation of this report, so a78774b was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Benchmarks

Skipped (95)

Passed

parser_13571644119461115204.ts[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

+2%

6.1 ms5.9 ms

jquery.min_16034160674129647344.js[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

+2%

28.1 ms27.4 ms

compiler_3469143416596620219.js[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

+2%

162.2 ms159.3 ms

dojo_11880045762646467684.js[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

+1%

7.8 ms7.7 ms

react.production.min_3378072959512366797.js[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

+1%

2 ms2 ms

dojo_11880045762646467684.js[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

+1%

8.7 ms8.6 ms

checker_6456328407951392140.ts[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

+1%

268.6 ms266.5 ms

js_formatter[vue.global.prod_4065256639735990520.js]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

+1%

175.8 ms174.7 ms

parser_13571644119461115204.ts[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

+1%

6.6 ms6.5 ms

jquery.min_16034160674129647344.js[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

+1%

26.1 ms25.9 ms

js_formatter[d3.min_16009850199655599998.js]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

430.2 ms428.1 ms

three.min_17199329737537001178.js[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

133.6 ms132.9 ms

tex-chtml-full_561698452596513081.js[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

272 ms270.8 ms

js_formatter[typescript_5583633924076080079.js]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

3.4 s3.4 s

js_analyzer[parser_13571644119461115204.ts]

crates/biome_js_analyze/benches/js_analyzer.rs::js_analyzer::bench_analyzer

102.3 ms102 ms

js_formatter[ios.d_12216376241674358710.d.ts]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

758.8 ms756.1 ms

js_formatter[three.min_17199329737537001178.js]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

571.6 ms569.6 ms

ios.d_12216376241674358710.d.ts[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

250.4 ms249.5 ms

vue.global.prod_4065256639735990520.js[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

44.6 ms44.5 ms

js_analyzer[router_17129688031671448157.ts]

crates/biome_js_analyze/benches/js_analyzer.rs::js_analyzer::bench_analyzer

27.7 ms27.6 ms

js_analyzer[statement_263793315104667298.ts]

crates/biome_js_analyze/benches/js_analyzer.rs::js_analyzer::bench_analyzer

87.8 ms87.5 ms

js_analyzer[css_16118272471217147034.js]

crates/biome_js_analyze/benches/js_analyzer.rs::js_analyzer::bench_analyzer

25.3 ms25.2 ms

js_analyzer[typescript_3735799142832611563.ts]

crates/biome_js_analyze/benches/js_analyzer.rs::js_analyzer::bench_analyzer

138.1 ms137.7 ms

js_analyzer[index_3894593175024091846.js]

crates/biome_js_analyze/benches/js_analyzer.rs::js_analyzer::bench_analyzer

60.5 ms60.4 ms

js_formatter[tex-chtml-full_561698452596513081.js]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

1.1 s1.1 s

js_analyzer[lint_13640784270757307929.ts]

crates/biome_js_analyze/benches/js_analyzer.rs::js_analyzer::bench_analyzer

56.9 ms56.8 ms

typescript_5583633924076080079.js[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

1 s1 s

three.min_17199329737537001178.js[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

143.5 ms143.3 ms

vue.global.prod_4065256639735990520.js[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

41.5 ms41.4 ms

react.production.min_3378072959512366797.js[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

1.8 ms1.8 ms

js_formatter[math_5920422916221598348.js]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

841.8 ms840.8 ms

js_formatter[jquery.min_16034160674129647344.js]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

113.5 ms113.4 ms

js_formatter[pixi.min_8151088792683739606.js]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

468.3 ms468 ms

ios.d_12216376241674358710.d.ts[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

270.1 ms270.1 ms

class_strings[arbitrary_classes]

crates/biome_js_analyze/benches/use_sorted_classes_parser.rs::use_sorted_classes_parser::bench_use_sorted_classes_parser::use_sorted_classes_parser

33.2 µs33.2 µs

class_strings[simple_classes]

crates/biome_js_analyze/benches/use_sorted_classes_parser.rs::use_sorted_classes_parser::bench_use_sorted_classes_parser::use_sorted_classes_parser

20.2 µs20.2 µs

compiler_3469143416596620219.js[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

140.2 ms140.2 ms

class_strings[stress]

crates/biome_js_analyze/benches/use_sorted_classes_parser.rs::use_sorted_classes_parser::bench_use_sorted_classes_parser::use_sorted_classes_parser

375.7 µs375.7 µs

js_formatter[router_17129688031671448157.ts]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

6.5 ms6.5 ms

typescript_5583633924076080079.js[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

926.4 ms926.6 ms

class_strings[extreme_stress]

crates/biome_js_analyze/benches/use_sorted_classes_parser.rs::use_sorted_classes_parser::bench_use_sorted_classes_parser::use_sorted_classes_parser

152 µs152.1 µs

js_formatter[dojo_11880045762646467684.js]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

27.2 ms27.2 ms

tex-chtml-full_561698452596513081.js[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

259.5 ms259.6 ms

react-dom.production.min_7131952758041326366.js[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

34.2 ms34.2 ms

js_formatter[compiler_3469143416596620219.js]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

529 ms529.5 ms

js_formatter[react.production.min_3378072959512366797.js]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

6.9 ms6.9 ms

class_strings[variant_classes]

crates/biome_js_analyze/benches/use_sorted_classes_parser.rs::use_sorted_classes_parser::bench_use_sorted_classes_parser::use_sorted_classes_parser

37.4 µs37.5 µs

js_formatter[checker_6456328407951392140.ts]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

902.6 ms904.4 ms

pixi.min_8151088792683739606.js[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

119.2 ms119.6 ms

d3.min_16009850199655599998.js[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

104.4 ms104.8 ms

js_formatter[parser_13571644119461115204.ts]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

-1%

19.3 ms19.4 ms

d3.min_16009850199655599998.js[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

-1%

113 ms113.6 ms

math_5920422916221598348.js[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

-1%

195.5 ms196.7 ms

math_5920422916221598348.js[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

-1%

201 ms202.2 ms

react-dom.production.min_7131952758041326366.js[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

-1%

36.9 ms37.2 ms

checker_6456328407951392140.ts[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

-1%

243.2 ms245.7 ms

pixi.min_8151088792683739606.js[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

-1%

128.4 ms129.8 ms

js_formatter[react-dom.production.min_7131952758041326366.js]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

-1%

134.2 ms136.2 ms

Ignored

router_17129688031671448157.ts[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

Ignored

2 ms2 ms

router_17129688031671448157.ts[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

Ignored

2.3 ms2.3 ms

Commits

Click on a commit to change the comparison range

Base

main

a78774b

+0.2%

fix(linter): prevent useConsistentArrowReturn from producing ASI-affected code When adding braces to arrow functions with multiline expressions, the autofix previously preserved leading trivia (newlines) from the original expression. This could place a newline between `return` and the expression, triggering JavaScript's automatic semicolon insertion and causing the function to return `undefined` instead of the value. Fixed by trimming leading trivia from the expression before inserting it after the `return` keyword. Fixes #8179

e4bc3f2

2 days ago

by tt-a1i

Home Terms Privacy Docs