rahuld109:refactor/consolidate-a11y-helpers - Branch - biomejs/biome

fix(biome_html_analyze): consolidate a11y helpers and fix aria-hidden behavior

#8837Merged

Comparing

rahuld109:refactor/consolidate-a11y-helpers

(

4002ece

) with

(

883ea1d

)

-5%

Untouched: 3

New: 1

Skipped: 152

Benchmarks

156 total

html_analyzer[index_1033418810622582172.html]

crates/biome_html_analyze/benches/html_analyzer.rs::html_analyzer::bench_analyzer

N/A

N/A397.8 µs

html_formatter[index_1033418810622582172.html]

crates/biome_html_formatter/benches/html_formatter.rs::html_formatter::bench_formatter

-3%

476.2 µs*493.2 µs

index_1033418810622582172.html[cached]

crates/biome_html_parser/benches/html_parser.rs::html_parser::bench_parser::html_parser

-5%

102 µs*107.8 µs

index_1033418810622582172.html[uncached]

crates/biome_html_parser/benches/html_parser.rs::html_parser::bench_parser::html_parser

-6%

118.2 µs*125.3 µs

The benchmarks below were skipped, so their baseline results are used instead. If they were deleted in your codebase, archive them to remove them from the performance reports.
Learn more about archiving benchmarks

versions[2.3.533]

crates/biome_package/benches/semver.rs

Skipped

2.6 µs*

tsconfig_json

crates/biome_package/benches/tsconfig_json.rs

Skipped

609.1 µs*

versions[1.0.0-beta.11]

crates/biome_package/benches/semver.rs

Skipped

3.5 µs*

ranges[1.2]

crates/biome_package/benches/semver.rs

Skipped

5.6 µs*

versions[1.0.0-beta]

crates/biome_package/benches/semver.rs

Skipped

3.3 µs*

versions[1.0.0-beta.2]

crates/biome_package/benches/semver.rs

Skipped

3.5 µs*

ranges[1.2.3 - 2.3.4]

crates/biome_package/benches/semver.rs

Skipped

5.3 µs*

versions[1.0.0-alpha.beta]

crates/biome_package/benches/semver.rs

Skipped

3.5 µs*

ranges[1.2.7 || >=1.2.9 <2.0.0]

crates/biome_package/benches/semver.rs

Skipped

7.6 µs*

versions[1.0.0-rc.1]

crates/biome_package/benches/semver.rs

Skipped

3.4 µs*

ranges[~1.2.3]

crates/biome_package/benches/semver.rs

Skipped

5.8 µs*

ranges[>=1.2.3]

crates/biome_package/benches/semver.rs

Skipped

5.2 µs*

versions[0.3.533]

crates/biome_package/benches/semver.rs

Skipped

2.6 µs*

ranges[^1.2.3]

crates/biome_package/benches/semver.rs

Skipped

5.8 µs*

versions[1.0.0-alpha]

crates/biome_package/benches/semver.rs

Skipped

3.3 µs*

ranges[<=1.2.3]

crates/biome_package/benches/semver.rs

Skipped

5.3 µs*

package_json

crates/biome_package/benches/package_json.rs

Skipped

1 ms*

versions[1.0.0-alpha.1]

crates/biome_package/benches/semver.rs

Skipped

3.4 µs*

ranges[>=1.2.9 <2.0.0]

crates/biome_package/benches/semver.rs

Skipped

5.9 µs*

index_d_ts[@next/font/google/index.d.ts]

crates/biome_module_graph/benches/module_graph.rs

Skipped

314.3 ms*

index_d_ts[astro_server.mjs]

crates/biome_module_graph/benches/module_graph.rs

Skipped

116 ms*

Commits

Click on a commit to change the comparison range

Base

883ea1d

-4.83%

[autofix.ci] apply automated fixes

b345567

3 months ago

by autofix-ci[bot]

-0.02%

refactor(biome_html_analyze): extract shared a11y helper logic

02bd109

3 months ago

by rahuld109

refactor(biome_html_analyze): extract core attribute helper as foundation

8dd95a9

3 months ago

by rahuld109

+0.02%

[autofix.ci] apply automated fixes

fee99c5

3 months ago

by autofix-ci[bot]

-0.02%

docs(biome_html_analyze): add docstrings to a11y helpers

2434aec

3 months ago

by rahuld109

+0.01%

refactor(biome_html_analyze): address PR review comments

7395933

3 months ago

by rahuld109

test(biome_html_analyze): expand a11y unit tests with edge cases

fc78ca6

3 months ago

by rahuld109

-0.1%

fix(biome_html_analyze): treat empty/whitespace aria-hidden as falsy

208f65f

3 months ago

by rahuld109

+0.09%

fix(biome_html_analyze): use consistent aria-hidden check in is_hidden_from_screen_reader

4002ece

3 months ago

by rahuld109

Home Terms Privacy Docs