matanshavit:fix/is-recursive-call - Branch - biomejs/biome

fix(noParametersOnlyUsedInRecursion): compare bindings for recursion detection

#8026

Comparing

matanshavit:fix/is-recursive-call

(

697987f

) with

main

(

5c55347

)

Untouched: 53

Ignored: 2

Skipped: 85

No successful run was found on main ( 96f3e77) during the generation of this report, so 5c55347 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Benchmarks

Skipped (85)

Passed

jquery.min_16034160674129647344.js[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

+2%

26.3 ms25.7 ms

ios.d_12216376241674358710.d.ts[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

+2%

250.7 ms246.9 ms

vue.global.prod_4065256639735990520.js[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

+1%

42 ms41.4 ms

d3.min_16009850199655599998.js[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

+1%

110 ms108.8 ms

dojo_11880045762646467684.js[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

+1%

7.8 ms7.7 ms

dojo_11880045762646467684.js[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

+1%

8.6 ms8.5 ms

ios.d_12216376241674358710.d.ts[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

+1%

273.6 ms271.4 ms

react-dom.production.min_7131952758041326366.js[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

+1%

37 ms36.7 ms

js_formatter[typescript_5583633924076080079.js]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

3.5 s3.5 s

parser_13571644119461115204.ts[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

6.6 ms6.6 ms

js_formatter[ios.d_12216376241674358710.d.ts]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

761.3 ms759.4 ms

js_analyzer[typescript_3735799142832611563.ts]

crates/biome_js_analyze/benches/js_analyzer.rs::js_analyzer::bench_analyzer

133.7 ms133.4 ms

compiler_3469143416596620219.js[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

142.4 ms142.2 ms

js_formatter[parser_13571644119461115204.ts]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

19.6 ms19.5 ms

checker_6456328407951392140.ts[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

267.8 ms267.3 ms

js_formatter[react.production.min_3378072959512366797.js]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

6.9 ms6.9 ms

tex-chtml-full_561698452596513081.js[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

259.1 ms258.7 ms

tex-chtml-full_561698452596513081.js[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

271.3 ms270.9 ms

parser_13571644119461115204.ts[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

6 ms6 ms

js_formatter[three.min_17199329737537001178.js]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

577.5 ms577.3 ms

d3.min_16009850199655599998.js[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

101.4 ms101.4 ms

react-dom.production.min_7131952758041326366.js[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

34.1 ms34.1 ms

js_analyzer[parser_13571644119461115204.ts]

crates/biome_js_analyze/benches/js_analyzer.rs::js_analyzer::bench_analyzer

99.5 ms99.5 ms

jquery.min_16034160674129647344.js[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

27.3 ms27.3 ms

js_formatter[checker_6456328407951392140.ts]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

909.4 ms909.5 ms

js_formatter[d3.min_16009850199655599998.js]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

433.9 ms433.9 ms

js_formatter[vue.global.prod_4065256639735990520.js]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

177 ms177 ms

js_formatter[tex-chtml-full_561698452596513081.js]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

1.1 s1.1 s

js_formatter[math_5920422916221598348.js]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

848.7 ms848.9 ms

js_analyzer[router_17129688031671448157.ts]

crates/biome_js_analyze/benches/js_analyzer.rs::js_analyzer::bench_analyzer

26.7 ms26.7 ms

math_5920422916221598348.js[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

193.4 ms193.5 ms

typescript_5583633924076080079.js[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

1 s1 s

pixi.min_8151088792683739606.js[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

118.4 ms118.5 ms

js_analyzer[lint_13640784270757307929.ts]

crates/biome_js_analyze/benches/js_analyzer.rs::js_analyzer::bench_analyzer

56.7 ms56.8 ms

react.production.min_3378072959512366797.js[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

1.8 ms1.8 ms

js_formatter[router_17129688031671448157.ts]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

6.6 ms6.6 ms

js_formatter[dojo_11880045762646467684.js]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

27.4 ms27.5 ms

js_analyzer[css_16118272471217147034.js]

crates/biome_js_analyze/benches/js_analyzer.rs::js_analyzer::bench_analyzer

24.1 ms24.1 ms

compiler_3469143416596620219.js[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

157.7 ms158.2 ms

pixi.min_8151088792683739606.js[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

125.9 ms126.3 ms

vue.global.prod_4065256639735990520.js[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

44.4 ms44.6 ms

js_analyzer[index_3894593175024091846.js]

crates/biome_js_analyze/benches/js_analyzer.rs::js_analyzer::bench_analyzer

59.1 ms59.3 ms

js_formatter[compiler_3469143416596620219.js]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

531.9 ms534.2 ms

math_5920422916221598348.js[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

205 ms205.9 ms

js_analyzer[statement_263793315104667298.ts]

crates/biome_js_analyze/benches/js_analyzer.rs::js_analyzer::bench_analyzer

-1%

84.5 ms84.9 ms

js_formatter[react-dom.production.min_7131952758041326366.js]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

-1%

135.9 ms136.8 ms

react.production.min_3378072959512366797.js[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

-1%

2 ms2 ms

js_formatter[pixi.min_8151088792683739606.js]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

-1%

471.8 ms475.2 ms

checker_6456328407951392140.ts[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

-1%

242 ms244.3 ms

typescript_5583633924076080079.js[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

-1%

912 ms921.7 ms

js_formatter[jquery.min_16034160674129647344.js]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

-1%

113 ms114.3 ms

three.min_17199329737537001178.js[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

-1%

141.3 ms142.9 ms

three.min_17199329737537001178.js[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

-2%

132.9 ms135.3 ms

Ignored

router_17129688031671448157.ts[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

Ignored

2 ms2 ms

router_17129688031671448157.ts[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

Ignored

-1%

2.3 ms2.3 ms

Commits

Click on a commit to change the comparison range

Base

main

5c55347

-0.06%

fix(noParametersOnlyUsedInRecursion): compare bindings for recursion detection Compare function bindings in addition to names for recursion detection. This prevents false positives when a method has the same name as an outer function but calls the outer function (not itself).

fde87f3

23 hours ago

by matanshavit

+0.05%

fix(noParametersOnlyUsedInRecursion): detect recursion in assignment expressions

697987f

22 hours ago

by matanshavit

Home Terms Privacy Docs