harshasiddartha:fix/no-extra-non-null-assertion-compound-assignment - Branch - biomejs/biome

fix(lint): don't flag separate non-null assertions on assignment sides

#7935

Comparing

harshasiddartha:fix/no-extra-non-null-assertion-compound-assignment

(

a0fe59d

) with

main

(

69cecec

)

Untouched: 53

Ignored: 2

Skipped: 85

Benchmarks

Skipped (85)

Passed

pixi.min_8151088792683739606.js[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

+1%

128.1 ms126.7 ms

dojo_11880045762646467684.js[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

+1%

7.8 ms7.7 ms

math_5920422916221598348.js[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

+1%

197.6 ms196.2 ms

js_formatter[jquery.min_16034160674129647344.js]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

+1%

113 ms112.3 ms

js_formatter[react-dom.production.min_7131952758041326366.js]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

+1%

136.2 ms135.4 ms

js_formatter[compiler_3469143416596620219.js]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

532.4 ms529.9 ms

js_analyzer[typescript_3735799142832611563.ts]

crates/biome_js_analyze/benches/js_analyzer.rs::js_analyzer::bench_analyzer

133.4 ms132.9 ms

checker_6456328407951392140.ts[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

272.8 ms271.7 ms

math_5920422916221598348.js[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

209.4 ms208.7 ms

three.min_17199329737537001178.js[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

144.4 ms143.9 ms

js_formatter[math_5920422916221598348.js]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

844.1 ms841.5 ms

js_formatter[typescript_5583633924076080079.js]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

3.4 s3.4 s

parser_13571644119461115204.ts[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

6 ms6 ms

js_analyzer[parser_13571644119461115204.ts]

crates/biome_js_analyze/benches/js_analyzer.rs::js_analyzer::bench_analyzer

99.2 ms99 ms

js_formatter[three.min_17199329737537001178.js]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

573.5 ms572.6 ms

js_formatter[ios.d_12216376241674358710.d.ts]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

754.2 ms753.1 ms

jquery.min_16034160674129647344.js[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

26.1 ms26 ms

js_formatter[checker_6456328407951392140.ts]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

907.1 ms906.2 ms

js_analyzer[css_16118272471217147034.js]

crates/biome_js_analyze/benches/js_analyzer.rs::js_analyzer::bench_analyzer

24 ms24 ms

js_analyzer[index_3894593175024091846.js]

crates/biome_js_analyze/benches/js_analyzer.rs::js_analyzer::bench_analyzer

58.8 ms58.8 ms

jquery.min_16034160674129647344.js[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

27.7 ms27.7 ms

js_formatter[router_17129688031671448157.ts]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

6.5 ms6.5 ms

js_formatter[vue.global.prod_4065256639735990520.js]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

176.1 ms176 ms

tex-chtml-full_561698452596513081.js[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

261.2 ms261.2 ms

js_formatter[pixi.min_8151088792683739606.js]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

469.3 ms469.4 ms

vue.global.prod_4065256639735990520.js[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

41.9 ms41.9 ms

d3.min_16009850199655599998.js[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

111.9 ms111.9 ms

js_formatter[tex-chtml-full_561698452596513081.js]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

1.1 s1.1 s

d3.min_16009850199655599998.js[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

102.6 ms102.7 ms

js_analyzer[lint_13640784270757307929.ts]

crates/biome_js_analyze/benches/js_analyzer.rs::js_analyzer::bench_analyzer

56.8 ms56.8 ms

typescript_5583633924076080079.js[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

923.8 ms924.7 ms

react-dom.production.min_7131952758041326366.js[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

34.4 ms34.5 ms

js_formatter[d3.min_16009850199655599998.js]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

429.7 ms430.3 ms

tex-chtml-full_561698452596513081.js[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

272.9 ms273.3 ms

vue.global.prod_4065256639735990520.js[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

45.3 ms45.4 ms

react-dom.production.min_7131952758041326366.js[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

37.4 ms37.6 ms

dojo_11880045762646467684.js[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

8.7 ms8.7 ms

js_analyzer[router_17129688031671448157.ts]

crates/biome_js_analyze/benches/js_analyzer.rs::js_analyzer::bench_analyzer

26.7 ms26.8 ms

compiler_3469143416596620219.js[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

143.5 ms144 ms

js_formatter[dojo_11880045762646467684.js]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

27.3 ms27.4 ms

parser_13571644119461115204.ts[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

6.6 ms6.7 ms

js_formatter[react.production.min_3378072959512366797.js]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

6.9 ms6.9 ms

checker_6456328407951392140.ts[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

245.4 ms246.6 ms

typescript_5583633924076080079.js[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

-1%

1 s1 s

js_analyzer[statement_263793315104667298.ts]

crates/biome_js_analyze/benches/js_analyzer.rs::js_analyzer::bench_analyzer

-1%

84.2 ms84.6 ms

js_formatter[parser_13571644119461115204.ts]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

-1%

19.3 ms19.4 ms

three.min_17199329737537001178.js[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

-1%

135.5 ms136.7 ms

react.production.min_3378072959512366797.js[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

-1%

2 ms2.1 ms

pixi.min_8151088792683739606.js[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

-1%

120 ms121.2 ms

ios.d_12216376241674358710.d.ts[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

-1%

275 ms278.3 ms

compiler_3469143416596620219.js[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

-2%

158.3 ms160.8 ms

ios.d_12216376241674358710.d.ts[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

-2%

248.6 ms252.7 ms

react.production.min_3378072959512366797.js[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

-4%

1.8 ms1.9 ms

Ignored

router_17129688031671448157.ts[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

Ignored

-1%

2.3 ms2.3 ms

router_17129688031671448157.ts[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

Ignored

2 ms2 ms

Commits

Click on a commit to change the comparison range

Base

main

69cecec

-0.27%

fix(lint): also flag nested assertions on right side of assignments Address reviewer feedback: ensure nested assertions like arr[0] ^= arr[1]!! are correctly flagged. The fix now checks for nested assertions first before checking assignment-specific cases, ensuring all nested assertions are caught regardless of which side of the assignment they appear on.

bcb61e9

3 days ago

by harshasiddartha

+0.17%

style: apply rustfmt formatting

6264dc4

3 days ago

by harshasiddartha

+0.09%

docs(changeset): add issue link, rule docs, and examples

753020f

22 hours ago

by harshasiddartha

-0.16%

docs(changeset): fix markdownlint MD026 (no trailing punctuation in headings)

a0fe59d

22 hours ago

by harshasiddartha

Home Terms Privacy Docs