emilyinure:fix-single-file-import-cycle - Branch - biomejs/biome

fix(noImportCycles): prevent flagging on single file import cycling

#6765

Comparing

emilyinure:fix-single-file-import-cycle

(

00ed23d

) with

main

(

0c8349e

)

Untouched: 58

Ignored: 2

Skipped: 95

Benchmarks

Skipped (95)

Passed

compiler_3469143416596620219.js[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

+3%

162.6 ms*157.4 ms

parser_13571644119461115204.ts[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

+3%

6.7 ms*6.5 ms

react-dom.production.min_7131952758041326366.js[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

+3%

35 ms*34.1 ms

three.min_17199329737537001178.js[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

+1%

144.8 ms*142.8 ms

js_formatter[react-dom.production.min_7131952758041326366.js]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

+1%

139.2 ms*137.3 ms

three.min_17199329737537001178.js[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

+1%

134.2 ms*132.5 ms

pixi.min_8151088792683739606.js[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

+1%

129.2 ms*127.6 ms

js_formatter[vue.global.prod_4065256639735990520.js]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

+1%

177.8 ms*175.8 ms

d3.min_16009850199655599998.js[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

+1%

112.4 ms*111.3 ms

pixi.min_8151088792683739606.js[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

+1%

119.9 ms*119 ms

tex-chtml-full_561698452596513081.js[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

+1%

260.9 ms*259.1 ms

js_analyzer[statement_263793315104667298.ts]

crates/biome_js_analyze/benches/js_analyzer.rs::js_analyzer::bench_analyzer

+1%

88.7 ms*88.1 ms

parser_13571644119461115204.ts[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

+1%

6 ms*6 ms

ios.d_12216376241674358710.d.ts[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

+1%

270.9 ms*269.4 ms

js_formatter[pixi.min_8151088792683739606.js]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

479 ms*476.7 ms

d3.min_16009850199655599998.js[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

104.6 ms*104.2 ms

ios.d_12216376241674358710.d.ts[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

250.8 ms*249.7 ms

js_formatter[compiler_3469143416596620219.js]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

537.6 ms*535.8 ms

math_5920422916221598348.js[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

196.3 ms*195.7 ms

js_formatter[three.min_17199329737537001178.js]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

581.1 ms*579.9 ms

math_5920422916221598348.js[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

204.6 ms*204.2 ms

typescript_5583633924076080079.js[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

1 s*1 s

vue.global.prod_4065256639735990520.js[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

44.6 ms*44.5 ms

js_formatter[parser_13571644119461115204.ts]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

19.6 ms*19.6 ms

jquery.min_16034160674129647344.js[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

25.8 ms*25.8 ms

class_strings[stress]

crates/biome_js_analyze/benches/use_sorted_classes_parser.rs::use_sorted_classes_parser::bench_use_sorted_classes_parser::use_sorted_classes_parser

375.6 µs*375.7 µs

class_strings[extreme_stress]

crates/biome_js_analyze/benches/use_sorted_classes_parser.rs::use_sorted_classes_parser::bench_use_sorted_classes_parser::use_sorted_classes_parser

151.9 µs*152 µs

js_analyzer[router_17129688031671448157.ts]

crates/biome_js_analyze/benches/js_analyzer.rs::js_analyzer::bench_analyzer

27.1 ms*27.1 ms

react.production.min_3378072959512366797.js[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

1.8 ms*1.8 ms

js_analyzer[typescript_3735799142832611563.ts]

crates/biome_js_analyze/benches/js_analyzer.rs::js_analyzer::bench_analyzer

140.1 ms*140.2 ms

js_analyzer[index_3894593175024091846.js]

crates/biome_js_analyze/benches/js_analyzer.rs::js_analyzer::bench_analyzer

61.1 ms*61.1 ms

js_analyzer[parser_13571644119461115204.ts]

crates/biome_js_analyze/benches/js_analyzer.rs::js_analyzer::bench_analyzer

94.1 ms*94.1 ms

js_analyzer[css_16118272471217147034.js]

crates/biome_js_analyze/benches/js_analyzer.rs::js_analyzer::bench_analyzer

25.2 ms*25.2 ms

vue.global.prod_4065256639735990520.js[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

41.4 ms*41.4 ms

compiler_3469143416596620219.js[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

140.1 ms*140.2 ms

class_strings[arbitrary_classes]

crates/biome_js_analyze/benches/use_sorted_classes_parser.rs::use_sorted_classes_parser::bench_use_sorted_classes_parser::use_sorted_classes_parser

33.1 µs*33.2 µs

js_formatter[math_5920422916221598348.js]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

852.3 ms*853.4 ms

js_formatter[checker_6456328407951392140.ts]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

915.5 ms*916.8 ms

class_strings[simple_classes]

crates/biome_js_analyze/benches/use_sorted_classes_parser.rs::use_sorted_classes_parser::bench_use_sorted_classes_parser::use_sorted_classes_parser

20.1 µs*20.1 µs

js_analyzer[lint_13640784270757307929.ts]

crates/biome_js_analyze/benches/js_analyzer.rs::js_analyzer::bench_analyzer

57.1 ms*57.2 ms

react-dom.production.min_7131952758041326366.js[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

36.8 ms*36.8 ms

class_strings[variant_classes]

crates/biome_js_analyze/benches/use_sorted_classes_parser.rs::use_sorted_classes_parser::bench_use_sorted_classes_parser::use_sorted_classes_parser

37.3 µs*37.4 µs

js_formatter[dojo_11880045762646467684.js]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

27.6 ms*27.6 ms

dojo_11880045762646467684.js[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

8.6 ms*8.6 ms

js_formatter[ios.d_12216376241674358710.d.ts]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

760.8 ms*762.3 ms

js_formatter[tex-chtml-full_561698452596513081.js]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

1.1 s*1.1 s

typescript_5583633924076080079.js[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

922.9 ms*924.9 ms

js_formatter[router_17129688031671448157.ts]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

6.6 ms*6.6 ms

js_formatter[typescript_5583633924076080079.js]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

3.5 s*3.5 s

js_formatter[react.production.min_3378072959512366797.js]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

6.9 ms*7 ms

js_formatter[d3.min_16009850199655599998.js]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

434.9 ms*436.5 ms

jquery.min_16034160674129647344.js[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

27.9 ms*28 ms

tex-chtml-full_561698452596513081.js[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

-1%

270.9 ms*272.6 ms

dojo_11880045762646467684.js[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

-1%

7.7 ms*7.8 ms

checker_6456328407951392140.ts[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

-1%

242.9 ms*245.8 ms

js_formatter[jquery.min_16034160674129647344.js]

crates/biome_js_formatter/benches/js_formatter.rs::js_formatter::bench_js_formatter

-1%

114 ms*115.4 ms

checker_6456328407951392140.ts[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

-1%

265.3 ms*268.8 ms

react.production.min_3378072959512366797.js[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

-3%

2 ms*2.1 ms

Ignored

router_17129688031671448157.ts[uncached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

Ignored

-5%

2.3 ms*2.4 ms

router_17129688031671448157.ts[cached]

crates/biome_js_parser/benches/js_parser.rs::js_parser::bench_parser::js_parser

Ignored

+3%

2 ms*2 ms

Commits

Click on a commit to change the comparison range

Base

main

0c8349e

+0.15%

fix(noImportCycles): prevent flagging on single file import cycling fixes #6569

88380cb

5 months ago

by emilyinure

+0.02%

Satisfy clippy linting for single import cycles

201f62a

5 months ago

by emilyinure

-0.25%

More detailed changeset for single file import chains Co-authored-by: Arend van Beelen jr. <arend@arendjr.nl>

4c1385a

5 months ago

by emilyinure

+0.07%

[autofix.ci] apply automated fixes

1fbea3c

21 hours ago

by autofix-ci[bot]

+0.32%

Update naming in noImportCycles doc

0f4e413

20 hours ago

by emilyinure

-0.15%

Update wording in noImportCycles docs and changeset to be clearer

00ed23d

8 hours ago

by emilyinure

Home Terms Privacy Docs