Fix bug where tree_mask would get incorrectly set in certain cases
#103Comparing
mediocregopher:reth-issue-12129-invalid-trie-masks
(530b2e0
) withmain
(816689b
)0%
- Improvements
- 0
- Regressions
- 0
- Untouched
- 4
- New
- 0
- Dropped
- 0
- Ignored
- 0
Benchmarks
Passed
trie[16]
benches/bench.rs::benches::nibbles_path_encoding::encode_path_leaf::trie[16]0%
418.1 ns
418.1 ns
trie[32]
benches/bench.rs::benches::nibbles_path_encoding::encode_path_leaf::trie[32]0%
438.1 ns
438.1 ns
trie[64]
benches/bench.rs::benches::nibbles_path_encoding::encode_path_leaf::trie[64]0%
478.1 ns
478.1 ns
trie[8]
benches/bench.rs::benches::nibbles_path_encoding::encode_path_leaf::trie[8]0%
408.1 ns
408.1 ns
Commits
Click on a commit to change the comparison rangeBase
main
816689b
+1%
Fix bug where tree_mask would get incorrectly set in certain cases
As reported in:
https://github.com/paradigmxyz/reth/pull/12080
https://github.com/paradigmxyz/reth/issues/12129
the tree_mask would sometimes get a bit set on it even though the
corresponding child wouldn't appear in the set of updated branch nodes.
This was due to the bit getting incorrectly set for extension nodes
which pointed to updated branch nodes. The solution is a bit of a hack.
216b0f6
3 months ago
by mediocregopher0%
Use alloc instead of std in updated branch tests
a8c5898
3 months ago
by mediocregopher-1%
Set hash_mask bit for extension nodes so they get hashed
530b2e0
2 months ago
by mediocregopher