MaelPic:bugfix-ipv6-parsing - Branch - aio-libs/yarl

:bug: Raises meaningful exception when IPv6 URL is malformed

#1512

Comparing

MaelPic:bugfix-ipv6-parsing

(

63ba8c5

) with

master

(

07d0ba3

)

Improvements: 0

Regressions: 0

Untouched: 101

New: 0

Dropped: 0

Ignored: 0

Benchmarks

Passed

test_url_build_access_raw_path

tests/test_url_benchmarks.py::test_url_build_access_raw_path

+1%

597.8 µs

592.4 µs

test_update_query_none

tests/test_url_benchmarks.py::test_update_query_none

+1%

79.5 µs

78.9 µs

test_url_build_access_fragment

tests/test_url_benchmarks.py::test_url_build_access_fragment

+1%

472 µs

469.2 µs

test_url_build_with_different_hosts

tests/test_url_benchmarks.py::test_url_build_with_different_hosts

993.1 µs

989 µs

test_url_extend_query_existing_query_string

tests/test_url_benchmarks.py::test_url_extend_query_existing_query_string

152.3 µs

151.6 µs

test_update_query_empty

tests/test_url_benchmarks.py::test_update_query_empty

83.2 µs

82.9 µs

test_url_with_path_parent

tests/test_url_benchmarks.py::test_url_with_path_parent

303.4 µs

302.5 µs

test_url_host_port_subcomponent

tests/test_url_benchmarks.py::test_url_host_port_subcomponent

448.2 µs

447 µs

test_url_with_path_to_string

tests/test_url_benchmarks.py::test_url_with_path_to_string

215.2 µs

214.6 µs

test_url_origin_with_user_pass

tests/test_url_benchmarks.py::test_url_origin_with_user_pass

78.8 µs

78.7 µs

test_url_joinpath_with_truediv

tests/test_url_benchmarks.py::test_url_joinpath_with_truediv

695.9 µs

694.5 µs

test_url_build_with_host

tests/test_url_benchmarks.py::test_url_build_with_host

390.6 µs

389.9 µs

test_url_build_with_host_path_and_port

tests/test_url_benchmarks.py::test_url_build_with_host_path_and_port

518.8 µs

517.8 µs

test_url_build_no_netloc_relative

tests/test_url_benchmarks.py::test_url_build_no_netloc_relative

419.9 µs

419.2 µs

test_with_query_mapping_int_values

tests/test_url_benchmarks.py::test_with_query_mapping_int_values

1,000.9 µs

999.5 µs

test_empty_path_uncached

tests/test_url_benchmarks.py::test_empty_path_uncached

86.9 µs

86.8 µs

test_url_with_path_origin

tests/test_url_benchmarks.py::test_url_with_path_origin

79.2 µs

79.1 µs

test_url_make_encoded_with_host_path_and_port

tests/test_url_benchmarks.py::test_url_make_encoded_with_host_path_and_port

185.2 µs

185 µs

test_with_query_mapping

tests/test_url_benchmarks.py::test_with_query_mapping

674.8 µs

674.1 µs

test_url_make_with_many_hosts

tests/test_url_benchmarks.py::test_url_make_with_many_hosts

3.2 ms

test_with_query_empty

tests/test_url_benchmarks.py::test_with_query_empty

99.9 µs

99.8 µs

test_url_make_with_host_and_path

tests/test_url_benchmarks.py::test_url_make_with_host_and_path

134.1 µs

134 µs

test_url_with_name

tests/test_url_benchmarks.py::test_url_with_name

436.8 µs

436.5 µs

test_unquoter_long_ascii

tests/test_quoting_benchmarks.py::test_unquoter_long_ascii

12.1 ms

test_unquoter_long_pct

tests/test_quoting_benchmarks.py::test_unquoter_long_pct

15 ms

test_empty_query_string

tests/test_url_benchmarks.py::test_empty_query_string

47.1 µs

test_url_make_with_ipv4_address_path_and_port

tests/test_url_benchmarks.py::test_url_make_with_ipv4_address_path_and_port

135.4 µs

135.3 µs

test_url_make_no_netloc

tests/test_url_benchmarks.py::test_url_make_no_netloc

134.3 µs

test_url_to_string

tests/test_url_benchmarks.py::test_url_to_string

200 µs

199.9 µs

test_url_make_empty_username

tests/test_url_benchmarks.py::test_url_make_empty_username

135.4 µs

test_url_hash

tests/test_url_benchmarks.py::test_url_hash

182.6 µs

182.5 µs

test_empty_raw_path_qs_uncached

tests/test_url_benchmarks.py::test_empty_raw_path_qs_uncached

92.4 µs

test_url_make_empty_password

tests/test_url_benchmarks.py::test_url_make_empty_password

134.7 µs

test_path_safe_uncached

tests/test_url_benchmarks.py::test_path_safe_uncached

231 µs

test_url_make_with_host_path_and_port

tests/test_url_benchmarks.py::test_url_make_with_host_path_and_port

134.1 µs

test_url_joinpath

tests/test_url_benchmarks.py::test_url_joinpath

572.7 µs

572.6 µs

test_url_make_no_netloc_relative

tests/test_url_benchmarks.py::test_url_make_no_netloc_relative

134 µs

test_url_extend_query_existing_query_simple_query_dict

tests/test_url_benchmarks.py::test_url_extend_query_existing_query_simple_query_dict

699 µs

698.9 µs

test_url_equality

tests/test_url_benchmarks.py::test_url_equality

303.5 µs

test_url_with_fragment

tests/test_url_benchmarks.py::test_url_with_fragment

236.6 µs

test_path_safe

tests/test_url_benchmarks.py::test_path_safe

53.9 µs

test_human_repr

tests/test_url_benchmarks.py::test_human_repr

10.3 ms

test_with_query_sequence_mapping

tests/test_url_benchmarks.py::test_with_query_sequence_mapping

4.3 ms

test_url_build_access_raw_host

tests/test_url_benchmarks.py::test_url_build_access_raw_host

594.1 µs

test_long_query_with_pct

tests/test_quoting_benchmarks.py::test_long_query_with_pct

17.9 ms

test_long_query

tests/test_quoting_benchmarks.py::test_long_query

5.9 ms

test_url_origin

tests/test_url_benchmarks.py::test_url_origin

77.2 µs

test_is_default_port

tests/test_url_benchmarks.py::test_is_default_port

166.2 µs

test_raw_path_qs_uncached

tests/test_url_benchmarks.py::test_raw_path_qs_uncached

90 µs

test_url_with_path_relative

tests/test_url_benchmarks.py::test_url_with_path_relative

118.6 µs

test_quote_long_path

tests/test_quoting_benchmarks.py::test_quote_long_path

4.8 ms

test_quoter_pct

tests/test_quoting_benchmarks.py::test_quoter_pct

245.6 µs

test_url_make_with_ipv4_address_and_path

tests/test_url_benchmarks.py::test_url_make_with_ipv4_address_and_path

134 µs

test_url_with_user

tests/test_url_benchmarks.py::test_url_with_user

350.4 µs

350.5 µs

test_parse_query_uncached[long]

tests/test_url_benchmarks.py::test_parse_query_uncached[long]

21 ms

test_raw_path_qs_with_query_uncached

tests/test_url_benchmarks.py::test_raw_path_qs_with_query_uncached

118.3 µs

test_unquoter_short

tests/test_quoting_benchmarks.py::test_unquoter_short

204 µs

204.1 µs

test_url_build_encoded_with_host_and_port

tests/test_url_benchmarks.py::test_url_build_encoded_with_host_and_port

259.7 µs

259.8 µs

test_url_build_with_host_and_port

tests/test_url_benchmarks.py::test_url_build_with_host_and_port

644.1 µs

644.3 µs

test_quoter_ascii

tests/test_quoting_benchmarks.py::test_quoter_ascii

124.1 µs

124.2 µs

test_raw_path_qs

tests/test_url_benchmarks.py::test_raw_path_qs

53.3 µs

test_url_with_port

tests/test_url_benchmarks.py::test_url_with_port

305.2 µs

305.4 µs

test_empty_path

tests/test_url_benchmarks.py::test_empty_path

51.5 µs

test_empty_path_safe

tests/test_url_benchmarks.py::test_empty_path_safe

52.9 µs

test_url_with_query_to_string

tests/test_url_benchmarks.py::test_url_with_query_to_string

250.9 µs

251.1 µs

test_update_query_sequence_mapping

tests/test_url_benchmarks.py::test_update_query_sequence_mapping

4.5 ms

test_raw_path_qs_with_query

tests/test_url_benchmarks.py::test_raw_path_qs_with_query

53.2 µs

test_url_make_with_many_ipv4_hosts

tests/test_url_benchmarks.py::test_url_make_with_many_ipv4_hosts

3.2 ms

test_url_make_access_raw_path

tests/test_url_benchmarks.py::test_url_make_access_raw_path

162.5 µs

162.6 µs

test_quoter_quote_utf8

tests/test_quoting_benchmarks.py::test_quoter_quote_utf8

684.6 µs

685.1 µs

test_url_with_password

tests/test_url_benchmarks.py::test_url_with_password

374.6 µs

374.8 µs

test_url_build_with_simple_query

tests/test_url_benchmarks.py::test_url_build_with_simple_query

2.8 ms

test_url_join

tests/test_url_benchmarks.py::test_url_join

192.2 µs

192.4 µs

test_url_extend_query_simple_query_dict

tests/test_url_benchmarks.py::test_url_extend_query_simple_query_dict

677.1 µs

677.7 µs

test_url_make_access_fragment

tests/test_url_benchmarks.py::test_url_make_access_fragment

165.3 µs

165.5 µs

test_url_with_scheme

tests/test_url_benchmarks.py::test_url_with_scheme

161.7 µs

161.9 µs

test_url_make_with_ipv6_address_and_path

tests/test_url_benchmarks.py::test_url_make_with_ipv6_address_and_path

133.9 µs

134 µs

test_url_joinpath_encoded

tests/test_url_benchmarks.py::test_url_joinpath_encoded

490.3 µs

490.9 µs

test_url_make_with_ipv6_address_path_and_port

tests/test_url_benchmarks.py::test_url_make_with_ipv6_address_path_and_port

133.9 µs

134.1 µs

test_update_query_mapping

tests/test_url_benchmarks.py::test_update_query_mapping

943.7 µs

944.9 µs

test_update_query_string

tests/test_url_benchmarks.py::test_update_query_string

611.8 µs

612.6 µs

test_empty_query_string_uncached

tests/test_url_benchmarks.py::test_empty_query_string_uncached

78 µs

78.1 µs

test_extend_query_subclassed_str

tests/test_url_benchmarks.py::test_extend_query_subclassed_str

1 ms

test_update_query_mapping_with_existing_query

tests/test_url_benchmarks.py::test_update_query_mapping_with_existing_query

1.3 ms

test_empty_query

tests/test_url_benchmarks.py::test_empty_query

46.7 µs

46.8 µs

test_query_string

tests/test_url_benchmarks.py::test_query_string

47.4 µs

47.5 µs

test_query

tests/test_url_benchmarks.py::test_query

46.7 µs

46.8 µs

test_url_joinpath_encoded_long

tests/test_url_benchmarks.py::test_url_joinpath_encoded_long

861.4 µs

863 µs

test_url_make_with_many_ipv6_hosts

tests/test_url_benchmarks.py::test_url_make_with_many_ipv6_hosts

4.2 ms

test_empty_path_safe_uncached

tests/test_url_benchmarks.py::test_empty_path_safe_uncached

86.8 µs

87 µs

test_url_build_no_netloc

tests/test_url_benchmarks.py::test_url_build_no_netloc

430.9 µs

431.9 µs

test_url_build_access_username_password

tests/test_url_benchmarks.py::test_url_build_access_username_password

672.1 µs

673.9 µs

test_with_query_none

tests/test_url_benchmarks.py::test_with_query_none

95.7 µs

96 µs

test_raw_host_empty_cache

tests/test_url_benchmarks.py::test_raw_host_empty_cache

232.1 µs

232.8 µs

test_quote_query_string

tests/test_quoting_benchmarks.py::test_quote_query_string

313.3 µs

314.4 µs

test_url_with_path

tests/test_url_benchmarks.py::test_url_with_path

247.5 µs

248.3 µs

test_url_make_access_raw_host

tests/test_url_benchmarks.py::test_url_make_access_raw_host

163.5 µs

164.1 µs

test_url_with_host

tests/test_url_benchmarks.py::test_url_with_host

357.9 µs

359.3 µs

test_url_make_access_username_password

tests/test_url_benchmarks.py::test_url_make_access_username_password

188.3 µs

189.2 µs

test_empty_raw_path_qs

tests/test_url_benchmarks.py::test_empty_raw_path_qs

-4%

52.2 µs

54.2 µs

test_parse_query_uncached[short]

tests/test_url_benchmarks.py::test_parse_query_uncached[short]

-6%

1.7 ms

1.8 ms

Commits

Click on a commit to change the comparison range

Base

master

07d0ba3

:bug: Raise `ValueError` exception when IPv6 URL is empty or brackets reversed Problem: If brackets are reversed or content inside brackets is empty, `bracketed_host` will be an empty string. In consequence, reaching the first element of `bracketed_host` returns an `IndexError`. Solution: Use `startswith` because it does not raise anything if the string is empty and then it fallbacks into the following check verifying the presence of `:`. Also, the raised message was made more generic but still keeps its meaning.

63ba8c5

11 days ago

by MaelPic

Home Terms Privacy Docs