BobTheBuidler:patch-6 - Branch - aio-libs/async-lru

fix: callback inappropriately suppresses asyncio logs

#725

Comparing

BobTheBuidler:patch-6

(

8878460

) with

master

(

442ca3e

)

Untouched: 63

Skipped: 4

No successful run was found on master ( 9ab48ab) during the generation of this report, so 442ca3e was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Benchmarks

Skipped (4)

Passed

test_cache_ttl_expiry_benchmark[func-bounded-ttl]

benchmark.py

+1%

135 µs133.2 µs

test_internal_task_done_callback_microbenchmark[finished-func-bounded]

benchmark.py

+1%

1.8 ms1.8 ms

test_concurrent_cache_hit_benchmark[meth-unbounded-ttl]

benchmark.py

+1%

10.9 ms10.8 ms

test_cache_ttl_expiry_benchmark[func-unbounded-ttl]

benchmark.py

+1%

134.5 µs133.1 µs

test_cache_clear_benchmark[func-bounded-ttl]

benchmark.py

+1%

20.7 µs20.5 µs

test_cache_clear_benchmark[meth-bounded-ttl]

benchmark.py

+1%

21.8 µs21.6 µs

test_concurrent_cache_hit_benchmark[func-unbounded-ttl]

benchmark.py

+1%

10.1 ms10 ms

test_internal_task_done_callback_microbenchmark[finished-func-unbounded]

benchmark.py

+1%

1.8 ms1.8 ms

test_cache_clear_benchmark[func-bounded]

benchmark.py

+1%

20.6 µs20.5 µs

test_cache_clear_benchmark[meth-unbounded]

benchmark.py

+1%

21.7 µs21.6 µs

test_cache_clear_benchmark[func-unbounded]

benchmark.py

+1%

22.1 µs22 µs

test_cache_invalidate_benchmark[meth-bounded]

benchmark.py

+1%

1.1 ms1.1 ms

test_cache_miss_benchmark[func-unbounded]

benchmark.py

+1%

1.1 ms1.1 ms

test_internal_task_done_callback_microbenchmark[exception-func-unbounded]

benchmark.py

+1%

1.7 ms1.7 ms

test_cache_ttl_expiry_benchmark[meth-bounded-ttl]

benchmark.py

146.8 µs146.1 µs

test_internal_task_done_callback_microbenchmark[exception-func-bounded]

benchmark.py

1.7 ms1.7 ms

test_cache_ttl_expiry_benchmark[meth-unbounded-ttl]

benchmark.py

149.2 µs148.5 µs

test_cache_invalidate_benchmark[meth-bounded-ttl]

benchmark.py

1.1 ms1.1 ms

test_cache_invalidate_benchmark[meth-unbounded-ttl]

benchmark.py

1.1 ms1.1 ms

test_cache_miss_benchmark[meth-unbounded]

benchmark.py

1.4 ms1.4 ms

test_cache_clear_benchmark[meth-bounded]

benchmark.py

21.7 µs21.6 µs

test_cache_miss_benchmark[func-bounded]

benchmark.py

1.1 ms1.1 ms

test_cache_info_benchmark[func-bounded]

benchmark.py

2 ms2 ms

test_cache_info_benchmark[func-unbounded]

benchmark.py

2 ms2 ms

test_cache_info_benchmark[func-bounded-ttl]

benchmark.py

2 ms2 ms

test_cache_info_benchmark[func-unbounded-ttl]

benchmark.py

2 ms2 ms

test_internal_cache_hit_microbenchmark[func-unbounded]

benchmark.py

152.3 µs152 µs

test_cache_info_benchmark[meth-bounded]

benchmark.py

2.3 ms2.3 ms

test_cache_info_benchmark[meth-unbounded]

benchmark.py

2.3 ms2.3 ms

test_cache_info_benchmark[meth-bounded-ttl]

benchmark.py

2.3 ms2.3 ms

test_cache_info_benchmark[meth-unbounded-ttl]

benchmark.py

2.3 ms2.3 ms

test_cache_invalidate_benchmark[meth-unbounded]

benchmark.py

1.1 ms1.1 ms

test_cache_hit_benchmark[meth-bounded]

benchmark.py

9.9 ms9.9 ms

test_internal_cache_hit_microbenchmark[func-bounded]

benchmark.py

152.7 µs152.5 µs

test_internal_cache_miss_microbenchmark[func-unbounded]

benchmark.py

108.2 µs108.1 µs

test_cache_hit_benchmark[meth-bounded-ttl]

benchmark.py

86.9 ms86.8 ms

test_cache_miss_benchmark[meth-bounded-ttl]

benchmark.py

11.4 ms11.4 ms

test_cache_miss_benchmark[meth-unbounded-ttl]

benchmark.py

11.5 ms11.5 ms

test_concurrent_cache_hit_benchmark[func-bounded-ttl]

benchmark.py

8.4 ms8.4 ms

test_cache_hit_benchmark[func-bounded-ttl]

benchmark.py

81.1 ms81 ms

test_cache_miss_benchmark[func-unbounded-ttl]

benchmark.py

11.1 ms11.1 ms

test_cache_miss_benchmark[meth-bounded]

benchmark.py

1.4 ms1.4 ms

test_cache_hit_benchmark[meth-unbounded-ttl]

benchmark.py

86.9 ms86.8 ms

test_cache_fill_eviction_benchmark

benchmark.py

336.6 ms336.4 ms

test_internal_task_done_callback_microbenchmark[cancelled-func-unbounded]

benchmark.py

1.6 ms1.6 ms

test_internal_task_done_callback_microbenchmark[cancelled-func-bounded]

benchmark.py

1.6 ms1.6 ms

test_cache_invalidate_benchmark[func-unbounded]

benchmark.py

382.3 µs382.3 µs

test_internal_cache_miss_microbenchmark[func-bounded]

benchmark.py

108.9 µs108.9 µs

test_cache_invalidate_benchmark[func-unbounded-ttl]

benchmark.py

382.2 µs382.2 µs

test_cache_clear_benchmark[meth-unbounded-ttl]

benchmark.py

21.9 µs21.9 µs

test_cache_hit_benchmark[func-unbounded-ttl]

benchmark.py

81 ms81 ms

test_concurrent_cache_hit_benchmark[func-unbounded]

benchmark.py

2.7 ms2.7 ms

test_cache_miss_benchmark[func-bounded-ttl]

benchmark.py

11 ms11 ms

test_cache_invalidate_benchmark[func-bounded]

benchmark.py

383.2 µs383.3 µs

test_concurrent_cache_hit_benchmark[meth-bounded-ttl]

benchmark.py

9.1 ms9.1 ms

test_cache_hit_benchmark[func-unbounded]

benchmark.py

4.9 ms4.9 ms

test_concurrent_cache_hit_benchmark[meth-bounded]

benchmark.py

3.2 ms3.2 ms

test_concurrent_cache_hit_benchmark[func-bounded]

benchmark.py

2.7 ms2.7 ms

test_cache_invalidate_benchmark[func-bounded-ttl]

benchmark.py

382 µs382.2 µs

test_cache_hit_benchmark[meth-unbounded]

benchmark.py

9.9 ms9.9 ms

test_concurrent_cache_hit_benchmark[meth-unbounded]

benchmark.py

3.2 ms3.2 ms

test_cache_hit_benchmark[func-bounded]

benchmark.py

4.9 ms4.9 ms

test_cache_clear_benchmark[func-unbounded-ttl]

benchmark.py

20.6 µs20.7 µs

Commits

Click on a commit to change the comparison range

Base

master

442ca3e

+0.28%

fix: callback inappropriately suppresses asyncio logs We must use the private `_exception` attribute instead of `exception()` so asyncio does not set `task.__log_traceback = False` on the false assumption that the caller read the task Exception

8878460

2 days ago

by BobTheBuidler

Home Terms Privacy Docs