mixelburg:fix/renderRouterToStream-onShellError - Branch - TanStack/router

fix(react-router): use onShellError to destroy stream on unrecoverable SSR errors

#7083

Comparing

mixelburg:fix/renderRouterToStream-onShellError

(

70a6776

) with

main

(

796406d

)

Untouched: 6

No successful run was found on main ( 5a81726) during the generation of this report, so 796406d was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Benchmarks

6 total

client-side navigation loop (solid)

benchmarks/client-nav/solid/speed.bench.ts::client-nav

114 ms113.8 ms

client-side navigation loop (vue)

benchmarks/client-nav/vue/speed.bench.ts::client-nav

83.1 ms83 ms

client-side navigation loop (react)

benchmarks/client-nav/react/speed.bench.ts::client-nav

56.3 ms56.3 ms

ssr request loop (vue)

benchmarks/ssr/vue/speed.bench.ts::ssr

420.1 ms419.9 ms

ssr request loop (react)

benchmarks/ssr/react/speed.bench.ts::ssr

330.4 ms330.3 ms

ssr request loop (solid)

benchmarks/ssr/solid/speed.bench.ts::ssr

153.3 ms153.3 ms

Commits

Click on a commit to change the comparison range

Base

main

796406d

+0.08%

fix(react-router): use onShellError instead of onError to destroy stream on unrecoverable SSR errors

70a6776

7 days ago

by mixelburg

Home Terms Privacy Docs