unsendable-threadsafe-traverse - Branch - PyO3/pyo3

Blog Docs

Turn calls of traverse into no-ops for unsendable pyclass if on the wrong thread(#3689)

Merged

Merging

unsendable-threadsafe-traverse

into

main

IMPROVEMENTS: 0

REGRESSIONS: 0

UNTOUCHED: 65

NEW: 0

DROPPED: 0

IGNORED: 13

Benchmarks

Passing

collect_generic_iterator

pyo3-benches/benches/bench_any.rs::benches::criterion_benchmark::collect_generic_iterator

333.9 ms

identify_object_type

pyo3-benches/benches/bench_any.rs::benches::criterion_benchmark::identify_object_type

26.5 µs

26.6 µs

extract_bigint_big_negative

pyo3-benches/benches/bench_bigint.rs::benches::criterion_benchmark::extract_bigint_big_negative

8.7 µs

8.8 µs

extract_bigint_big_positive

pyo3-benches/benches/bench_bigint.rs::benches::criterion_benchmark::extract_bigint_big_positive

7.9 µs

extract_bigint_extract_fail

pyo3-benches/benches/bench_bigint.rs::benches::criterion_benchmark::extract_bigint_extract_fail

17.4 µs

extract_bigint_huge_negative

pyo3-benches/benches/bench_bigint.rs::benches::criterion_benchmark::extract_bigint_huge_negative

49.8 µs

49.9 µs

extract_bigint_huge_positive

pyo3-benches/benches/bench_bigint.rs::benches::criterion_benchmark::extract_bigint_huge_positive

43.6 µs

extract_bigint_small

pyo3-benches/benches/bench_bigint.rs::benches::criterion_benchmark::extract_bigint_small

-1%

4.3 µs

call_0

pyo3-benches/benches/bench_call.rs::benches::criterion_benchmark::call_0

1.3 ms

call_method_0

pyo3-benches/benches/bench_call.rs::benches::criterion_benchmark::call_method_0

3.7 ms

ordered_dunder_methods

pyo3-benches/benches/bench_comparisons.rs::benches::criterion_benchmark::ordered_dunder_methods

-1%

4.1 µs

ordered_richcmp

pyo3-benches/benches/bench_comparisons.rs::benches::criterion_benchmark::ordered_richcmp

-1%

4.1 µs

4.2 µs

decimal_via_extract

pyo3-benches/benches/bench_decimal.rs::benches::criterion_benchmark::decimal_via_extract

+2%

22.8 µs

22.5 µs

dict_get_item

pyo3-benches/benches/bench_dict.rs::benches::criterion_benchmark::dict_get_item

88.7 ms

dict_new

pyo3-benches/benches/bench_dict.rs::benches::criterion_benchmark::dict_new

128.9 ms

extract_btreemap

pyo3-benches/benches/bench_dict.rs::benches::criterion_benchmark::extract_btreemap

223.7 ms

extract_hashmap

pyo3-benches/benches/bench_dict.rs::benches::criterion_benchmark::extract_hashmap

112.2 ms

iter_dict

pyo3-benches/benches/bench_dict.rs::benches::criterion_benchmark::iter_dict

61.2 ms

err_new_restore_and_fetch

pyo3-benches/benches/bench_err.rs::benches::criterion_benchmark::err_new_restore_and_fetch

10.8 µs

err_new_without_gil

pyo3-benches/benches/bench_err.rs::benches::criterion_benchmark::err_new_without_gil

1.6 µs

extract_float_downcast_fail

pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark::extract_float_downcast_fail

+6%

510.6 ns

482.8 ns

extract_float_extract_fail

pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark::extract_float_extract_fail

17 µs

extract_int_downcast_success

pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark::extract_int_downcast_success

916.7 ns

extract_int_extract_fail

pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark::extract_int_extract_fail

17.4 µs

extract_str_extract_fail

pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark::extract_str_extract_fail

-2%

2.3 µs

enum_from_pyobject

pyo3-benches/benches/bench_frompyobject.rs::benches::criterion_benchmark::enum_from_pyobject

40.6 µs

f64_from_pyobject

pyo3-benches/benches/bench_frompyobject.rs::benches::criterion_benchmark::f64_from_pyobject

272.2 ns

not_a_list_via_extract

pyo3-benches/benches/bench_frompyobject.rs::benches::criterion_benchmark::not_a_list_via_extract

2.2 µs

not_a_list_via_extract_enum

pyo3-benches/benches/bench_frompyobject.rs::benches::criterion_benchmark::not_a_list_via_extract_enum

25 µs

clean_acquire_gil

pyo3-benches/benches/bench_gil.rs::benches::criterion_benchmark::clean_acquire_gil

5 µs

clean_gilpool_new

pyo3-benches/benches/bench_gil.rs::benches::criterion_benchmark::clean_gilpool_new

705 ns

dirty_acquire_gil

pyo3-benches/benches/bench_gil.rs::benches::criterion_benchmark::dirty_acquire_gil

6.3 µs

getattr_intern

pyo3-benches/benches/bench_intern.rs::benches::criterion_benchmark::getattr_intern

+1%

3.9 µs

iter_list

pyo3-benches/benches/bench_list.rs::benches::criterion_benchmark::iter_list

39.1 ms

list_get_item

pyo3-benches/benches/bench_list.rs::benches::criterion_benchmark::list_get_item

22.5 ms

list_get_item_unchecked

pyo3-benches/benches/bench_list.rs::benches::criterion_benchmark::list_get_item_unchecked

19.5 ms

list_new

pyo3-benches/benches/bench_list.rs::benches::criterion_benchmark::list_new

33.6 ms

first_time_init

pyo3-benches/benches/bench_pyclass.rs::benches::criterion_benchmark::first_time_init

73.1 µs

72.9 µs

drop_many_objects

pyo3-benches/benches/bench_pyobject.rs::benches::criterion_benchmark::drop_many_objects

55.3 µs

extract_btreeset

pyo3-benches/benches/bench_set.rs::benches::criterion_benchmark::extract_btreeset

97.4 ms

extract_hashset

pyo3-benches/benches/bench_set.rs::benches::criterion_benchmark::extract_hashset

108.6 ms

iter_set

pyo3-benches/benches/bench_set.rs::benches::criterion_benchmark::iter_set

58.7 ms

set_new

pyo3-benches/benches/bench_set.rs::benches::criterion_benchmark::set_new

71.4 ms

iter_tuple

pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark::iter_tuple

27.8 ms

sequence_from_tuple

pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark::sequence_from_tuple

278.9 ns

tuple_get_item

pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark::tuple_get_item

18.7 ms

tuple_get_item_unchecked

pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark::tuple_get_item_unchecked

15.5 ms

tuple_into_py

pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark::tuple_into_py

4.7 µs

tuple_new

pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark::tuple_new

33.4 ms

tuple_new_list

pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark::tuple_new_list

7.1 ms

tuple_to_list

pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark::tuple_to_list

3.6 ms

test_empty_class_init

pytests/tests/test_pyclasses.py::test_empty_class_init

+2%

32.8 µs

32.2 µs

test_empty_class_init_py

pytests/tests/test_pyclasses.py::test_empty_class_init_py

23.2 µs

23.1 µs

test_args_kwargs_py

pytests/tests/test_pyfunctions.py::test_args_kwargs_py

-1%

33 µs

33.4 µs

test_args_kwargs_rs

pytests/tests/test_pyfunctions.py::test_args_kwargs_rs

22.7 µs

test_none_py

pytests/tests/test_pyfunctions.py::test_none_py

17.6 µs

test_none_rs

pytests/tests/test_pyfunctions.py::test_none_rs

17.2 µs

test_simple_args_kwargs_py

pytests/tests/test_pyfunctions.py::test_simple_args_kwargs_py

34.6 µs

34.7 µs

test_simple_args_kwargs_rs

pytests/tests/test_pyfunctions.py::test_simple_args_kwargs_rs

37 µs

37.1 µs

test_simple_args_py

pytests/tests/test_pyfunctions.py::test_simple_args_py

27.8 µs

27.9 µs

test_simple_args_rs

pytests/tests/test_pyfunctions.py::test_simple_args_rs

-1%

32.6 µs

32.9 µs

test_simple_kwargs_py

pytests/tests/test_pyfunctions.py::test_simple_kwargs_py

35.9 µs

35.8 µs

test_simple_kwargs_rs

pytests/tests/test_pyfunctions.py::test_simple_kwargs_rs

35.3 µs

35.4 µs

test_simple_py

pytests/tests/test_pyfunctions.py::test_simple_py

27.4 µs

test_simple_rs

pytests/tests/test_pyfunctions.py::test_simple_rs

27.6 µs

Ignored

mapping_from_dictIgnored

pyo3-benches/benches/bench_dict.rs::benches::criterion_benchmark::mapping_from_dict

360.6 ns

extract_float_downcast_successIgnored

pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark::extract_float_downcast_success

488.9 ns

extract_float_extract_successIgnored

pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark::extract_float_extract_success

305 ns

extract_int_downcast_failIgnored

pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark::extract_int_downcast_fail

266.1 ns

extract_int_extract_successIgnored

pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark::extract_int_extract_success

790 ns

extract_str_downcast_failIgnored

pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark::extract_str_downcast_fail

266.1 ns

extract_str_downcast_successIgnored

pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark::extract_str_downcast_success

661.7 ns

extract_str_extract_successIgnored

pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark::extract_str_extract_success

+5%

541.7 ns

513.9 ns

list_via_downcastIgnored

pyo3-benches/benches/bench_frompyobject.rs::benches::criterion_benchmark::list_via_downcast

126.1 ns

list_via_extractIgnored

pyo3-benches/benches/bench_frompyobject.rs::benches::criterion_benchmark::list_via_extract

153.9 ns

not_a_list_via_downcastIgnored

pyo3-benches/benches/bench_frompyobject.rs::benches::criterion_benchmark::not_a_list_via_downcast

126.1 ns

getattr_directIgnored

pyo3-benches/benches/bench_intern.rs::benches::criterion_benchmark::getattr_direct

+1%

9.1 µs

9 µs

sequence_from_listIgnored

pyo3-benches/benches/bench_list.rs::benches::criterion_benchmark::sequence_from_list

306.7 ns

Commits

Click on a commit to change the comparison range

base

main

65f25d4

Turn calls of __traverse__ into no-ops for unsendable pyclass if on the wrong thread Adds a "threadsafe" variant of `PyCell::try_borrow` which will fail instead of panicking if called on the wrong thread and use it in `call_traverse` to turn GC traversals of unsendable pyclasses into no-ops if on the wrong thread. This can imply leaking the underlying resource if the originator thread has already exited so that the GC will never run there again, but it does avoid hard aborts as we cannot raise an exception from within `call_traverse`.

4dc6c16

5 months ago by adamreichold

ResourcesHome Pricing Docs Blog GitHub

Getting StartedSample repository Explore repositories Support

AboutTwitter Discord Contact Us Terms of Service Privacy Policy