Avatar for the PyO3 user
PyO3
pyo3
BlogDocsChangelog

fix(pymodule): improve safety of PyModule::from_code

#4777
Comparing
sxlijin:sam/pymodule-from-code-defaults
(
f1b00cc
) with
main
(
5aa2a9b
)
CodSpeed Performance Gauge
0%
Improvements
0
Regressions
0
Untouched
83
New
0
Dropped
0
Ignored
17

Benchmarks

Passed

extract_bigint_small
pyo3-benches/benches/bench_bigint.rs::benches::criterion_benchmark::extract_bigint_small
CodSpeed Performance Gauge
+6%
3 µs
2.8 µs
err_new_without_gil
pyo3-benches/benches/bench_err.rs::benches::criterion_benchmark::err_new_without_gil
CodSpeed Performance Gauge
+4%
1.4 µs
1.3 µs
extract_bigint_big_negative
pyo3-benches/benches/bench_bigint.rs::benches::criterion_benchmark::extract_bigint_big_negative
CodSpeed Performance Gauge
+3%
4 µs
3.9 µs
test_simple_kwargs_rs
pytests/tests/test_pyfunctions.py::test_simple_kwargs_rs
CodSpeed Performance Gauge
+3%
19.1 µs
18.5 µs
extract_str_extract_fail
pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark::extract_str_extract_fail
CodSpeed Performance Gauge
+3%
2.1 µs
2 µs
extract_bigint_big_positive
pyo3-benches/benches/bench_bigint.rs::benches::criterion_benchmark::extract_bigint_big_positive
CodSpeed Performance Gauge
+2%
3.7 µs
3.6 µs
extract_bigint_huge_positive
pyo3-benches/benches/bench_bigint.rs::benches::criterion_benchmark::extract_bigint_huge_positive
CodSpeed Performance Gauge
+2%
12 µs
11.8 µs
byte_slice_into_pyobject_medium
pyo3-benches/benches/bench_intopyobject.rs::benches::criterion_benchmark::byte_slice_into_pyobject_medium
CodSpeed Performance Gauge
+2%
1.7 µs
1.7 µs
extract_bigint_huge_negative
pyo3-benches/benches/bench_bigint.rs::benches::criterion_benchmark::extract_bigint_huge_negative
CodSpeed Performance Gauge
+1%
13.4 µs
13.2 µs
tuple_into_py
pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark::tuple_into_py
CodSpeed Performance Gauge
+1%
3 µs
2.9 µs
test_simple_args_py
pytests/tests/test_pyfunctions.py::test_simple_args_py
CodSpeed Performance Gauge
+1%
17.4 µs
17.3 µs
first_time_init
pyo3-benches/benches/bench_pyclass.rs::benches::criterion_benchmark::first_time_init
CodSpeed Performance Gauge
+1%
39.3 µs
39.1 µs
test_simple_py
pytests/tests/test_pyfunctions.py::test_simple_py
CodSpeed Performance Gauge
+1%
17.1 µs
17 µs
test_none_rs
pytests/tests/test_pyfunctions.py::test_none_rs
CodSpeed Performance Gauge
0%
12.1 µs
12.1 µs
test_method_call_py
pytests/tests/test_pyclasses.py::test_method_call_py
CodSpeed Performance Gauge
0%
13.4 µs
13.4 µs
test_args_kwargs_py
pytests/tests/test_pyfunctions.py::test_args_kwargs_py
CodSpeed Performance Gauge
0%
18.5 µs
18.5 µs
test_simple_rs
pytests/tests/test_pyfunctions.py::test_simple_rs
CodSpeed Performance Gauge
0%
18.4 µs
18.4 µs
drop_many_objects
pyo3-benches/benches/bench_pyobject.rs::benches::criterion_benchmark::drop_many_objects
CodSpeed Performance Gauge
0%
11.4 µs
11.3 µs
test_empty_class_init_py
pytests/tests/test_pyclasses.py::test_empty_class_init_py
CodSpeed Performance Gauge
0%
13.8 µs
13.7 µs
test_proto_call
pytests/tests/test_pyclasses.py::test_proto_call
CodSpeed Performance Gauge
0%
13.2 µs
13.2 µs
extract_hashbrown_set
pyo3-benches/benches/bench_set.rs::benches::criterion_benchmark::extract_hashbrown_set
CodSpeed Performance Gauge
0%
16 ms
16 ms
test_simple_args_kwargs_rs
pytests/tests/test_pyfunctions.py::test_simple_args_kwargs_rs
CodSpeed Performance Gauge
0%
19.2 µs
19.2 µs
call_0
pyo3-benches/benches/bench_call.rs::benches::criterion_benchmark::call_0
CodSpeed Performance Gauge
0%
196.6 µs
196.5 µs
extract_btreeset
pyo3-benches/benches/bench_set.rs::benches::criterion_benchmark::extract_btreeset
CodSpeed Performance Gauge
0%
15.6 ms
15.6 ms
call_method_1
pyo3-benches/benches/bench_call.rs::benches::criterion_benchmark::call_method_1
CodSpeed Performance Gauge
0%
1 ms
1 ms
extract_hashset
pyo3-benches/benches/bench_set.rs::benches::criterion_benchmark::extract_hashset
CodSpeed Performance Gauge
0%
20.5 ms
20.5 ms
tuple_get_borrowed_item_unchecked
pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark::tuple_get_borrowed_item_unchecked
CodSpeed Performance Gauge
0%
3.4 ms
3.4 ms
collect_generic_iterator
pyo3-benches/benches/bench_any.rs::benches::criterion_benchmark::collect_generic_iterator
CodSpeed Performance Gauge
0%
105.9 ms
105.9 ms
list_get_item_unchecked
pyo3-benches/benches/bench_list.rs::benches::criterion_benchmark::list_get_item_unchecked
CodSpeed Performance Gauge
0%
3.6 ms
3.6 ms
dict_new
pyo3-benches/benches/bench_dict.rs::benches::criterion_benchmark::dict_new
CodSpeed Performance Gauge
0%
25.6 ms
25.6 ms
iter_list
pyo3-benches/benches/bench_list.rs::benches::criterion_benchmark::iter_list
CodSpeed Performance Gauge
0%
6.7 ms
6.7 ms
tuple_get_item_unchecked
pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark::tuple_get_item_unchecked
CodSpeed Performance Gauge
0%
3.6 ms
3.6 ms
list_get_item
pyo3-benches/benches/bench_list.rs::benches::criterion_benchmark::list_get_item
CodSpeed Performance Gauge
0%
4.1 ms
4.1 ms
tuple_new
pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark::tuple_new
CodSpeed Performance Gauge
0%
7.1 ms
7.1 ms
tuple_get_item
pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark::tuple_get_item
CodSpeed Performance Gauge
0%
4.1 ms
4.1 ms
list_new
pyo3-benches/benches/bench_list.rs::benches::criterion_benchmark::list_new
CodSpeed Performance Gauge
0%
7.2 ms
7.2 ms
iter_dict
pyo3-benches/benches/bench_dict.rs::benches::criterion_benchmark::iter_dict
CodSpeed Performance Gauge
0%
11.4 ms
11.4 ms
tuple_to_list
pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark::tuple_to_list
CodSpeed Performance Gauge
0%
1.6 ms
1.6 ms
call_method_one_arg
pyo3-benches/benches/bench_call.rs::benches::criterion_benchmark::call_method_one_arg
CodSpeed Performance Gauge
0%
974.3 µs
974.3 µs
extract_float_downcast_fail
pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark::extract_float_downcast_fail
CodSpeed Performance Gauge
0%
396.7 ns
396.7 ns
extract_int_extract_fail
pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark::extract_int_extract_fail
CodSpeed Performance Gauge
0%
12.6 µs
12.6 µs
clean_acquire_gil
pyo3-benches/benches/bench_gil.rs::benches::criterion_benchmark::clean_acquire_gil
CodSpeed Performance Gauge
0%
3.3 µs
3.3 µs
dirty_acquire_gil
pyo3-benches/benches/bench_gil.rs::benches::criterion_benchmark::dirty_acquire_gil
CodSpeed Performance Gauge
0%
4.9 µs
4.9 µs
vec_into_pyobject
pyo3-benches/benches/bench_intopyobject.rs::benches::criterion_benchmark::vec_into_pyobject
CodSpeed Performance Gauge
0%
2.7 µs
2.7 µs
tuple_get_borrowed_item
pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark::tuple_get_borrowed_item
CodSpeed Performance Gauge
0%
3.9 ms
3.9 ms
set_new
pyo3-benches/benches/bench_set.rs::benches::criterion_benchmark::set_new
CodSpeed Performance Gauge
0%
15.1 ms
15.1 ms
dict_get_item
pyo3-benches/benches/bench_dict.rs::benches::criterion_benchmark::dict_get_item
CodSpeed Performance Gauge
0%
16.3 ms
16.3 ms
byte_slice_into_pyobject_large
pyo3-benches/benches/bench_intopyobject.rs::benches::criterion_benchmark::byte_slice_into_pyobject_large
CodSpeed Performance Gauge
0%
176.9 µs
176.9 µs
iter_set
pyo3-benches/benches/bench_set.rs::benches::criterion_benchmark::iter_set
CodSpeed Performance Gauge
0%
10.5 ms
10.5 ms
iter_tuple
pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark::iter_tuple
CodSpeed Performance Gauge
0%
5.9 ms
5.9 ms
call_method
pyo3-benches/benches/bench_call.rs::benches::criterion_benchmark::call_method
CodSpeed Performance Gauge
0%
1.4 ms
1.4 ms
call
pyo3-benches/benches/bench_call.rs::benches::criterion_benchmark::call
CodSpeed Performance Gauge
0%
756.4 µs
756.5 µs
tuple_new_list
pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark::tuple_new_list
CodSpeed Performance Gauge
0%
2.1 ms
2.1 ms
test_simple_args_kwargs_py
pytests/tests/test_pyfunctions.py::test_simple_args_kwargs_py
CodSpeed Performance Gauge
0%
20.1 µs
20.1 µs
test_method_call
pytests/tests/test_pyclasses.py::test_method_call
CodSpeed Performance Gauge
0%
14.2 µs
14.2 µs
call_method_0
pyo3-benches/benches/bench_call.rs::benches::criterion_benchmark::call_method_0
CodSpeed Performance Gauge
0%
591.7 µs
591.8 µs
extract_float_extract_fail
pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark::extract_float_extract_fail
CodSpeed Performance Gauge
0%
12.2 µs
12.2 µs
bytes_new_large
pyo3-benches/benches/bench_intopyobject.rs::benches::criterion_benchmark::bytes_new_large
CodSpeed Performance Gauge
0%
176.9 µs
176.9 µs
call_one_arg
pyo3-benches/benches/bench_call.rs::benches::criterion_benchmark::call_one_arg
CodSpeed Performance Gauge
0%
347.8 µs
347.9 µs
extract_hashmap
pyo3-benches/benches/bench_dict.rs::benches::criterion_benchmark::extract_hashmap
CodSpeed Performance Gauge
0%
20.7 ms
20.7 ms
call_1
pyo3-benches/benches/bench_call.rs::benches::criterion_benchmark::call_1
CodSpeed Performance Gauge
0%
380.3 µs
380.4 µs
extract_btreemap
pyo3-benches/benches/bench_dict.rs::benches::criterion_benchmark::extract_btreemap
CodSpeed Performance Gauge
0%
37.8 ms
37.8 ms
extract_hashbrown_map
pyo3-benches/benches/bench_dict.rs::benches::criterion_benchmark::extract_hashbrown_map
CodSpeed Performance Gauge
0%
17.9 ms
17.9 ms
test_empty_class_init
pytests/tests/test_pyclasses.py::test_empty_class_init
CodSpeed Performance Gauge
0%
21.4 µs
21.4 µs
decimal_via_extract
pyo3-benches/benches/bench_decimal.rs::benches::criterion_benchmark::decimal_via_extract
CodSpeed Performance Gauge
0%
15.2 µs
15.2 µs
test_proto_call_py
pytests/tests/test_pyclasses.py::test_proto_call_py
CodSpeed Performance Gauge
0%
13.8 µs
13.9 µs
test_args_kwargs_rs
pytests/tests/test_pyfunctions.py::test_args_kwargs_rs
CodSpeed Performance Gauge
0%
13.6 µs
13.7 µs
vec_into_py
pyo3-benches/benches/bench_intopyobject.rs::benches::criterion_benchmark::vec_into_py
CodSpeed Performance Gauge
0%
9.8 µs
9.8 µs
err_new_restore_and_fetch
pyo3-benches/benches/bench_err.rs::benches::criterion_benchmark::err_new_restore_and_fetch
CodSpeed Performance Gauge
0%
8.4 µs
8.4 µs
drop_many_objects_without_gil
pyo3-benches/benches/bench_pyobject.rs::benches::criterion_benchmark::drop_many_objects_without_gil
CodSpeed Performance Gauge
0%
40.5 µs
40.7 µs
test_simple_args_rs
pytests/tests/test_pyfunctions.py::test_simple_args_rs
CodSpeed Performance Gauge
0%
19.8 µs
19.9 µs
extract_bigint_extract_fail
pyo3-benches/benches/bench_bigint.rs::benches::criterion_benchmark::extract_bigint_extract_fail
CodSpeed Performance Gauge
0%
12.3 µs
12.3 µs
test_none_py
pytests/tests/test_pyfunctions.py::test_none_py
CodSpeed Performance Gauge
0%
12.1 µs
12.1 µs
not_a_list_via_extract_enum
pyo3-benches/benches/bench_frompyobject.rs::benches::criterion_benchmark::not_a_list_via_extract_enum
CodSpeed Performance Gauge
0%
18 µs
18.1 µs
test_simple_kwargs_py
pytests/tests/test_pyfunctions.py::test_simple_kwargs_py
CodSpeed Performance Gauge
-1%
19.8 µs
19.9 µs
enum_from_pyobject
pyo3-benches/benches/bench_frompyobject.rs::benches::criterion_benchmark::enum_from_pyobject
CodSpeed Performance Gauge
-1%
24.2 µs
24.4 µs
identify_object_type
pyo3-benches/benches/bench_any.rs::benches::criterion_benchmark::identify_object_type
CodSpeed Performance Gauge
-1%
14.8 µs
15 µs
byte_slice_into_py
pyo3-benches/benches/bench_intopyobject.rs::benches::criterion_benchmark::byte_slice_into_py
CodSpeed Performance Gauge
-2%
1.7 µs
1.7 µs
bytes_new_medium
pyo3-benches/benches/bench_intopyobject.rs::benches::criterion_benchmark::bytes_new_medium
CodSpeed Performance Gauge
-2%
1.7 µs
1.7 µs
ordered_dunder_methods
pyo3-benches/benches/bench_comparisons.rs::benches::criterion_benchmark::ordered_dunder_methods
CodSpeed Performance Gauge
-2%
3.1 µs
3.2 µs
getattr_intern
pyo3-benches/benches/bench_intern.rs::benches::criterion_benchmark::getattr_intern
CodSpeed Performance Gauge
-2%
3 µs
3.1 µs
ordered_richcmp
pyo3-benches/benches/bench_comparisons.rs::benches::criterion_benchmark::ordered_richcmp
CodSpeed Performance Gauge
-2%
3 µs
3 µs
not_a_list_via_extract
pyo3-benches/benches/bench_frompyobject.rs::benches::criterion_benchmark::not_a_list_via_extract
CodSpeed Performance Gauge
-3%
2 µs
2.1 µs

Ignored

mapping_from_dictIgnored
pyo3-benches/benches/bench_dict.rs::benches::criterion_benchmark::mapping_from_dict
CodSpeed Performance Gauge
0%
270.8 ns
270.8 ns
extract_float_downcast_successIgnored
pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark::extract_float_downcast_success
CodSpeed Performance Gauge
0%
149.2 ns
149.2 ns
extract_float_extract_successIgnored
pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark::extract_float_extract_success
CodSpeed Performance Gauge
-8%
334.4 ns
363.6 ns
extract_int_downcast_failIgnored
pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark::extract_int_downcast_fail
CodSpeed Performance Gauge
0%
396.9 ns
396.9 ns
extract_int_downcast_successIgnored
pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark::extract_int_downcast_success
CodSpeed Performance Gauge
+9%
675.6 ns
617.2 ns
extract_int_extract_successIgnored
pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark::extract_int_extract_success
CodSpeed Performance Gauge
+12%
552.8 ns
494.4 ns
extract_str_downcast_failIgnored
pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark::extract_str_downcast_fail
CodSpeed Performance Gauge
0%
396.7 ns
396.7 ns
extract_str_downcast_successIgnored
pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark::extract_str_downcast_success
CodSpeed Performance Gauge
+5%
584.4 ns
555.3 ns
extract_str_extract_successIgnored
pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark::extract_str_extract_success
CodSpeed Performance Gauge
-5%
609.7 ns
638.9 ns
list_via_downcastIgnored
pyo3-benches/benches/bench_frompyobject.rs::benches::criterion_benchmark::list_via_downcast
CodSpeed Performance Gauge
+20%
178.3 ns
149.2 ns
list_via_extractIgnored
pyo3-benches/benches/bench_frompyobject.rs::benches::criterion_benchmark::list_via_extract
CodSpeed Performance Gauge
-12%
212.8 ns
241.9 ns
not_a_list_via_downcastIgnored
pyo3-benches/benches/bench_frompyobject.rs::benches::criterion_benchmark::not_a_list_via_downcast
CodSpeed Performance Gauge
+9%
367.5 ns
338.3 ns
getattr_directIgnored
pyo3-benches/benches/bench_intern.rs::benches::criterion_benchmark::getattr_direct
CodSpeed Performance Gauge
0%
6.8 µs
6.8 µs
byte_slice_into_pyobject_smallIgnored
pyo3-benches/benches/bench_intopyobject.rs::benches::criterion_benchmark::byte_slice_into_pyobject_small
CodSpeed Performance Gauge
-7%
365.3 ns
394.4 ns
bytes_new_smallIgnored
pyo3-benches/benches/bench_intopyobject.rs::benches::criterion_benchmark::bytes_new_small
CodSpeed Performance Gauge
-8%
336.1 ns
365.3 ns
sequence_from_listIgnored
pyo3-benches/benches/bench_list.rs::benches::criterion_benchmark::sequence_from_list
CodSpeed Performance Gauge
0%
270.8 ns
270.8 ns
sequence_from_tupleIgnored
pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark::sequence_from_tuple
CodSpeed Performance Gauge
-6%
425.8 ns
455 ns

Commits

Click on a commit to change the comparison range
Base
main
5aa2a9b
0%
fix(pymodule): improve safety of PyModule::from_code If `PyImport_ExecCodeModuleEx` is called with an empty filename or module name, references to any Python variables defined in this context may break assumptions in standard library code. Notably, if `inspect.stack()` is called while any stack frame holds a reference to a variable declared in this Python snippet, and `file_name` is empty, then `inspect.stack()` will throw while trying to resolve the file in which said variable was defined. The `exec` builtin handles this by defaulting `file_name` to `<string>` and `module_name` to `<module>` - these are not the most obvious defaults, but in the spirit of consistency and providing pyo3 users with a safe API, it makes sense for `PyModule::from_code` to do the same.
f1b00cc
19 days ago
by sxlijin
© 2024 CodSpeed Technology
Home Terms PrivacyDocs