BlogDocs

Use portable-atomic for targets which lack 64-bit atomics used to check interpreter ID.(#3619)

Merged
Merging
portable-atomic
into
main
+22%
IMPROVEMENTS
0
REGRESSIONS
0
UNTOUCHED
65
NEW
0
DROPPED
0
IGNORED
13

Benchmarks

Passing

collect_generic_iterator
pyo3-benches/benches/bench_any.rs::benches::criterion_benchmark::collect_generic_iterator
0%
333.9 ms
333.9 ms
identify_object_type
pyo3-benches/benches/bench_any.rs::benches::criterion_benchmark::identify_object_type
+2%
27.2 µs
26.6 µs
extract_bigint_big_negative
pyo3-benches/benches/bench_bigint.rs::benches::criterion_benchmark::extract_bigint_big_negative
0%
8.4 µs
8.4 µs
extract_bigint_big_positive
pyo3-benches/benches/bench_bigint.rs::benches::criterion_benchmark::extract_bigint_big_positive
+1%
7.6 µs
7.5 µs
extract_bigint_extract_fail
pyo3-benches/benches/bench_bigint.rs::benches::criterion_benchmark::extract_bigint_extract_fail
-1%
17.4 µs
17.5 µs
extract_bigint_huge_negative
pyo3-benches/benches/bench_bigint.rs::benches::criterion_benchmark::extract_bigint_huge_negative
0%
49.4 µs
49.5 µs
extract_bigint_huge_positive
pyo3-benches/benches/bench_bigint.rs::benches::criterion_benchmark::extract_bigint_huge_positive
0%
43.2 µs
43.2 µs
extract_bigint_small
pyo3-benches/benches/bench_bigint.rs::benches::criterion_benchmark::extract_bigint_small
+2%
4 µs
4 µs
call_0
pyo3-benches/benches/bench_call.rs::benches::criterion_benchmark::call_0
0%
1.3 ms
1.3 ms
call_method_0
pyo3-benches/benches/bench_call.rs::benches::criterion_benchmark::call_method_0
0%
3.7 ms
3.7 ms
ordered_dunder_methods
pyo3-benches/benches/bench_comparisons.rs::benches::criterion_benchmark::ordered_dunder_methods
-1%
4.1 µs
4.1 µs
ordered_richcmp
pyo3-benches/benches/bench_comparisons.rs::benches::criterion_benchmark::ordered_richcmp
0%
4.1 µs
4.1 µs
decimal_via_extract
pyo3-benches/benches/bench_decimal.rs::benches::criterion_benchmark::decimal_via_extract
0%
22.4 µs
22.4 µs
dict_get_item
pyo3-benches/benches/bench_dict.rs::benches::criterion_benchmark::dict_get_item
0%
88.6 ms
88.6 ms
dict_new
pyo3-benches/benches/bench_dict.rs::benches::criterion_benchmark::dict_new
0%
132.8 ms
132.8 ms
extract_btreemap
pyo3-benches/benches/bench_dict.rs::benches::criterion_benchmark::extract_btreemap
0%
219.9 ms
219.9 ms
extract_hashmap
pyo3-benches/benches/bench_dict.rs::benches::criterion_benchmark::extract_hashmap
0%
111.8 ms
111.8 ms
iter_dict
pyo3-benches/benches/bench_dict.rs::benches::criterion_benchmark::iter_dict
0%
57.4 ms
57.4 ms
err_new_restore_and_fetch
pyo3-benches/benches/bench_err.rs::benches::criterion_benchmark::err_new_restore_and_fetch
0%
10.7 µs
10.7 µs
err_new_without_gil
pyo3-benches/benches/bench_err.rs::benches::criterion_benchmark::err_new_without_gil
0%
1.6 µs
1.6 µs
extract_float_downcast_fail
pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark::extract_float_downcast_fail
+6%
482.8 ns
455 ns
extract_float_extract_fail
pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark::extract_float_extract_fail
-4%
17.1 µs
17.8 µs
extract_int_downcast_success
pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark::extract_int_downcast_success
0%
888.9 ns
888.9 ns
extract_int_extract_fail
pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark::extract_int_extract_fail
0%
17.3 µs
17.3 µs
extract_str_extract_fail
pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark::extract_str_extract_fail
-1%
2.4 µs
2.4 µs
enum_from_pyobject
pyo3-benches/benches/bench_frompyobject.rs::benches::criterion_benchmark::enum_from_pyobject
0%
40.5 µs
40.7 µs
f64_from_pyobject
pyo3-benches/benches/bench_frompyobject.rs::benches::criterion_benchmark::f64_from_pyobject
+11%
272.2 ns
244.4 ns
not_a_list_via_extract
pyo3-benches/benches/bench_frompyobject.rs::benches::criterion_benchmark::not_a_list_via_extract
-1%
2.4 µs
2.5 µs
not_a_list_via_extract_enum
pyo3-benches/benches/bench_frompyobject.rs::benches::criterion_benchmark::not_a_list_via_extract_enum
-2%
26.1 µs
26.7 µs
clean_acquire_gil
pyo3-benches/benches/bench_gil.rs::benches::criterion_benchmark::clean_acquire_gil
-1%
4.9 µs
5 µs
clean_gilpool_new
pyo3-benches/benches/bench_gil.rs::benches::criterion_benchmark::clean_gilpool_new
-4%
677.2 ns
705 ns
dirty_acquire_gil
pyo3-benches/benches/bench_gil.rs::benches::criterion_benchmark::dirty_acquire_gil
0%
6.2 µs
6.2 µs
getattr_intern
pyo3-benches/benches/bench_intern.rs::benches::criterion_benchmark::getattr_intern
-1%
3.9 µs
4 µs
iter_list
pyo3-benches/benches/bench_list.rs::benches::criterion_benchmark::iter_list
0%
37.4 ms
37.4 ms
list_get_item
pyo3-benches/benches/bench_list.rs::benches::criterion_benchmark::list_get_item
0%
23.6 ms
23.6 ms
list_get_item_unchecked
pyo3-benches/benches/bench_list.rs::benches::criterion_benchmark::list_get_item_unchecked
0%
19.5 ms
19.5 ms
list_new
pyo3-benches/benches/bench_list.rs::benches::criterion_benchmark::list_new
0%
33.6 ms
33.6 ms
first_time_init
pyo3-benches/benches/bench_pyclass.rs::benches::criterion_benchmark::first_time_init
-1%
73.8 µs
74.3 µs
drop_many_objects
pyo3-benches/benches/bench_pyobject.rs::benches::criterion_benchmark::drop_many_objects
0%
55.3 µs
55.3 µs
extract_btreeset
pyo3-benches/benches/bench_set.rs::benches::criterion_benchmark::extract_btreeset
0%
97.4 ms
97.4 ms
extract_hashset
pyo3-benches/benches/bench_set.rs::benches::criterion_benchmark::extract_hashset
0%
105.3 ms
105.2 ms
iter_set
pyo3-benches/benches/bench_set.rs::benches::criterion_benchmark::iter_set
0%
58.7 ms
58.7 ms
set_new
pyo3-benches/benches/bench_set.rs::benches::criterion_benchmark::set_new
0%
71.4 ms
71.4 ms
iter_tuple
pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark::iter_tuple
0%
27.8 ms
27.8 ms
sequence_from_tuple
pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark::sequence_from_tuple
-9%
292.2 ns
320 ns
tuple_get_item
pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark::tuple_get_item
0%
18.7 ms
18.7 ms
tuple_get_item_unchecked
pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark::tuple_get_item_unchecked
0%
15.5 ms
15.5 ms
tuple_into_py
pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark::tuple_into_py
0%
5 µs
5 µs
tuple_new
pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark::tuple_new
0%
33.4 ms
33.4 ms
tuple_new_list
pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark::tuple_new_list
0%
7.1 ms
7.1 ms
tuple_to_list
pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark::tuple_to_list
0%
3.6 ms
3.6 ms
test_empty_class_init
pytests/tests/test_pyclasses.py::test_empty_class_init
0%
31.9 µs
31.8 µs
test_empty_class_init_py
pytests/tests/test_pyclasses.py::test_empty_class_init_py
+1%
25 µs
24.8 µs
test_args_kwargs_py
pytests/tests/test_pyfunctions.py::test_args_kwargs_py
0%
32.7 µs
32.6 µs
test_args_kwargs_rs
pytests/tests/test_pyfunctions.py::test_args_kwargs_rs
0%
23 µs
22.8 µs
test_none_py
pytests/tests/test_pyfunctions.py::test_none_py
0%
17.4 µs
17.3 µs
test_none_rs
pytests/tests/test_pyfunctions.py::test_none_rs
0%
17.2 µs
17.2 µs
test_simple_args_kwargs_py
pytests/tests/test_pyfunctions.py::test_simple_args_kwargs_py
+1%
34.4 µs
34.2 µs
test_simple_args_kwargs_rs
pytests/tests/test_pyfunctions.py::test_simple_args_kwargs_rs
0%
37.2 µs
37 µs
test_simple_args_py
pytests/tests/test_pyfunctions.py::test_simple_args_py
0%
27.7 µs
27.7 µs
test_simple_args_rs
pytests/tests/test_pyfunctions.py::test_simple_args_rs
0%
32.6 µs
32.7 µs
test_simple_kwargs_py
pytests/tests/test_pyfunctions.py::test_simple_kwargs_py
+3%
35.7 µs
34.7 µs
test_simple_kwargs_rs
pytests/tests/test_pyfunctions.py::test_simple_kwargs_rs
-4%
35.1 µs
36.5 µs
test_simple_py
pytests/tests/test_pyfunctions.py::test_simple_py
+1%
27.5 µs
27.3 µs
test_simple_rs
pytests/tests/test_pyfunctions.py::test_simple_rs
0%
27.4 µs
27.5 µs

Ignored

mapping_from_dictIgnored
pyo3-benches/benches/bench_dict.rs::benches::criterion_benchmark::mapping_from_dict
-17%
262.8 ns
318.3 ns
extract_float_downcast_successIgnored
pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark::extract_float_downcast_success
-11%
461.1 ns
516.7 ns
extract_float_extract_successIgnored
pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark::extract_float_extract_success
-8%
305 ns
332.8 ns
extract_int_downcast_failIgnored
pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark::extract_int_downcast_fail
0%
266.1 ns
266.1 ns
extract_int_extract_successIgnored
pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark::extract_int_extract_success
0%
734.4 ns
734.4 ns
extract_str_downcast_failIgnored
pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark::extract_str_downcast_fail
0%
266.1 ns
266.1 ns
extract_str_downcast_successIgnored
pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark::extract_str_downcast_success
+6%
477.8 ns
450 ns
extract_str_extract_successIgnored
pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark::extract_str_extract_success
-10%
482.8 ns
538.3 ns
list_via_downcastIgnored
pyo3-benches/benches/bench_frompyobject.rs::benches::criterion_benchmark::list_via_downcast
+22%
153.9 ns
126.1 ns
list_via_extractIgnored
pyo3-benches/benches/bench_frompyobject.rs::benches::criterion_benchmark::list_via_extract
-10%
246.1 ns
273.9 ns
not_a_list_via_downcastIgnored
pyo3-benches/benches/bench_frompyobject.rs::benches::criterion_benchmark::not_a_list_via_downcast
-18%
126.1 ns
153.9 ns
getattr_directIgnored
pyo3-benches/benches/bench_intern.rs::benches::criterion_benchmark::getattr_direct
0%
9.2 µs
9.2 µs
sequence_from_listIgnored
pyo3-benches/benches/bench_list.rs::benches::criterion_benchmark::sequence_from_list
+19%
347.8 ns
292.2 ns

Commits

Click on a commit to change the comparison range
base
main
81ad2e8
+22%
Use portable-atomic for targets which lack 64-bit atomics used to check interpreter ID. I chose to make the dependency mandatory instead of optional as portable-atomic itself just forwards to the native atomics when they are available so making that choice part of our build system is not really necessary. Personally, I was unable to perceive any noticeable compile-time hit from adding it.
e6457c5
5 months ago by adamreichold
ResourcesHomePricingDocsBlogGitHub
Copyright © 2024 CodSpeed Technology SAS. All rights reserved.