davidhewitt:extract-arg2 - Branch - PyO3/pyo3

update `extract_argument` to use Bound APIs

#3708Merged

Comparing

davidhewitt:extract-arg2

(

101563c

) with

main

(

a15e4b1

)

Untouched: 61

Ignored: 6

Benchmarks

Passed

test_simple_kwargs_rs

pytests/tests/test_pyfunctions.py

+7%

22.2 µs20.8 µs

test_simple_args_kwargs_rs

pytests/tests/test_pyfunctions.py

+6%

22.2 µs20.9 µs

test_args_kwargs_rs

pytests/tests/test_pyfunctions.py

+4%

16.7 µs16 µs

test_simple_args_rs

pytests/tests/test_pyfunctions.py

+3%

20.2 µs19.6 µs

extract_str_extract_fail

pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark

+3%

2.2 µs2.2 µs

test_simple_rs

pytests/tests/test_pyfunctions.py

+2%

19.2 µs18.7 µs

getattr_intern

pyo3-benches/benches/bench_intern.rs::benches::criterion_benchmark

+2%

3.2 µs3.1 µs

not_a_list_via_extract_enum

pyo3-benches/benches/bench_frompyobject.rs::benches::criterion_benchmark

+1%

13.1 µs13 µs

tuple_into_py

pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark

+1%

2.9 µs2.9 µs

extract_bigint_big_positive

pyo3-benches/benches/bench_bigint.rs::benches::criterion_benchmark

+1%

3.8 µs3.8 µs

test_empty_class_init

pytests/tests/test_pyclasses.py

+1%

21.6 µs21.5 µs

call_method_0

pyo3-benches/benches/bench_call.rs::benches::criterion_benchmark

607.8 µs604.9 µs

extract_bigint_huge_negative

pyo3-benches/benches/bench_bigint.rs::benches::criterion_benchmark

13.4 µs13.4 µs

decimal_via_extract

pyo3-benches/benches/bench_decimal.rs::benches::criterion_benchmark

14.7 µs14.7 µs

identify_object_type

pyo3-benches/benches/bench_any.rs::benches::criterion_benchmark

15.4 µs15.4 µs

extract_bigint_huge_positive

pyo3-benches/benches/bench_bigint.rs::benches::criterion_benchmark

11.6 µs11.6 µs

extract_btreemap

pyo3-benches/benches/bench_dict.rs::benches::criterion_benchmark

36.3 ms36.3 ms

call_0

pyo3-benches/benches/bench_call.rs::benches::criterion_benchmark

203.3 µs203.3 µs

extract_hashmap

pyo3-benches/benches/bench_dict.rs::benches::criterion_benchmark

20 ms20 ms

list_get_item

pyo3-benches/benches/bench_list.rs::benches::criterion_benchmark

3.8 ms3.8 ms

tuple_new

pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark

7.1 ms7.1 ms

tuple_to_list

pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark

1.6 ms1.6 ms

list_get_item_unchecked

pyo3-benches/benches/bench_list.rs::benches::criterion_benchmark

3.3 ms3.3 ms

iter_list

pyo3-benches/benches/bench_list.rs::benches::criterion_benchmark

6.1 ms6.1 ms

set_new

pyo3-benches/benches/bench_set.rs::benches::criterion_benchmark

16.5 ms16.5 ms

dict_get_item

pyo3-benches/benches/bench_dict.rs::benches::criterion_benchmark

15.9 ms15.9 ms

iter_set

pyo3-benches/benches/bench_set.rs::benches::criterion_benchmark

10.2 ms10.2 ms

collect_generic_iterator

pyo3-benches/benches/bench_any.rs::benches::criterion_benchmark

106.1 ms106.1 ms

extract_bigint_extract_fail

pyo3-benches/benches/bench_bigint.rs::benches::criterion_benchmark

11.4 µs11.4 µs

test_simple_args_kwargs_py

pytests/tests/test_pyfunctions.py

21.1 µs21.1 µs

extract_bigint_big_negative

pyo3-benches/benches/bench_bigint.rs::benches::criterion_benchmark

4.1 µs4.1 µs

extract_bigint_small

pyo3-benches/benches/bench_bigint.rs::benches::criterion_benchmark

3.1 µs3.1 µs

clean_acquire_gil

pyo3-benches/benches/bench_gil.rs::benches::criterion_benchmark

3.6 µs3.6 µs

dirty_acquire_gil

pyo3-benches/benches/bench_gil.rs::benches::criterion_benchmark

4.4 µs4.4 µs

drop_many_objects

pyo3-benches/benches/bench_pyobject.rs::benches::criterion_benchmark

11.7 µs11.7 µs

iter_dict

pyo3-benches/benches/bench_dict.rs::benches::criterion_benchmark

10.9 ms10.9 ms

tuple_get_borrowed_item

pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark

3.6 ms3.6 ms

iter_tuple

pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark

5.3 ms5.3 ms

list_new

pyo3-benches/benches/bench_list.rs::benches::criterion_benchmark

7.1 ms7.1 ms

dict_new

pyo3-benches/benches/bench_dict.rs::benches::criterion_benchmark

25.6 ms25.6 ms

tuple_new_list

pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark

2.2 ms2.2 ms

extract_btreeset

pyo3-benches/benches/bench_set.rs::benches::criterion_benchmark

15.3 ms15.3 ms

tuple_get_borrowed_item_unchecked

pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark

3 ms3 ms

tuple_get_item

pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark

3.8 ms3.8 ms

tuple_get_item_unchecked

pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark

3.2 ms3.2 ms

extract_hashset

pyo3-benches/benches/bench_set.rs::benches::criterion_benchmark

20.6 ms20.6 ms

test_simple_kwargs_py

pytests/tests/test_pyfunctions.py

21.8 µs21.9 µs

test_none_py

pytests/tests/test_pyfunctions.py

11.7 µs11.8 µs

extract_int_extract_fail

pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark

11.5 µs11.5 µs

enum_from_pyobject

pyo3-benches/benches/bench_frompyobject.rs::benches::criterion_benchmark

18.8 µs18.8 µs

test_simple_args_py

pytests/tests/test_pyfunctions.py

17.9 µs17.9 µs

err_new_restore_and_fetch

pyo3-benches/benches/bench_err.rs::benches::criterion_benchmark

7.5 µs7.6 µs

extract_float_extract_fail

pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark

-1%

11.6 µs11.7 µs

first_time_init

pyo3-benches/benches/bench_pyclass.rs::benches::criterion_benchmark

-1%

39.7 µs40 µs

test_simple_py

pytests/tests/test_pyfunctions.py

-1%

19.1 µs19.2 µs

test_empty_class_init_py

pytests/tests/test_pyclasses.py

-1%

15.7 µs15.9 µs

test_none_rs

pytests/tests/test_pyfunctions.py

-2%

12 µs12.2 µs

err_new_without_gil

pyo3-benches/benches/bench_err.rs::benches::criterion_benchmark

-2%

1.3 µs1.3 µs

test_args_kwargs_py

pytests/tests/test_pyfunctions.py

-3%

20.4 µs21 µs

ordered_dunder_methods

pyo3-benches/benches/bench_comparisons.rs::benches::criterion_benchmark

-4%

3.1 µs3.2 µs

ordered_richcmp

pyo3-benches/benches/bench_comparisons.rs::benches::criterion_benchmark

-6%

3 µs3.2 µs

Ignored

getattr_direct

pyo3-benches/benches/bench_intern.rs::benches::criterion_benchmark

Ignored

+1%

6.7 µs6.7 µs

extract_str_extract_success

pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark

Ignored

+3%

888.6 ns859.4 ns

extract_str_downcast_success

pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark

Ignored

-5%

524.7 ns553.9 ns

extract_str_downcast_fail

pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark

Ignored

246.4 ns246.4 ns

not_a_list_via_extract

pyo3-benches/benches/bench_frompyobject.rs::benches::criterion_benchmark

Ignored

1.8 µs1.8 µs

extract_float_downcast_fail

pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark

Ignored

-6%

458.9 ns488.1 ns

Commits

Click on a commit to change the comparison range

Base

main

a15e4b1

-29.12%

tidy up borrow in macros expression

7cb8e99

2 years ago

by davidhewitt

-0.47%

update `trybuild` output

2d07582

2 years ago

by davidhewitt

+0.47%

more concise form for `DowncastError::new` Co-authored-by: Lily Foote <code@lilyf.org>

9a599c3

2 years ago

by davidhewitt

-4.2%

use `Borrowed` instead of newtype

22f960f

2 years ago

by davidhewitt

+3.28%

use `Borrowed::from_ptr` methods in extract_argument

89913e8

2 years ago

by davidhewitt

-3.43%

update UI tests

9ec7084

2 years ago

by davidhewitt

+33.17%

avoid double-negative `#[cfg]` clauses Co-authored-by: Lily Foote <code@lilyf.org>

306aa81

2 years ago

by davidhewitt

+0.36%

review: LilyFoote, Icxolu feedback

101563c

2 years ago

by davidhewitt

Home Terms Privacy Docs