davidhewitt:simplify-extract-argument - Branch - PyO3/pyo3

simplify `extract_argument` code for `&T: PyClass`

#5408Merged

Comparing

davidhewitt:simplify-extract-argument

(

6db6bb7

) with

main

(

ee29399

)

Untouched: 96

Ignored: 21

Benchmarks

Passed

extract_bigint_small

pyo3-benches/benches/bench_bigint.rs::benches::criterion_benchmark

+3%

2.6 µs2.5 µs

err_new_without_gil

pyo3-benches/benches/bench_err.rs::benches::criterion_benchmark

+2%

1.3 µs1.3 µs

extract_bigint_big_positive

pyo3-benches/benches/bench_bigint.rs::benches::criterion_benchmark

+2%

3.6 µs3.6 µs

list_nth

pyo3-benches/benches/bench_list.rs::benches::criterion_benchmark

+1%

4.4 µs4.4 µs

identify_object_type

pyo3-benches/benches/bench_any.rs::benches::criterion_benchmark

+1%

15.6 µs15.4 µs

dirty_attach

pyo3-benches/benches/bench_attach.rs::benches::criterion_benchmark

+1%

5.2 µs5.2 µs

ordered_dunder_methods

pyo3-benches/benches/bench_comparisons.rs::benches::criterion_benchmark

+1%

2.8 µs2.8 µs

tuple_into_pyobject

pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark

+1%

2.9 µs2.8 µs

extract_bigint_big_negative

pyo3-benches/benches/bench_bigint.rs::benches::criterion_benchmark

+1%

3.9 µs3.9 µs

err_new_restore_and_fetch

pyo3-benches/benches/bench_err.rs::benches::criterion_benchmark

+1%

7.9 µs7.9 µs

list_nth_back

pyo3-benches/benches/bench_list.rs::benches::criterion_benchmark

+1%

4.5 µs4.5 µs

extract_bigint_huge_positive

pyo3-benches/benches/bench_bigint.rs::benches::criterion_benchmark

+1%

11.6 µs11.6 µs

extract_float_extract_fail

pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark

11.7 µs11.7 µs

enum_from_pyobject

pyo3-benches/benches/bench_frompyobject.rs::benches::criterion_benchmark

24.2 µs24.1 µs

extract_bigint_huge_negative

pyo3-benches/benches/bench_bigint.rs::benches::criterion_benchmark

13.2 µs13.1 µs

drop_many_objects

pyo3-benches/benches/bench_py.rs::benches::criterion_benchmark

11.4 µs11.3 µs

extract_bigint_extract_fail

pyo3-benches/benches/bench_bigint.rs::benches::criterion_benchmark

11.7 µs11.7 µs

extract_hashbrown_set

pyo3-benches/benches/bench_set.rs::benches::criterion_benchmark

16.2 ms16.2 ms

not_a_list_via_extract_enum

pyo3-benches/benches/bench_frompyobject.rs::benches::criterion_benchmark

17.2 µs17.1 µs

test_proto_call

pytests/tests/test_pyclasses.py

13.5 µs13.4 µs

test_simple_args_kwargs_rs

pytests/tests/test_pyfunctions.py

19.1 µs19.1 µs

first_time_init

pyo3-benches/benches/bench_pyclass.rs::benches::criterion_benchmark

39.1 µs39.1 µs

extract_hashset

pyo3-benches/benches/bench_set.rs::benches::criterion_benchmark

20.8 ms20.8 ms

call_method_one_arg

pyo3-benches/benches/bench_call.rs::benches::criterion_benchmark

628.2 µs628.1 µs

extract_hashmap

pyo3-benches/benches/bench_dict.rs::benches::criterion_benchmark

20.5 ms20.5 ms

vec_bytes_from_py_bytearray_large

pyo3-benches/benches/bench_frompyobject.rs::benches::criterion_benchmark

5.8 ms5.8 ms

list_new

pyo3-benches/benches/bench_list.rs::benches::criterion_benchmark

6.7 ms6.7 ms

list_get_item_unchecked

pyo3-benches/benches/bench_list.rs::benches::criterion_benchmark

3.5 ms3.5 ms

set_new

pyo3-benches/benches/bench_set.rs::benches::criterion_benchmark

15.2 ms15.2 ms

list_get_item

pyo3-benches/benches/bench_list.rs::benches::criterion_benchmark

4.1 ms4.1 ms

iter_list

pyo3-benches/benches/bench_list.rs::benches::criterion_benchmark

6.7 ms6.7 ms

dict_new

pyo3-benches/benches/bench_dict.rs::benches::criterion_benchmark

25.7 ms25.7 ms

tuple_new_list

pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark

2.1 ms2.1 ms

clean_attach

pyo3-benches/benches/bench_attach.rs::benches::criterion_benchmark

3.6 µs3.6 µs

vec_bytes_from_py_bytes_medium

pyo3-benches/benches/bench_frompyobject.rs::benches::criterion_benchmark

23.2 µs23.2 µs

call_0

pyo3-benches/benches/bench_call.rs::benches::criterion_benchmark

191.6 µs191.6 µs

drop_many_objects_without_gil

pyo3-benches/benches/bench_py.rs::benches::criterion_benchmark

41.5 µs41.5 µs

call_one_arg

pyo3-benches/benches/bench_call.rs::benches::criterion_benchmark

232.2 µs232.2 µs

ordered_richcmp

pyo3-benches/benches/bench_comparisons.rs::benches::criterion_benchmark

2.6 µs2.6 µs

extract_int_extract_fail

pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark

11.7 µs11.7 µs

extract_str_extract_fail

pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark

1.8 µs1.8 µs

vec_bytes_from_py_bytearray_medium

pyo3-benches/benches/bench_frompyobject.rs::benches::criterion_benchmark

23.6 µs23.6 µs

tuple_nth_back

pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark

4.2 µs4.2 µs

tuple_nth

pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark

4.1 µs4.1 µs

collect_generic_iterator

pyo3-benches/benches/bench_any.rs::benches::criterion_benchmark

105.4 ms105.4 ms

iter_set

pyo3-benches/benches/bench_set.rs::benches::criterion_benchmark

10.6 ms10.6 ms

tuple_new

pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark

6.7 ms6.7 ms

dict_get_item

pyo3-benches/benches/bench_dict.rs::benches::criterion_benchmark

16.5 ms16.5 ms

iter_tuple

pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark

5.9 ms5.9 ms

tuple_get_item

pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark

4 ms4 ms

iter_dict

pyo3-benches/benches/bench_dict.rs::benches::criterion_benchmark

11.4 ms11.4 ms

vec_bytes_from_py_bytes_large

pyo3-benches/benches/bench_frompyobject.rs::benches::criterion_benchmark

5.6 ms5.6 ms

tuple_to_list

pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark

1.6 ms1.6 ms

tuple_get_borrowed_item_unchecked

pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark

3.3 ms3.3 ms

extract_btreeset

pyo3-benches/benches/bench_set.rs::benches::criterion_benchmark

15.9 ms15.9 ms

tuple_get_item_unchecked

pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark

3.5 ms3.5 ms

tuple_get_borrowed_item

pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark

3.8 ms3.8 ms

call_method_0

pyo3-benches/benches/bench_call.rs::benches::criterion_benchmark

608.2 µs608.3 µs

bytes_new_large

pyo3-benches/benches/bench_intopyobject.rs::benches::criterion_benchmark

176.7 µs176.7 µs

byte_slice_into_pyobject_large

pyo3-benches/benches/bench_intopyobject.rs::benches::criterion_benchmark

176.7 µs176.7 µs

call_method_1

pyo3-benches/benches/bench_call.rs::benches::criterion_benchmark

657.4 µs657.5 µs

call

pyo3-benches/benches/bench_call.rs::benches::criterion_benchmark

609.5 µs609.5 µs

call_method

pyo3-benches/benches/bench_call.rs::benches::criterion_benchmark

1.3 ms1.3 ms

call_1

pyo3-benches/benches/bench_call.rs::benches::criterion_benchmark

253.5 µs253.5 µs

extract_btreemap

pyo3-benches/benches/bench_dict.rs::benches::criterion_benchmark

37.7 ms37.7 ms

extract_hashbrown_map

pyo3-benches/benches/bench_dict.rs::benches::criterion_benchmark

17.8 ms17.8 ms

test_simple_args_py

pytests/tests/test_pyfunctions.py

17.7 µs17.8 µs

test_args_kwargs_py

pytests/tests/test_pyfunctions.py

18.9 µs19 µs

decimal_via_extract

pyo3-benches/benches/bench_decimal.rs::benches::criterion_benchmark

15.1 µs15.1 µs

test_simple_kwargs_rs

pytests/tests/test_pyfunctions.py

18.7 µs18.8 µs

test_args_kwargs_rs

pytests/tests/test_pyfunctions.py

14.3 µs14.4 µs

test_simple_kwargs_py

pytests/tests/test_pyfunctions.py

20.3 µs20.4 µs

test_none_py

pytests/tests/test_pyfunctions.py

-1%

13.3 µs13.4 µs

test_simple_py

pytests/tests/test_pyfunctions.py

-1%

17.4 µs17.5 µs

test_setter

pytests/tests/test_pyclasses.py

-1%

16.8 µs16.9 µs

test_simple_args_kwargs_py

pytests/tests/test_pyfunctions.py

-1%

20.6 µs20.7 µs

test_method_call_py

pytests/tests/test_pyclasses.py

-1%

13.8 µs13.9 µs

test_class_method

pytests/tests/test_pyclasses.py

-1%

17.7 µs17.8 µs

test_method_call

pytests/tests/test_pyclasses.py

-1%

14.9 µs15 µs

test_with_typed_args_rs

pytests/tests/test_pyfunctions.py

-1%

17.3 µs17.5 µs

test_with_typed_args_py

pytests/tests/test_pyfunctions.py

-1%

13.5 µs13.6 µs

test_simple_args_rs

pytests/tests/test_pyfunctions.py

-1%

18.9 µs19.1 µs

test_proto_call_py

pytests/tests/test_pyclasses.py

-1%

14.3 µs14.5 µs

test_class_attribute

pytests/tests/test_pyclasses.py

-1%

14 µs14.1 µs

test_positional_only_rs

pytests/tests/test_pyfunctions.py

-1%

13.6 µs13.8 µs

test_positional_only_py

pytests/tests/test_pyfunctions.py

-1%

13.4 µs13.6 µs

vec_into_pyobject

pyo3-benches/benches/bench_intopyobject.rs::benches::criterion_benchmark

-1%

2.5 µs2.5 µs

test_simple_rs

pytests/tests/test_pyfunctions.py

-1%

18.2 µs18.4 µs

test_static_method

pytests/tests/test_pyclasses.py

-1%

15.5 µs15.6 µs

test_getter

pytests/tests/test_pyclasses.py

-1%

16.2 µs16.4 µs

test_empty_class_init_py

pytests/tests/test_pyclasses.py

-1%

13.9 µs14.1 µs

test_none_rs

pytests/tests/test_pyfunctions.py

-1%

12.5 µs12.7 µs

getattr_intern

pyo3-benches/benches/bench_intern.rs::benches::criterion_benchmark

-2%

3.3 µs3.4 µs

byte_slice_into_pyobject_medium

pyo3-benches/benches/bench_intopyobject.rs::benches::criterion_benchmark

-2%

1.6 µs1.6 µs

bytes_new_medium

pyo3-benches/benches/bench_intopyobject.rs::benches::criterion_benchmark

-2%

1.6 µs1.6 µs

test_empty_class_init

pytests/tests/test_pyclasses.py

-4%

22.6 µs23.5 µs

Ignored

vec_bytes_from_py_bytes_small

pyo3-benches/benches/bench_frompyobject.rs::benches::criterion_benchmark

Ignored

-1%

4.4 µs4.4 µs

byte_slice_into_pyobject_small

pyo3-benches/benches/bench_intopyobject.rs::benches::criterion_benchmark

Ignored

335 ns335 ns

getattr_direct

pyo3-benches/benches/bench_intern.rs::benches::criterion_benchmark

Ignored

+1%

6.6 µs6.5 µs

bytes_new_small

pyo3-benches/benches/bench_intopyobject.rs::benches::criterion_benchmark

Ignored

-9%

305.8 ns335 ns

sequence_from_list

pyo3-benches/benches/bench_list.rs::benches::criterion_benchmark

Ignored

+11%

302.8 ns273.6 ns

extract_float_cast_fail

pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark

Ignored

-6%

453.9 ns483.1 ns

extract_float_cast_success

pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark

Ignored

178.3 ns178.3 ns

extract_float_extract_success

pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark

Ignored

+9%

362.2 ns333.1 ns

extract_int_cast_success

pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark

Ignored

587.2 ns587.2 ns

mapping_from_dict

pyo3-benches/benches/bench_dict.rs::benches::criterion_benchmark

Ignored

-10%

273.6 ns302.8 ns

extract_int_cast_fail

pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark

Ignored

-11%

245.6 ns274.7 ns

sequence_from_tuple

pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark

Ignored

+11%

302.8 ns273.6 ns

extract_int_extract_success

pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark

Ignored

493.6 ns493.6 ns

extract_str_cast_fail

pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark

Ignored

-14%

182.5 ns211.7 ns

list_via_cast

pyo3-benches/benches/bench_frompyobject.rs::benches::criterion_benchmark

Ignored

178.3 ns178.3 ns

not_a_list_via_cast

pyo3-benches/benches/bench_frompyobject.rs::benches::criterion_benchmark

Ignored

-14%

182.5 ns211.7 ns

extract_str_cast_success

pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark

Ignored

+17%

613.3 ns525.8 ns

extract_str_extract_success

pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark

Ignored

+5%

579.2 ns550 ns

not_a_list_via_extract

pyo3-benches/benches/bench_frompyobject.rs::benches::criterion_benchmark

Ignored

-24%

182.2 ns240.6 ns

list_via_extract

pyo3-benches/benches/bench_frompyobject.rs::benches::criterion_benchmark

Ignored

183.9 ns183.9 ns

vec_bytes_from_py_bytearray_small

pyo3-benches/benches/bench_frompyobject.rs::benches::criterion_benchmark

Ignored

4.4 µs4.4 µs

Commits

Click on a commit to change the comparison range

Base

main

ee29399

+0.06%

simplify `extract_argument` code for `&T: PyClass`

98ec966

4 months ago

by davidhewitt

+0.09%

remove `extract_optional_argument`

7fa8216

4 months ago

by davidhewitt

-0.22%

review feedback

eb12261

4 months ago

by davidhewitt

+0.12%

fixup

149f8dd

4 months ago

by davidhewitt

-0.18%

fixup UI test

6db6bb7

4 months ago

by davidhewitt

Home Terms Privacy Docs