davidhewitt:extract-rework - Branch - PyO3/pyo3

rework `extract_argument` code to populate holders as intermediate values

#5742

Comparing

davidhewitt:extract-rework

(

b3368d0

) with

main

(

86c48d3

)

Untouched: 105

Ignored: 21

Skipped: 1

Benchmarks

127 total

format_simple

pyo3-benches/benches/bench_pystring_from_fmt.rs::benches::criterion_benchmark

+19%

368.6 ns310.3 ns

byte_slice_into_pyobject_medium

pyo3-benches/benches/bench_intopyobject.rs::benches::criterion_benchmark

+4%

1.5 µs1.4 µs

call_method_one_arg

pyo3-benches/benches/bench_call.rs::benches::criterion_benchmark

+4%

633.2 µs610 µs

extract_str_extract_fail

pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark

+3%

2 µs1.9 µs

ordered_dunder_methods

pyo3-benches/benches/bench_comparisons.rs::benches::criterion_benchmark

+2%

2.6 µs2.5 µs

extract_bigint_small

pyo3-benches/benches/bench_bigint.rs::benches::criterion_benchmark

+2%

2.6 µs2.5 µs

bytes_new_medium

pyo3-benches/benches/bench_intopyobject.rs::benches::criterion_benchmark

+2%

1.4 µs1.4 µs

getattr_intern

pyo3-benches/benches/bench_intern.rs::benches::criterion_benchmark

+2%

3.3 µs3.2 µs

bench_str

pyo3-benches/benches/bench_pyclass.rs::benches::bench_pyclass

+2%

3.7 µs3.6 µs

list_nth

pyo3-benches/benches/bench_list.rs::benches::criterion_benchmark

+1%

8.5 µs8.4 µs

list_nth_back

pyo3-benches/benches/bench_list.rs::benches::criterion_benchmark

+1%

8.6 µs8.5 µs

ordered_richcmp

pyo3-benches/benches/bench_comparisons.rs::benches::criterion_benchmark

+1%

2.5 µs2.5 µs

call_method_1

pyo3-benches/benches/bench_call.rs::benches::criterion_benchmark

+1%

696 µs687.9 µs

tuple_nth

pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark

+1%

5.9 µs5.9 µs

tuple_nth_back

pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark

+1%

6 µs5.9 µs

test_with_typed_args_rs

pytests/tests/test_pyfunctions.py

+1%

14.7 µs14.6 µs

dirty_attach

pyo3-benches/benches/bench_attach.rs::benches::criterion_benchmark

+1%

3.7 µs3.7 µs

extract_bigint_big_negative

pyo3-benches/benches/bench_bigint.rs::benches::criterion_benchmark

+1%

3.8 µs3.8 µs

test_empty_class_init_py

pytests/tests/test_pyclasses.py

11 µs10.9 µs

test_none_py

pytests/tests/test_pyfunctions.py

11.1 µs11.1 µs

extract_bigint_huge_positive

pyo3-benches/benches/bench_bigint.rs::benches::criterion_benchmark

11.3 µs11.3 µs

extract_bigint_huge_negative

pyo3-benches/benches/bench_bigint.rs::benches::criterion_benchmark

13.4 µs13.3 µs

test_setter

pytests/tests/test_pyclasses.py

13.9 µs13.9 µs

set_new

pyo3-benches/benches/bench_set.rs::benches::criterion_benchmark

18.1 ms18 ms

drop_many_objects

pyo3-benches/benches/bench_py.rs::benches::criterion_benchmark

14.7 µs14.6 µs

Commits

Click on a commit to change the comparison range

Base

main

86c48d3

+14.52%

rework `extract_argument` code to populate holders as intermediate values

2c14bfb

2 months ago

by davidhewitt

-14.43%

clean up error messages

a9064a9

2 months ago

by davidhewitt

+0.01%

cleanup errors further

5edda8e

2 months ago

by davidhewitt

-0.03%

fix error messages

7534ecb

2 months ago

by davidhewitt

+10.08%

fix duplicate error message

9e184e1

2 months ago

by davidhewitt

use call-site hygiene for the extraction span

35b2838

2 months ago

by davidhewitt

return `extract_argument` functions to original location

efb9bb9

2 months ago

by davidhewitt

-10.23%

remove `Error` type from `PyFunctionArgument`

07e9db8

2 months ago

by davidhewitt

-0.01%

Merge branch 'main' into extract-rework

b3368d0

28 days ago

by davidhewitt

Home Terms Privacy Docs