davidhewitt:extract-rework - Branch - PyO3/pyo3

rework `extract_argument` code to populate holders as intermediate values

#5742

Comparing

davidhewitt:extract-rework

(

07e9db8

) with

main

(

c4c5b1e

)

Untouched: 100

Ignored: 21

Benchmarks

121 total

ordered_dunder_methods

pyo3-benches/benches/bench_comparisons.rs::benches::criterion_benchmark

+6%

2.5 µs2.4 µs

ordered_richcmp

pyo3-benches/benches/bench_comparisons.rs::benches::criterion_benchmark

+4%

2.5 µs2.4 µs

extract_str_extract_fail

pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark

+3%

1.9 µs1.8 µs

getattr_intern

pyo3-benches/benches/bench_intern.rs::benches::criterion_benchmark

+3%

3.1 µs3 µs

err_new_without_gil

pyo3-benches/benches/bench_err.rs::benches::criterion_benchmark

+2%

1.3 µs1.2 µs

bytes_new_medium

pyo3-benches/benches/bench_intopyobject.rs::benches::criterion_benchmark

+2%

1.6 µs1.6 µs

err_new_restore_and_fetch

pyo3-benches/benches/bench_err.rs::benches::criterion_benchmark

+1%

7.4 µs7.3 µs

extract_bigint_small

pyo3-benches/benches/bench_bigint.rs::benches::criterion_benchmark

+1%

2.7 µs2.7 µs

drop_many_objects

pyo3-benches/benches/bench_py.rs::benches::criterion_benchmark

+1%

3.2 µs3.2 µs

extract_bigint_big_positive

pyo3-benches/benches/bench_bigint.rs::benches::criterion_benchmark

+1%

3.7 µs3.6 µs

tuple_nth

pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark

+1%

4 µs4 µs

call_method_1

pyo3-benches/benches/bench_call.rs::benches::criterion_benchmark

696.9 µs693.7 µs

drop_many_objects_without_gil

pyo3-benches/benches/bench_py.rs::benches::criterion_benchmark

48.7 µs48.5 µs

test_proto_call

pytests/tests/test_pyclasses.py

14.7 µs14.7 µs

extract_bigint_extract_fail

pyo3-benches/benches/bench_bigint.rs::benches::criterion_benchmark

11.4 µs11.4 µs

extract_int_extract_fail

pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark

11.8 µs11.8 µs

call_one_arg

pyo3-benches/benches/bench_call.rs::benches::criterion_benchmark

240.7 µs240.6 µs

bytes_new_large

pyo3-benches/benches/bench_intopyobject.rs::benches::criterion_benchmark

176.8 µs176.8 µs

call_1

pyo3-benches/benches/bench_call.rs::benches::criterion_benchmark

263.1 µs263 µs

extract_hashset

pyo3-benches/benches/bench_set.rs::benches::criterion_benchmark

20.7 ms20.7 ms

vec_bytes_from_py_bytes_large

pyo3-benches/benches/bench_frompyobject.rs::benches::criterion_benchmark

177.6 µs177.6 µs

byte_slice_into_pyobject_large

pyo3-benches/benches/bench_intopyobject.rs::benches::criterion_benchmark

176.8 µs176.8 µs

extract_hashmap

pyo3-benches/benches/bench_dict.rs::benches::criterion_benchmark

20.5 ms20.5 ms

call_method_one_arg

pyo3-benches/benches/bench_call.rs::benches::criterion_benchmark

661.5 µs661.5 µs

tuple_get_borrowed_item_unchecked

pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark

3.1 ms3.1 ms

Commits

Click on a commit to change the comparison range

Base

main

c4c5b1e

+14.52%

rework `extract_argument` code to populate holders as intermediate values

2c14bfb

6 days ago

by davidhewitt

-14.43%

clean up error messages

a9064a9

6 days ago

by davidhewitt

+0.01%

cleanup errors further

5edda8e

6 days ago

by davidhewitt

-0.03%

fix error messages

7534ecb

6 days ago

by davidhewitt

+10.08%

fix duplicate error message

9e184e1

5 days ago

by davidhewitt

use call-site hygiene for the extraction span

35b2838

4 days ago

by davidhewitt

return `extract_argument` functions to original location

efb9bb9

4 days ago

by davidhewitt

-10.23%

remove `Error` type from `PyFunctionArgument`

07e9db8

4 days ago

by davidhewitt

Home Terms Privacy Docs