davidhewitt:attach-panic-shutting-down - Branch - PyO3/pyo3

panic on attach if interpreter is shutting down

#5317Merged

Comparing

davidhewitt:attach-panic-shutting-down

(

d4febfe

) with

main

(

12a1792

)

Untouched: 92

Ignored: 19

Benchmarks

Passed

extract_str_extract_fail

pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark

+5%

1.9 µs1.8 µs

bytes_new_medium

pyo3-benches/benches/bench_intopyobject.rs::benches::criterion_benchmark

+4%

1.6 µs1.6 µs

byte_slice_into_pyobject_medium

pyo3-benches/benches/bench_intopyobject.rs::benches::criterion_benchmark

+4%

1.6 µs1.6 µs

err_new_restore_and_fetch

pyo3-benches/benches/bench_err.rs::benches::criterion_benchmark

+3%

8 µs7.8 µs

vec_into_pyobject

pyo3-benches/benches/bench_intopyobject.rs::benches::criterion_benchmark

+2%

2.6 µs2.6 µs

extract_bigint_small

pyo3-benches/benches/bench_bigint.rs::benches::criterion_benchmark

+2%

2.7 µs2.6 µs

extract_int_extract_fail

pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark

+2%

11.9 µs11.7 µs

decimal_via_extract

pyo3-benches/benches/bench_decimal.rs::benches::criterion_benchmark

+2%

15.4 µs15.1 µs

extract_bigint_extract_fail

pyo3-benches/benches/bench_bigint.rs::benches::criterion_benchmark

+2%

11.9 µs11.7 µs

not_a_list_via_extract_enum

pyo3-benches/benches/bench_frompyobject.rs::benches::criterion_benchmark

+2%

17.5 µs17.2 µs

extract_float_extract_fail

pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark

+1%

11.9 µs11.8 µs

tuple_into_pyobject

pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark

+1%

2.9 µs2.8 µs

ordered_dunder_methods

pyo3-benches/benches/bench_comparisons.rs::benches::criterion_benchmark

+1%

2.9 µs2.9 µs

extract_bigint_big_positive

pyo3-benches/benches/bench_bigint.rs::benches::criterion_benchmark

+1%

3.7 µs3.6 µs

first_time_init

pyo3-benches/benches/bench_pyclass.rs::benches::criterion_benchmark

+1%

40 µs39.7 µs

enum_from_pyobject

pyo3-benches/benches/bench_frompyobject.rs::benches::criterion_benchmark

+1%

24.3 µs24.2 µs

test_simple_args_rs

pytests/tests/test_pyfunctions.py

19.1 µs19 µs

identify_object_type

pyo3-benches/benches/bench_any.rs::benches::criterion_benchmark

15.6 µs15.6 µs

test_getter

pytests/tests/test_pyclasses.py

16.3 µs16.3 µs

test_none_rs

pytests/tests/test_pyfunctions.py

12.6 µs12.6 µs

extract_bigint_huge_positive

pyo3-benches/benches/bench_bigint.rs::benches::criterion_benchmark

11.6 µs11.6 µs

test_positional_only_py

pytests/tests/test_pyfunctions.py

13.5 µs13.5 µs

test_method_call_py

pytests/tests/test_pyclasses.py

13.8 µs13.8 µs

test_setter

pytests/tests/test_pyclasses.py

17 µs16.9 µs

test_class_method

pytests/tests/test_pyclasses.py

17.9 µs17.8 µs

test_simple_rs

pytests/tests/test_pyfunctions.py

18.3 µs18.2 µs

bytes_new_large

pyo3-benches/benches/bench_intopyobject.rs::benches::criterion_benchmark

176.8 µs176.7 µs

byte_slice_into_pyobject_large

pyo3-benches/benches/bench_intopyobject.rs::benches::criterion_benchmark

176.8 µs176.7 µs

extract_hashset

pyo3-benches/benches/bench_set.rs::benches::criterion_benchmark

20.7 ms20.7 ms

call_method_1

pyo3-benches/benches/bench_call.rs::benches::criterion_benchmark

657.6 µs657.4 µs

call

pyo3-benches/benches/bench_call.rs::benches::criterion_benchmark

609.7 µs609.6 µs

call_method

pyo3-benches/benches/bench_call.rs::benches::criterion_benchmark

1.3 ms1.3 ms

extract_btreemap

pyo3-benches/benches/bench_dict.rs::benches::criterion_benchmark

37.8 ms37.8 ms

tuple_get_borrowed_item_unchecked

pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark

3.4 ms3.4 ms

list_get_item_unchecked

pyo3-benches/benches/bench_list.rs::benches::criterion_benchmark

3.6 ms3.6 ms

test_with_typed_args_rs

pytests/tests/test_pyfunctions.py

17.5 µs17.5 µs

list_get_item

pyo3-benches/benches/bench_list.rs::benches::criterion_benchmark

4.2 ms4.2 ms

tuple_get_item_unchecked

pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark

3.6 ms3.6 ms

extract_btreeset

pyo3-benches/benches/bench_set.rs::benches::criterion_benchmark

15.9 ms15.9 ms

list_new

pyo3-benches/benches/bench_list.rs::benches::criterion_benchmark

6.7 ms6.7 ms

tuple_get_item

pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark

4.1 ms4.1 ms

test_empty_class_init_py

pytests/tests/test_pyclasses.py

13.9 µs13.9 µs

set_new

pyo3-benches/benches/bench_set.rs::benches::criterion_benchmark

15.2 ms15.2 ms

dict_get_item

pyo3-benches/benches/bench_dict.rs::benches::criterion_benchmark

16.6 ms16.6 ms

iter_tuple

pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark

5.9 ms5.9 ms

iter_list

pyo3-benches/benches/bench_list.rs::benches::criterion_benchmark

6.8 ms6.8 ms

iter_set

pyo3-benches/benches/bench_set.rs::benches::criterion_benchmark

10.7 ms10.7 ms

tuple_get_borrowed_item

pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark

3.9 ms3.9 ms

call_method_0

pyo3-benches/benches/bench_call.rs::benches::criterion_benchmark

608.3 µs608.3 µs

ordered_richcmp

pyo3-benches/benches/bench_comparisons.rs::benches::criterion_benchmark

2.7 µs2.7 µs

list_nth_back

pyo3-benches/benches/bench_list.rs::benches::criterion_benchmark

4.6 µs4.6 µs

list_nth

pyo3-benches/benches/bench_list.rs::benches::criterion_benchmark

4.5 µs4.5 µs

call_method_one_arg

pyo3-benches/benches/bench_call.rs::benches::criterion_benchmark

628.1 µs628.1 µs

drop_many_objects

pyo3-benches/benches/bench_pyobject.rs::benches::criterion_benchmark

11.3 µs11.3 µs

err_new_without_gil

pyo3-benches/benches/bench_err.rs::benches::criterion_benchmark

1.2 µs1.2 µs

collect_generic_iterator

pyo3-benches/benches/bench_any.rs::benches::criterion_benchmark

105.4 ms105.4 ms

iter_dict

pyo3-benches/benches/bench_dict.rs::benches::criterion_benchmark

11.5 ms11.5 ms

test_none_py

pytests/tests/test_pyfunctions.py

13.2 µs13.2 µs

extract_hashmap

pyo3-benches/benches/bench_dict.rs::benches::criterion_benchmark

20.7 ms20.7 ms

tuple_new

pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark

6.7 ms6.7 ms

call_1

pyo3-benches/benches/bench_call.rs::benches::criterion_benchmark

253.4 µs253.4 µs

call_0

pyo3-benches/benches/bench_call.rs::benches::criterion_benchmark

191.6 µs191.6 µs

test_proto_call_py

pytests/tests/test_pyclasses.py

14.3 µs14.3 µs

tuple_to_list

pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark

1.6 ms1.6 ms

tuple_new_list

pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark

2.1 ms2.1 ms

call_one_arg

pyo3-benches/benches/bench_call.rs::benches::criterion_benchmark

232.1 µs232.2 µs

extract_hashbrown_map

pyo3-benches/benches/bench_dict.rs::benches::criterion_benchmark

18 ms18 ms

dict_new

pyo3-benches/benches/bench_dict.rs::benches::criterion_benchmark

25.7 ms25.7 ms

extract_hashbrown_set

pyo3-benches/benches/bench_set.rs::benches::criterion_benchmark

16.1 ms16.1 ms

dirty_acquire_gil

pyo3-benches/benches/bench_gil.rs::benches::criterion_benchmark

5.2 µs5.2 µs

clean_acquire_gil

pyo3-benches/benches/bench_gil.rs::benches::criterion_benchmark

3.6 µs3.6 µs

drop_many_objects_without_gil

pyo3-benches/benches/bench_pyobject.rs::benches::criterion_benchmark

41.7 µs41.8 µs

test_simple_kwargs_rs

pytests/tests/test_pyfunctions.py

18.6 µs18.6 µs

test_static_method

pytests/tests/test_pyclasses.py

15.6 µs15.7 µs

test_empty_class_init

pytests/tests/test_pyclasses.py

22.5 µs22.5 µs

test_positional_only_rs

pytests/tests/test_pyfunctions.py

13.6 µs13.6 µs

test_simple_kwargs_py

pytests/tests/test_pyfunctions.py

20.2 µs20.3 µs

test_args_kwargs_rs

pytests/tests/test_pyfunctions.py

14.5 µs14.5 µs

test_args_kwargs_py

pytests/tests/test_pyfunctions.py

18.8 µs18.8 µs

test_proto_call

pytests/tests/test_pyclasses.py

13.3 µs13.3 µs

test_simple_args_kwargs_rs

pytests/tests/test_pyfunctions.py

19 µs19.1 µs

extract_bigint_huge_negative

pyo3-benches/benches/bench_bigint.rs::benches::criterion_benchmark

-1%

13.1 µs13.2 µs

test_simple_args_kwargs_py

pytests/tests/test_pyfunctions.py

-1%

20.5 µs20.6 µs

test_class_attribute

pytests/tests/test_pyclasses.py

-1%

14 µs14.1 µs

test_simple_args_py

pytests/tests/test_pyfunctions.py

-1%

17.8 µs17.9 µs

test_with_typed_args_py

pytests/tests/test_pyfunctions.py

-1%

13.4 µs13.5 µs

test_method_call

pytests/tests/test_pyclasses.py

-1%

14.8 µs14.9 µs

test_simple_py

pytests/tests/test_pyfunctions.py

-1%

17.2 µs17.4 µs

tuple_nth_back

pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark

-1%

4.2 µs4.3 µs

tuple_nth

pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark

-1%

4.1 µs4.2 µs

extract_bigint_big_negative

pyo3-benches/benches/bench_bigint.rs::benches::criterion_benchmark

-2%

3.9 µs4 µs

getattr_intern

pyo3-benches/benches/bench_intern.rs::benches::criterion_benchmark

-7%

3.1 µs3.3 µs

Ignored

list_via_extract

pyo3-benches/benches/bench_frompyobject.rs::benches::criterion_benchmark

Ignored

+14%

242.2 ns213.1 ns

list_via_cast

pyo3-benches/benches/bench_frompyobject.rs::benches::criterion_benchmark

Ignored

-16%

149.2 ns178.3 ns

not_a_list_via_extract

pyo3-benches/benches/bench_frompyobject.rs::benches::criterion_benchmark

Ignored

-2%

1.8 µs1.9 µs

not_a_list_via_cast

pyo3-benches/benches/bench_frompyobject.rs::benches::criterion_benchmark

Ignored

-14%

182.5 ns211.7 ns

byte_slice_into_pyobject_small

pyo3-benches/benches/bench_intopyobject.rs::benches::criterion_benchmark

Ignored

+9%

364.2 ns335 ns

getattr_direct

pyo3-benches/benches/bench_intern.rs::benches::criterion_benchmark

Ignored

-2%

6.4 µs6.5 µs

bytes_new_small

pyo3-benches/benches/bench_intopyobject.rs::benches::criterion_benchmark

Ignored

305.8 ns305.8 ns

sequence_from_list

pyo3-benches/benches/bench_list.rs::benches::criterion_benchmark

Ignored

241.1 ns241.1 ns

mapping_from_dict

pyo3-benches/benches/bench_dict.rs::benches::criterion_benchmark

Ignored

241.1 ns241.1 ns

sequence_from_tuple

pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark

Ignored

270.3 ns270.3 ns

extract_float_cast_success

pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark

Ignored

178.3 ns178.3 ns

extract_int_cast_success

pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark

Ignored

617.5 ns617.5 ns

extract_float_cast_fail

pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark

Ignored

-12%

424.7 ns483.1 ns

extract_int_extract_success

pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark

Ignored

-5%

523.9 ns553.1 ns

extract_float_extract_success

pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark

Ignored

305.3 ns305.3 ns

extract_int_cast_fail

pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark

Ignored

-12%

216.4 ns245.6 ns

extract_str_cast_fail

pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark

Ignored

-14%

182.5 ns211.7 ns

extract_str_extract_success

pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark

Ignored

+5%

579.2 ns550 ns

extract_str_cast_success

pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark

Ignored

+10%

642.5 ns584.2 ns

Commits

Click on a commit to change the comparison range

Base

main

12a1792

+0.08%

panic on attach if interpreter is shutting down

5e1c2a5

5 months ago

by davidhewitt

+0.09%

fixup for older versions

311f37c

5 months ago

by davidhewitt

-0.16%

fix clippy

96a0cde

5 months ago

by davidhewitt

+0.11%

Merge branch 'PyO3:main' into attach-panic-shutting-down

d4febfe

5 months ago

by davidhewitt

Home Terms Privacy Docs