Avatar for the MystenLabs user
MystenLabs
walrus-sites
BlogDocsChangelog

fix: a different isValidResponse should be used for each Sui client call

#360Merged
Comparing
alextzimas/sew-11-incorrect-error-page-when-accessing-non-existing-site
(
db6a482
) with
main
(
e7d0326
)
CodSpeed Performance Gauge
0%
Improvements
0
Regressions
0
Untouched
3
New
0
Dropped
0
Ignored
0

Benchmarks

Passed

decompress plaintext encoding
portal/common/lib/decompress_data.bench.ts::decompressData::decompress plaintext encoding
CodSpeed Performance Gauge
0%
16 µs
15.9 µs
decompress deflate encoding
portal/common/lib/decompress_data.bench.ts::decompressData::decompress deflate encoding
CodSpeed Performance Gauge
0%
248.6 µs
248 µs
decompress gzip encoding
portal/common/lib/decompress_data.bench.ts::decompressData::decompress gzip encoding
CodSpeed Performance Gauge
0%
254.6 µs
254.4 µs

Commits

Click on a commit to change the comparison range
Base
main
e7d0326
0%
fix: log resolved suins when resp not null WIP So far isValidResponse would check the responses for completely different calls. With this commit, I break it up into 3 distinct functions that each check the adequate responses. TODO - Refactor - Fix validity check for SuiNS response
1ada710
23 days ago
by Tzal3x
-1%
Fix isValidGetObjectResponse
3c2ee53
23 days ago
by Tzal3x
+1%
Minor fix in new Error
1c1c8d1
23 days ago
by Tzal3x
0%
Revert isValidSuiNSResponse - WIP - fix it
6b29295
23 days ago
by Tzal3x
0%
refactor(rpc-selector): check response validity inside the client calls
db6a482
21 days ago
by Tzal3x
Home Terms PrivacyDocs