nrc-bin-ascribe - Branch - KittyCAD/modeling-app

KittyCAD

modeling-app

Instrumentation

Wall Time

Blog Docs Changelog

Accept type ascription within binary expressions

#6849Merged

Comparing

nrc-bin-ascribe

(

4257467

) with

main

(

f36b69f

)

-11%

Regressions: 1

Untouched: 53

Benchmarks

Failed

parse_mathRegression

rust/kcl-lib/benches/compiler_benchmark_criterion.rs::benches::bench_parse::parse_math

-11%

14.4 ms16.2 ms

Passed

digest_pipes_on_pipes

rust/kcl-lib/benches/digest_benchmark.rs::benches::bench_digest::digest_pipes_on_pipes

19.6 ms19.6 ms

digest_lsystem

rust/kcl-lib/benches/digest_benchmark.rs::benches::bench_digest::digest_lsystem

1.9 ms1.9 ms

digest_big_kitt

rust/kcl-lib/benches/digest_benchmark.rs::benches::bench_digest::digest_big_kitt

6.5 ms6.5 ms

digest_mike_stress_test

rust/kcl-lib/benches/digest_benchmark.rs::benches::bench_digest::digest_mike_stress_test

20.9 ms20.9 ms

digest_math

rust/kcl-lib/benches/digest_benchmark.rs::benches::bench_digest::digest_math

1.2 ms1.2 ms

digest_cube

rust/kcl-lib/benches/digest_benchmark.rs::benches::bench_digest::digest_cube

-1%

418.5 µs420.7 µs

parse_axial-fan

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::axial-fan::parse_axial-fan

-5%

365.4 µs386.5 µs

parse_multi-axis-robot

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::multi-axis-robot::parse_multi-axis-robot

-5%

431.4 µs456.4 µs

parse_router-template-slate

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::router-template-slate::parse_router-template-slate

-7%

20.3 ms21.8 ms

parse_pipe

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::pipe::parse_pipe

-7%

2.5 ms2.7 ms

parse_bottle

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::bottle::parse_bottle

-7%

5.3 ms5.7 ms

parse_i-beam

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::i-beam::parse_i-beam

-7%

3 ms3.2 ms

parse_socket-head-cap-screw

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::socket-head-cap-screw::parse_socket-head-cap-screw

-7%

8.7 ms9.4 ms

parse_utility-sink

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::utility-sink::parse_utility-sink

-7%

124.6 ms134.3 ms

parse_flange

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::flange::parse_flange

-7%

7.6 ms8.2 ms

parse_color-cube

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::color-cube::parse_color-cube

-7%

16.9 ms18.2 ms

parse_hex-nut

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::hex-nut::parse_hex-nut

-7%

7.1 ms7.7 ms

parse_cube

rust/kcl-lib/benches/compiler_benchmark_criterion.rs::benches::bench_parse::parse_cube

-7%

5.4 ms5.9 ms

parse_gridfinity-baseplate

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::gridfinity-baseplate::parse_gridfinity-baseplate

-7%

125.8 ms135.7 ms

parse_80-20-rail

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::80-20-rail::parse_80-20-rail

-7%

50.7 ms54.7 ms

parse_car-wheel-assembly

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::car-wheel-assembly::parse_car-wheel-assembly

-7%

1.9 ms2.1 ms

parse_gridfinity-baseplate-magnets

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::gridfinity-baseplate-magnets::parse_gridfinity-baseplate-magnets

-7%

173.7 ms187.4 ms

parse_router-template-cross-bar

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::router-template-cross-bar::parse_router-template-cross-bar

-7%

30 ms32.3 ms

parse_walkie-talkie

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::walkie-talkie::parse_walkie-talkie

-7%

4.1 ms4.4 ms

parse_makeup-mirror

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::makeup-mirror::parse_makeup-mirror

-7%

35.1 ms37.9 ms

parse_bracket

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::bracket::parse_bracket

-7%

37.9 ms41 ms

parse_poopy-shoe

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::poopy-shoe::parse_poopy-shoe

-7%

36.4 ms39.3 ms

parse_kitt

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::kitt::parse_kitt

-7%

106.8 ms115.4 ms

parse_pipe-with-bend

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::pipe-with-bend::parse_pipe-with-bend

-7%

6.5 ms7 ms

parse_french-press

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::french-press::parse_french-press

-7%

64.5 ms69.7 ms

parse_sheet-metal-bracket

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::sheet-metal-bracket::parse_sheet-metal-bracket

-8%

21.3 ms23 ms

parse_washer

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::washer::parse_washer

-8%

4 ms4.3 ms

parse_pipe-flange-assembly

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::pipe-flange-assembly::parse_pipe-flange-assembly

-8%

7.8 ms8.5 ms

parse_gridfinity-bins

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::gridfinity-bins::parse_gridfinity-bins

-8%

153 ms165.6 ms

parse_gridfinity-bins-stacking-lip

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::gridfinity-bins-stacking-lip::parse_gridfinity-bins-stacking-lip

-8%

201.6 ms218.5 ms

parse_ball-bearing

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::ball-bearing::parse_ball-bearing

-8%

23.3 ms25.3 ms

parse_dodecahedron

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::dodecahedron::parse_dodecahedron

-8%

27.2 ms29.5 ms

parse_focusrite-scarlett-mounting-bracket

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::focusrite-scarlett-mounting-bracket::parse_focusrite-scarlett-mounting-bracket

-8%

42.4 ms46 ms

parse_keyboard

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::keyboard::parse_keyboard

-8%

111.2 ms120.8 ms

parse_mounting-plate

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::mounting-plate::parse_mounting-plate

-8%

23.2 ms25.2 ms

parse_gear-rack

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::gear-rack::parse_gear-rack

-8%

12.5 ms13.6 ms

parse_enclosure

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::enclosure::parse_enclosure

-8%

84.2 ms91.6 ms

parse_lego

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::lego::parse_lego

-8%

16.5 ms18 ms

parse_bench

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::bench::parse_bench

-8%

40.6 ms44.2 ms

parse_exhaust-manifold

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::exhaust-manifold::parse_exhaust-manifold

-8%

51.7 ms56.3 ms

parse_parametric-bearing-pillow-block

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::parametric-bearing-pillow-block::parse_parametric-bearing-pillow-block

-8%

10.8 ms11.8 ms

parse_cycloidal-gear

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::cycloidal-gear::parse_cycloidal-gear

-9%

32.9 ms36 ms

parse_big_kitt

rust/kcl-lib/benches/compiler_benchmark_criterion.rs::benches::bench_parse::parse_big_kitt

-9%

126.2 ms138.3 ms

parse_food-service-spatula

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::food-service-spatula::parse_food-service-spatula

-9%

108.8 ms119.2 ms

parse_mike_stress_test

rust/kcl-lib/benches/compiler_benchmark_criterion.rs::benches::bench_parse::parse_mike_stress_test

-9%

463.5 ms507.9 ms

parse_pipes_on_pipes

rust/kcl-lib/benches/compiler_benchmark_criterion.rs::benches::bench_parse::parse_pipes_on_pipes

-9%

372.8 ms409.9 ms

parse_gear

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::gear::parse_gear

-9%

74 ms81.6 ms

parse_koch snowflake

rust/kcl-lib/benches/compiler_benchmark_criterion.rs::benches::bench_parse::parse_koch snowflake

-9%

136.7 ms151 ms

Commits

Click on a commit to change the comparison range

Base

main

f36b69f

-10.88%

Accept type ascription within binary expressions Signed-off-by: Nick Cameron <nrc@ncameron.org>

4257467

4 months ago

by nrc

Home Terms Privacy Docs