jtran/fix-param-coercion - Branch - KittyCAD/modeling-app

Fix KCL function parameter unit conversion to work in ZDS

#8205Merged

Comparing

jtran/fix-param-coercion

(

14abfd0

) with

main

(

4503aa4

)

Untouched: 89

No successful run was found on main ( 4f4fa99) during the generation of this report, so 4503aa4 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

This report only contains results for the CPU Simulation instrument. To view results for the Wall Time instrument, click here.

Benchmarks

Passed

recast_medium_sketch

rust/kcl-lib/benches/compiler_benchmark_criterion.rs::benches::recast

+1%

174 µs172.2 µs

parse_i-beam

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::i-beam

1.9 ms1.9 ms

parse_t-slot-rail

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::t-slot-rail

7.7 ms7.6 ms

parse_prosthetic-hip

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::prosthetic-hip

24.6 ms24.6 ms

parse_router-template-cross-bar

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::router-template-cross-bar

12.8 ms12.8 ms

parse_spur-gear

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::spur-gear

5.6 ms5.6 ms

parse_gridfinity-baseplate-magnets

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::gridfinity-baseplate-magnets

26.2 ms26.2 ms

parse_cold-plate

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::cold-plate

10.8 ms10.8 ms

parse_nested function calls

rust/kcl-lib/benches/compiler_benchmark_criterion.rs::benches::bench_parse

11.9 ms11.9 ms

parse_hammer

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::hammer

45.4 ms45.4 ms

parse_wing-spar

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::wing-spar

23 ms23 ms

parse_french-press

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::french-press

30.2 ms30.2 ms

parse_engine-valve

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::engine-valve

14 ms14 ms

parse_utility-sink

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::utility-sink

42 ms42 ms

parse_router-template-slate

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::router-template-slate

8.9 ms8.9 ms

parse_pdu-faceplate

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::pdu-faceplate

23.7 ms23.6 ms

parse_color-cube

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::color-cube

6.3 ms6.3 ms

parse_lego

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::lego

10.9 ms10.9 ms

parse_shepherds-hook-bolt

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::shepherds-hook-bolt

13 ms13 ms

parse_socket-head-cap-screw

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::socket-head-cap-screw

4.7 ms4.7 ms

parse_truss-structure

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::truss-structure

20.5 ms20.4 ms

parse_surgical-drill-guide

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::surgical-drill-guide

32.3 ms32.3 ms

parse_ball-bearing

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::ball-bearing

10.4 ms10.4 ms

parse_tooling-nest-block

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::tooling-nest-block

14.8 ms14.8 ms

parse_curtain-wall-anchor-plate

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::curtain-wall-anchor-plate

25.6 ms25.6 ms

parse_mug

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::mug

10.8 ms10.8 ms

parse_exhaust-manifold

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::exhaust-manifold

20.8 ms20.8 ms

parse_countersunk-plate

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::countersunk-plate

5.8 ms5.8 ms

parse_kitt

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::kitt

45.5 ms45.5 ms

parse_helium-tank

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::helium-tank

26.1 ms26.1 ms

parse_bone-plate

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::bone-plate

9.9 ms9.9 ms

parse_bracket

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::bracket

11.3 ms11.3 ms

parse_food-service-spatula

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::food-service-spatula

28.6 ms28.6 ms

parse_sheet-metal-bracket

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::sheet-metal-bracket

11.9 ms11.9 ms

parse_spinning-highrise-tower

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::spinning-highrise-tower

13.1 ms13.1 ms

digest_mike_stress_test

rust/kcl-lib/benches/digest_benchmark.rs::benches::bench_digest

20.9 ms20.9 ms

parse_helical-planetary-gearset

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::helical-planetary-gearset

16.2 ms16.2 ms

parse_poopy-shoe

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::poopy-shoe

22 ms22 ms

parse_telemetry-antenna

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::telemetry-antenna

8.6 ms8.6 ms

parse_sash-window

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::sash-window

19.9 ms19.9 ms

mock_execute_medium_sketch

rust/kcl-lib/benches/compiler_benchmark_criterion.rs::benches::bench_mock_warmed_up

10.1 ms10.1 ms

parse_mounting-plate

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::mounting-plate

15.3 ms15.3 ms

parse_bottle

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::bottle

3.6 ms3.6 ms

parse_teapot

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::teapot

14.9 ms14.9 ms

parse_brake-rotor

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::brake-rotor

24.8 ms24.8 ms

parse_enclosure

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::enclosure

29.2 ms29.2 ms

parse_gridfinity-baseplate

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::gridfinity-baseplate

10.5 ms10.5 ms

parse_herringbone-planetary-gearset

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::herringbone-planetary-gearset

15.2 ms15.2 ms

parse_keyboard

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::keyboard

45.5 ms45.5 ms

parse_counterdrilled-weldment

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::counterdrilled-weldment

17.7 ms17.7 ms

parse_helical-gear

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::helical-gear

8.1 ms8.1 ms

digest_big_kitt

rust/kcl-lib/benches/digest_benchmark.rs::benches::bench_digest

6.5 ms6.5 ms

parse_pipe-with-bend

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::pipe-with-bend

2.4 ms2.4 ms

parse_gridfinity-bins-stacking-lip

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::gridfinity-bins-stacking-lip

39.4 ms39.4 ms

parse_cycloidal-gear

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::cycloidal-gear

6.2 ms6.2 ms

parse_flange

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::flange

4.8 ms4.8 ms

parse_gridfinity-bins

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::gridfinity-bins

21 ms21 ms

parse_makeup-mirror

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::makeup-mirror

11.8 ms11.8 ms

parse_cpu-cooler

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::cpu-cooler

3.3 ms3.3 ms

parse_herringbone-gear

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::herringbone-gear

6.9 ms6.9 ms

digest_pipes_on_pipes

rust/kcl-lib/benches/digest_benchmark.rs::benches::bench_digest

19.5 ms19.5 ms

parse_gear-rack

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::gear-rack

8.7 ms8.7 ms

parse_spur-reduction-gearset

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::spur-reduction-gearset

5 ms5 ms

parse_pipe

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::pipe

1.7 ms1.7 ms

parse_pipe-flange-assembly

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::pipe-flange-assembly

6.2 ms6.2 ms

parse_pipes_on_pipes

rust/kcl-lib/benches/compiler_benchmark_criterion.rs::benches::bench_parse

278.9 ms278.8 ms

parse_dodecahedron

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::dodecahedron

13.9 ms13.9 ms

parse_car-wheel-assembly

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::car-wheel-assembly

1.5 ms1.5 ms

parse_focusrite-scarlett-mounting-bracket

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::focusrite-scarlett-mounting-bracket

23.9 ms23.9 ms

parse_mike_stress_test

rust/kcl-lib/benches/compiler_benchmark_criterion.rs::benches::bench_parse

331.8 ms331.8 ms

parse_koch snowflake

rust/kcl-lib/benches/compiler_benchmark_criterion.rs::benches::bench_parse

19 ms19 ms

parse_big_kitt

rust/kcl-lib/benches/compiler_benchmark_criterion.rs::benches::bench_parse

88.4 ms88.5 ms

parse_spool

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::spool

7.9 ms7.9 ms

parse_thermal-block-insert

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::thermal-block-insert

5.1 ms5.1 ms

parse_axial-fan

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::axial-fan

318.5 µs318.6 µs

parse_clock

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::clock

109.4 ms109.4 ms

digest_lsystem

rust/kcl-lib/benches/digest_benchmark.rs::benches::bench_digest

2.2 ms2.2 ms

parse_bench

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::bench

4.6 ms4.6 ms

parse_multi-axis-robot

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::multi-axis-robot

371.7 µs371.8 µs

parse_hex-nut

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::hex-nut

4.1 ms4.1 ms

parse_walkie-talkie

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::walkie-talkie

3.2 ms3.2 ms

parse_cube

rust/kcl-lib/benches/compiler_benchmark_criterion.rs::benches::bench_parse

3.2 ms3.2 ms

digest_math

rust/kcl-lib/benches/digest_benchmark.rs::benches::bench_digest

1.2 ms1.2 ms

digest_cube

rust/kcl-lib/benches/digest_benchmark.rs::benches::bench_digest

421.8 µs422.2 µs

parse_washer

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::washer

1.8 ms1.8 ms

parse_math

rust/kcl-lib/benches/compiler_benchmark_criterion.rs::benches::bench_parse

10.3 ms10.3 ms

recast_mike_stress_test_program

rust/kcl-lib/benches/compiler_benchmark_criterion.rs::benches::recast

2.5 ms2.5 ms

parse_pillow-block-bearing

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::pillow-block-bearing

-1%

263.2 µs265.4 µs

mock_execute_mike_stress_test_program

rust/kcl-lib/benches/compiler_benchmark_criterion.rs::benches::bench_mock_warmed_up

-8%

301 ms328.9 ms

Commits

Click on a commit to change the comparison range

Base

main

4503aa4

-0.08%

Don't erase param types during serlialisation Signed-off-by: Nick Cameron <nrc@ncameron.org>

14abfd0

1 month ago

by nrc

Home Terms Privacy Docs