achalmers/mockexec - Branch - KittyCAD/modeling-app

KittyCAD

modeling-app

Instrumentation

Wall Time

Blog Docs Changelog

KCL: Preallocate space for all the paths

#7843

Comparing

achalmers/mockexec

(

2ad3436

) with

main

(

399dbaf

)

-14%

Improvements: 0

Regressions: 1

Untouched: 88

New: 0

Dropped: 0

Ignored: 0

No successful run was found on main ( 8723ce9) during the generation of this report, so 399dbaf was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Benchmarks

Failed

mock_execute_mike_stress_test_programRegression

rust/kcl-lib/benches/compiler_benchmark_criterion.rs::benches::bench_mock_warmed_up::mock_execute_mike_stress_test_program

-14%

289.5 ms

334.7 ms

Passed

mock_execute_medium_sketch

rust/kcl-lib/benches/compiler_benchmark_criterion.rs::benches::bench_mock_warmed_up::mock_execute_medium_sketch

9.8 ms

parse_multi-axis-robot

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::multi-axis-robot::parse_multi-axis-robot

502.2 µs

500.1 µs

parse_cube

rust/kcl-lib/benches/compiler_benchmark_criterion.rs::benches::bench_parse::parse_cube

10.2 ms

parse_big_kitt

rust/kcl-lib/benches/compiler_benchmark_criterion.rs::benches::bench_parse::parse_big_kitt

253.1 ms

252.7 ms

parse_pipes_on_pipes

rust/kcl-lib/benches/compiler_benchmark_criterion.rs::benches::bench_parse::parse_pipes_on_pipes

848 ms

846.8 ms

parse_koch snowflake

rust/kcl-lib/benches/compiler_benchmark_criterion.rs::benches::bench_parse::parse_koch snowflake

535.2 ms

534.6 ms

parse_car-wheel-assembly

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::car-wheel-assembly::parse_car-wheel-assembly

3.1 ms

parse_mike_stress_test

rust/kcl-lib/benches/compiler_benchmark_criterion.rs::benches::bench_parse::parse_mike_stress_test

955.9 ms

955.4 ms

parse_food-service-spatula

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::food-service-spatula::parse_food-service-spatula

810.1 ms

809.7 ms

parse_pillow-block-bearing

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::pillow-block-bearing::parse_pillow-block-bearing

329.6 µs

329.5 µs

parse_pipe-flange-assembly

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::pipe-flange-assembly::parse_pipe-flange-assembly

13 ms

parse_lego

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::lego::parse_lego

32.4 ms

parse_clock

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::clock::parse_clock

1.7 s

parse_axial-fan

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::axial-fan::parse_axial-fan

421.2 µs

421.1 µs

digest_cube

rust/kcl-lib/benches/digest_benchmark.rs::benches::bench_digest::digest_cube

422.7 µs

parse_gear-rack

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::gear-rack::parse_gear-rack

23.3 ms

parse_cpu-cooler

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::cpu-cooler::parse_cpu-cooler

9.3 ms

digest_lsystem

rust/kcl-lib/benches/digest_benchmark.rs::benches::bench_digest::digest_lsystem

2.2 ms

parse_bone-plate

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::bone-plate::parse_bone-plate

46.3 ms

parse_focusrite-scarlett-mounting-bracket

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::focusrite-scarlett-mounting-bracket::parse_focusrite-scarlett-mounting-bracket

107 ms

digest_pipes_on_pipes

rust/kcl-lib/benches/digest_benchmark.rs::benches::bench_digest::digest_pipes_on_pipes

19.5 ms

digest_big_kitt

rust/kcl-lib/benches/digest_benchmark.rs::benches::bench_digest::digest_big_kitt

6.5 ms

digest_mike_stress_test

rust/kcl-lib/benches/digest_benchmark.rs::benches::bench_digest::digest_mike_stress_test

20.8 ms

digest_math

rust/kcl-lib/benches/digest_benchmark.rs::benches::bench_digest::digest_math

1.2 ms

parse_dodecahedron

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::dodecahedron::parse_dodecahedron

85.9 ms

parse_poopy-shoe

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::poopy-shoe::parse_poopy-shoe

87.2 ms

parse_walkie-talkie

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::walkie-talkie::parse_walkie-talkie

5.2 ms

parse_i-beam

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::i-beam::parse_i-beam

4 ms

parse_hex-nut

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::hex-nut::parse_hex-nut

19.4 ms

parse_ball-bearing

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::ball-bearing::parse_ball-bearing

37.5 ms

parse_flange

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::flange::parse_flange

11.3 ms

parse_french-press

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::french-press::parse_french-press

119.7 ms

parse_spool

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::spool::parse_spool

23.2 ms

parse_bottle

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::bottle::parse_bottle

8.6 ms

parse_teapot

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::teapot::parse_teapot

45.6 ms

parse_washer

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::washer::parse_washer

6.4 ms

parse_exhaust-manifold

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::exhaust-manifold::parse_exhaust-manifold

117.9 ms

parse_wing-spar

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::wing-spar::parse_wing-spar

87.9 ms

88 ms

parse_t-slot-rail

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::t-slot-rail::parse_t-slot-rail

29.2 ms

parse_countersunk-plate

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::countersunk-plate::parse_countersunk-plate

19.7 ms

parse_pdu-faceplate

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::pdu-faceplate::parse_pdu-faceplate

85.9 ms

parse_spur-reduction-gearset

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::spur-reduction-gearset::parse_spur-reduction-gearset

16.3 ms

parse_mug

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::mug::parse_mug

27.4 ms

parse_counterdrilled-weldment

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::counterdrilled-weldment::parse_counterdrilled-weldment

88.7 ms

parse_enclosure

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::enclosure::parse_enclosure

199.5 ms

199.6 ms

parse_spinning-highrise-tower

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::spinning-highrise-tower::parse_spinning-highrise-tower

50.2 ms

parse_helium-tank

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::helium-tank::parse_helium-tank

192.1 ms

192.2 ms

parse_keyboard

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::keyboard::parse_keyboard

233 ms

233.1 ms

parse_telemetry-antenna

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::telemetry-antenna::parse_telemetry-antenna

54.2 ms

parse_pipe

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::pipe::parse_pipe

3.8 ms

parse_cycloidal-gear

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::cycloidal-gear::parse_cycloidal-gear

73.4 ms

parse_gridfinity-bins-stacking-lip

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::gridfinity-bins-stacking-lip::parse_gridfinity-bins-stacking-lip

337.5 ms

337.6 ms

parse_sash-window

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::sash-window::parse_sash-window

87.2 ms

87.3 ms

parse_router-template-slate

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::router-template-slate::parse_router-template-slate

34.4 ms

parse_thermal-block-insert

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::thermal-block-insert::parse_thermal-block-insert

17.9 ms

parse_router-template-cross-bar

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::router-template-cross-bar::parse_router-template-cross-bar

48.7 ms

parse_bench

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::bench::parse_bench

52.1 ms

parse_spur-gear

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::spur-gear::parse_spur-gear

18 ms

parse_truss-structure

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::truss-structure::parse_truss-structure

78.4 ms

parse_sheet-metal-bracket

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::sheet-metal-bracket::parse_sheet-metal-bracket

35.2 ms

parse_cold-plate

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::cold-plate::parse_cold-plate

40.1 ms

parse_utility-sink

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::utility-sink::parse_utility-sink

200.4 ms

200.5 ms

parse_math

rust/kcl-lib/benches/compiler_benchmark_criterion.rs::benches::bench_parse::parse_math

34.1 ms

parse_kitt

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::kitt::parse_kitt

159 ms

159.1 ms

parse_prosthetic-hip

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::prosthetic-hip::parse_prosthetic-hip

146.9 ms

147 ms

parse_makeup-mirror

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::makeup-mirror::parse_makeup-mirror

50.1 ms

parse_gridfinity-bins

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::gridfinity-bins::parse_gridfinity-bins

221.1 ms

221.3 ms

parse_engine-valve

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::engine-valve::parse_engine-valve

69.1 ms

parse_color-cube

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::color-cube::parse_color-cube

24.1 ms

parse_herringbone-gear

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::herringbone-gear::parse_herringbone-gear

36.1 ms

parse_herringbone-planetary-gearset

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::herringbone-planetary-gearset::parse_herringbone-planetary-gearset

76.7 ms

76.8 ms

parse_curtain-wall-anchor-plate

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::curtain-wall-anchor-plate::parse_curtain-wall-anchor-plate

171.1 ms

171.3 ms

parse_socket-head-cap-screw

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::socket-head-cap-screw::parse_socket-head-cap-screw

14.8 ms

parse_ball-joint-rod-end

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::ball-joint-rod-end::parse_ball-joint-rod-end

170 ms

170.1 ms

parse_shepherds-hook-bolt

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::shepherds-hook-bolt::parse_shepherds-hook-bolt

77.6 ms

parse_pipe-with-bend

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::pipe-with-bend::parse_pipe-with-bend

10.9 ms

parse_brake-rotor

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::brake-rotor::parse_brake-rotor

157.6 ms

157.7 ms

parse_helical-planetary-gearset

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::helical-planetary-gearset::parse_helical-planetary-gearset

79.9 ms

80 ms

parse_surgical-drill-guide

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::surgical-drill-guide::parse_surgical-drill-guide

293.1 ms

293.3 ms

parse_tooling-nest-block

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::tooling-nest-block::parse_tooling-nest-block

77.6 ms

77.7 ms

parse_mounting-plate

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::mounting-plate::parse_mounting-plate

126.7 ms

126.8 ms

parse_helical-gear

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::helical-gear::parse_helical-gear

39.2 ms

parse_gridfinity-baseplate

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::gridfinity-baseplate::parse_gridfinity-baseplate

168 ms

168.1 ms

parse_bracket

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::bracket::parse_bracket

76.2 ms

76.3 ms

parse_gridfinity-baseplate-magnets

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::gridfinity-baseplate-magnets::parse_gridfinity-baseplate-magnets

298.3 ms

298.6 ms

parse_hammer

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::hammer::parse_hammer

7.4 s

recast_medium_sketch

rust/kcl-lib/benches/compiler_benchmark_criterion.rs::benches::recast::recast_medium_sketch

688.1 µs

689.3 µs

recast_mike_stress_test_program

rust/kcl-lib/benches/compiler_benchmark_criterion.rs::benches::recast::recast_mike_stress_test_program

12.6 ms

Commits

Click on a commit to change the comparison range

Base

main

399dbaf

-14%

KCL: Preallocate space for all the paths If you sketch a 100-sided shape, Rust will append 100 path segments to the underlying sketch. Unfortunately because the vector which stores the paths starts at capacity 0, this could cause quite a lot of allocations. As an optimization, we will instead preallocate space for N paths, where N is the number of steps in the |> pipeline. This will hopefully reduce allocations.

2ad3436

25 days ago

by adamchalmers

Home Terms Privacy Docs