achalmers/faster-array-recast - Branch - KittyCAD/modeling-app

KittyCAD

modeling-app

Instrumentation

Wall Time

Blog Docs Changelog

KCL: Avoid recasting array items twice

#7876

Comparing

achalmers/faster-array-recast

(

b9aa82d

) with

main

(

d8a4ac7

)

+16%

Improvements: 3

Regressions: 0

Untouched: 86

New: 0

Dropped: 0

Ignored: 0

Benchmarks

Improved

mock_execute_mike_stress_test_program

rust/kcl-lib/benches/compiler_benchmark_criterion.rs::benches::bench_mock_warmed_up::mock_execute_mike_stress_test_program

+16%

316.5 ms

273.6 ms

recast_medium_sketch

rust/kcl-lib/benches/compiler_benchmark_criterion.rs::benches::recast::recast_medium_sketch

+11%

178.5 µs

160.4 µs

recast_mike_stress_test_program

rust/kcl-lib/benches/compiler_benchmark_criterion.rs::benches::recast::recast_mike_stress_test_program

+11%

2.6 ms

2.4 ms

Passed

parse_pillow-block-bearing

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::pillow-block-bearing::parse_pillow-block-bearing

+1%

325.5 µs

322.3 µs

parse_food-service-spatula

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::food-service-spatula::parse_food-service-spatula

760.6 ms

758.7 ms

parse_hex-nut

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::hex-nut::parse_hex-nut

18.7 ms

18.6 ms

parse_washer

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::washer::parse_washer

6.2 ms

parse_pipe-with-bend

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::pipe-with-bend::parse_pipe-with-bend

10.5 ms

parse_pipe

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::pipe::parse_pipe

3.7 ms

parse_dodecahedron

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::dodecahedron::parse_dodecahedron

82.3 ms

82.1 ms

parse_car-wheel-assembly

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::car-wheel-assembly::parse_car-wheel-assembly

3 ms

parse_i-beam

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::i-beam::parse_i-beam

3.9 ms

parse_helium-tank

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::helium-tank::parse_helium-tank

185 ms

184.7 ms

parse_flange

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::flange::parse_flange

10.9 ms

parse_hammer

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::hammer::parse_hammer

7.2 s

7.1 s

parse_multi-axis-robot

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::multi-axis-robot::parse_multi-axis-robot

488.6 µs

487.7 µs

parse_brake-rotor

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::brake-rotor::parse_brake-rotor

152.1 ms

151.8 ms

parse_gridfinity-baseplate

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::gridfinity-baseplate::parse_gridfinity-baseplate

162.9 ms

162.6 ms

parse_surgical-drill-guide

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::surgical-drill-guide::parse_surgical-drill-guide

283 ms

282.6 ms

parse_bone-plate

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::bone-plate::parse_bone-plate

44.8 ms

44.7 ms

parse_clock

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::clock::parse_clock

1.6 s

parse_gridfinity-bins

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::gridfinity-bins::parse_gridfinity-bins

213.3 ms

213 ms

parse_spur-reduction-gearset

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::spur-reduction-gearset::parse_spur-reduction-gearset

15.8 ms

15.7 ms

parse_cpu-cooler

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::cpu-cooler::parse_cpu-cooler

9 ms

parse_exhaust-manifold

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::exhaust-manifold::parse_exhaust-manifold

113 ms

112.8 ms

parse_engine-valve

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::engine-valve::parse_engine-valve

66.7 ms

66.6 ms

parse_makeup-mirror

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::makeup-mirror::parse_makeup-mirror

48.5 ms

48.4 ms

parse_herringbone-planetary-gearset

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::herringbone-planetary-gearset::parse_herringbone-planetary-gearset

74 ms

73.9 ms

parse_herringbone-gear

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::herringbone-gear::parse_herringbone-gear

34.8 ms

34.7 ms

parse_helical-planetary-gearset

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::helical-planetary-gearset::parse_helical-planetary-gearset

77.1 ms

76.9 ms

parse_tooling-nest-block

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::tooling-nest-block::parse_tooling-nest-block

75.1 ms

75 ms

parse_bottle

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::bottle::parse_bottle

8.3 ms

parse_gridfinity-bins-stacking-lip

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::gridfinity-bins-stacking-lip::parse_gridfinity-bins-stacking-lip

323.7 ms

323.2 ms

parse_french-press

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::french-press::parse_french-press

116.4 ms

116.2 ms

parse_kitt

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::kitt::parse_kitt

153.8 ms

153.6 ms

parse_utility-sink

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::utility-sink::parse_utility-sink

195.1 ms

194.8 ms

parse_wing-spar

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::wing-spar::parse_wing-spar

85.4 ms

85.3 ms

parse_keyboard

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::keyboard::parse_keyboard

224.1 ms

223.8 ms

parse_socket-head-cap-screw

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::socket-head-cap-screw::parse_socket-head-cap-screw

14.3 ms

parse_helical-gear

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::helical-gear::parse_helical-gear

37.8 ms

37.7 ms

parse_prosthetic-hip

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::prosthetic-hip::parse_prosthetic-hip

142.2 ms

142 ms

parse_truss-structure

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::truss-structure::parse_truss-structure

75.9 ms

75.8 ms

parse_ball-joint-rod-end

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::ball-joint-rod-end::parse_ball-joint-rod-end

164.7 ms

164.5 ms

parse_countersunk-plate

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::countersunk-plate::parse_countersunk-plate

19.1 ms

parse_color-cube

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::color-cube::parse_color-cube

23.3 ms

parse_ball-bearing

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::ball-bearing::parse_ball-bearing

36.1 ms

parse_t-slot-rail

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::t-slot-rail::parse_t-slot-rail

28.3 ms

28.2 ms

parse_shepherds-hook-bolt

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::shepherds-hook-bolt::parse_shepherds-hook-bolt

75 ms

74.9 ms

parse_bracket

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::bracket::parse_bracket

73.2 ms

73.1 ms

parse_cycloidal-gear

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::cycloidal-gear::parse_cycloidal-gear

70 ms

69.9 ms

parse_sheet-metal-bracket

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::sheet-metal-bracket::parse_sheet-metal-bracket

34.2 ms

parse_teapot

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::teapot::parse_teapot

44.2 ms

44.1 ms

parse_pipe-flange-assembly

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::pipe-flange-assembly::parse_pipe-flange-assembly

12.5 ms

parse_curtain-wall-anchor-plate

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::curtain-wall-anchor-plate::parse_curtain-wall-anchor-plate

165.6 ms

165.3 ms

parse_gear-rack

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::gear-rack::parse_gear-rack

22.5 ms

parse_poopy-shoe

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::poopy-shoe::parse_poopy-shoe

83.6 ms

83.5 ms

parse_mounting-plate

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::mounting-plate::parse_mounting-plate

122.2 ms

122 ms

parse_router-template-cross-bar

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::router-template-cross-bar::parse_router-template-cross-bar

47.6 ms

47.5 ms

parse_focusrite-scarlett-mounting-bracket

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::focusrite-scarlett-mounting-bracket::parse_focusrite-scarlett-mounting-bracket

102.2 ms

102.1 ms

parse_mike_stress_test

rust/kcl-lib/benches/compiler_benchmark_criterion.rs::benches::bench_parse::parse_mike_stress_test

922.4 ms

921.2 ms

parse_bench

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::bench::parse_bench

50 ms

parse_sash-window

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::sash-window::parse_sash-window

84.6 ms

84.5 ms

parse_spinning-highrise-tower

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::spinning-highrise-tower::parse_spinning-highrise-tower

48.7 ms

parse_cold-plate

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::cold-plate::parse_cold-plate

38.9 ms

38.8 ms

parse_enclosure

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::enclosure::parse_enclosure

190.7 ms

190.4 ms

parse_spool

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::spool::parse_spool

22.4 ms

parse_mug

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::mug::parse_mug

26.5 ms

parse_walkie-talkie

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::walkie-talkie::parse_walkie-talkie

5.1 ms

parse_thermal-block-insert

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::thermal-block-insert::parse_thermal-block-insert

17.3 ms

parse_counterdrilled-weldment

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::counterdrilled-weldment::parse_counterdrilled-weldment

85.5 ms

85.4 ms

parse_pdu-faceplate

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::pdu-faceplate::parse_pdu-faceplate

83.4 ms

parse_spur-gear

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::spur-gear::parse_spur-gear

17.4 ms

parse_router-template-slate

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::router-template-slate::parse_router-template-slate

33.4 ms

parse_lego

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::lego::parse_lego

30.6 ms

parse_gridfinity-baseplate-magnets

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::gridfinity-baseplate-magnets::parse_gridfinity-baseplate-magnets

287.1 ms

286.9 ms

parse_telemetry-antenna

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::telemetry-antenna::parse_telemetry-antenna

52 ms

51.9 ms

mock_execute_medium_sketch

rust/kcl-lib/benches/compiler_benchmark_criterion.rs::benches::bench_mock_warmed_up::mock_execute_medium_sketch

9.8 ms

parse_pipes_on_pipes

rust/kcl-lib/benches/compiler_benchmark_criterion.rs::benches::bench_parse::parse_pipes_on_pipes

813.1 ms

812.5 ms

parse_cube

rust/kcl-lib/benches/compiler_benchmark_criterion.rs::benches::bench_parse::parse_cube

9.8 ms

parse_big_kitt

rust/kcl-lib/benches/compiler_benchmark_criterion.rs::benches::bench_parse::parse_big_kitt

244.2 ms

244.1 ms

digest_math

rust/kcl-lib/benches/digest_benchmark.rs::benches::bench_digest::digest_math

1.2 ms

digest_lsystem

rust/kcl-lib/benches/digest_benchmark.rs::benches::bench_digest::digest_lsystem

2.2 ms

digest_pipes_on_pipes

rust/kcl-lib/benches/digest_benchmark.rs::benches::bench_digest::digest_pipes_on_pipes

19.5 ms

digest_cube

rust/kcl-lib/benches/digest_benchmark.rs::benches::bench_digest::digest_cube

423.3 µs

423.4 µs

digest_big_kitt

rust/kcl-lib/benches/digest_benchmark.rs::benches::bench_digest::digest_big_kitt

6.5 ms

digest_mike_stress_test

rust/kcl-lib/benches/digest_benchmark.rs::benches::bench_digest::digest_mike_stress_test

20.9 ms

parse_koch snowflake

rust/kcl-lib/benches/compiler_benchmark_criterion.rs::benches::bench_parse::parse_koch snowflake

510.5 ms

510.8 ms

parse_axial-fan

rust/kcl-lib/benches/benchmark_kcl_samples.rs::benches::run_benchmarks::axial-fan::parse_axial-fan

411.5 µs

412.5 µs

parse_math

rust/kcl-lib/benches/compiler_benchmark_criterion.rs::benches::bench_parse::parse_math

32.3 ms

32.4 ms

Commits

Click on a commit to change the comparison range

Base

main

d8a4ac7

+16%

KCL: Faster recasting of arrays Before this PR, array expression recasting was a bit slow. The reason was that there's two ways to recast an array: - Single line array string (all items on one line) - Multi-line array string (n lines, one per item) The steps were basically: 1. Recast each item, collecting into a vec with n strings (one string per item) 2. Concat the items into a single-line array string 3. If the line is too long, discard it and do a multi-line array string. Giving each item its own string meant we were doing N allocations (one per item) but it meant that each item was only recast once. This PR has a better approach. We build a single-line array first, and if it's too long, then ignore it and do a multi-line array. HOWEVER, the difference is that we track each item's offset within the single-line array string. If we then need to convert it into a multi-line array string, we can do that easily by looking up each item's offset. Improves benchmarks by 7% and 20% on my macbook pro.

b9aa82d

22 days ago

by adamchalmers

Home Terms Privacy Docs