vaivaswatha/unit_ret_skip - Branch - FuelLabs/sway

Skip returning a value when the type is unit

#7401Merged

Comparing

vaivaswatha/unit_ret_skip

(

30bc3da

) with

master

(

ec6f0ca

)

Untouched: 25

Benchmarks

Passed

format

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::format

+3%

466.3 ms452.1 ms

traverse

sway-lsp/benches/lsp_benchmarks/compile.rs::benches::benchmarks::traverse

+2%

114.4 ms112.4 ms

token_at_position

sway-lsp/benches/lsp_benchmarks/token_map.rs::benches::benchmarks::token_at_position

1.5 ms1.5 ms

build_std_lib_docs

forc-plugins/forc-doc/benches/bench_main.rs::benches::benchmarks::build_std_lib_docs

309.7 ms309 ms

hover

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::hover

1.6 ms1.6 ms

find_all_references

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::find_all_references

5 ms5 ms

code_action

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::code_action

5 ms5 ms

rename

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::rename

5 ms5 ms

highlight

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::highlight

5.4 ms5.4 ms

goto_definition

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::goto_definition

1.5 ms1.5 ms

prepare_rename

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::prepare_rename

1.5 ms1.5 ms

inlay_hints

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::inlay_hints

1.9 ms1.9 ms

on_enter

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::on_enter

124.8 µs124.7 µs

parent_decl_at_position

sway-lsp/benches/lsp_benchmarks/token_map.rs::benches::benchmarks::parent_decl_at_position

2.8 ms2.8 ms

tokens_at_position

sway-lsp/benches/lsp_benchmarks/token_map.rs::benches::benchmarks::tokens_at_position

2.8 ms2.8 ms

compile

sway-lsp/benches/lsp_benchmarks/compile.rs::benches::benchmarks::compile

5.6 s5.6 s

code_lens

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::code_lens

4.9 µs4.9 µs

completion

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::completion

4.8 ms4.8 ms

tokens_for_file

sway-lsp/benches/lsp_benchmarks/token_map.rs::benches::benchmarks::tokens_for_file

1.4 ms1.4 ms

idents_at_position

sway-lsp/benches/lsp_benchmarks/token_map.rs::benches::benchmarks::idents_at_position

468.8 µs468.9 µs

document_symbol

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::document_symbol

2.8 ms2.8 ms

did_change_with_caching

sway-lsp/benches/lsp_benchmarks/compile.rs::benches::benchmarks::did_change_with_caching

3.8 ms3.8 ms

open_all_example_workspace_members

sway-lsp/benches/lsp_benchmarks/compile.rs::benches::benchmarks::open_all_example_workspace_members

9.9 s9.9 s

tokens_for_program

sway-lsp/benches/lsp_benchmarks/token_map.rs::benches::benchmarks::tokens_for_program

525.9 µs527.8 µs

semantic_tokens

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::semantic_tokens

-1%

2.8 ms2.9 ms

Commits

Click on a commit to change the comparison range

Base

master

ec6f0ca

Skip returning a value when the type is unit

472854a

9 days ago

by vaivaswatha

+0.2%

take care of use of returned unit value

8e78d47

9 days ago

by vaivaswatha

-0.03%

Merge branch 'master' into vaivaswatha/unit_ret_skip

d46bdcb

9 days ago

by vaivaswatha

+0.07%

fix typo

d659df0

9 days ago

by vaivaswatha

-0.01%

Merge branch 'master' into vaivaswatha/unit_ret_skip

168c342

8 days ago

by vaivaswatha

+0.11%

another test update

fda8fe0

8 days ago

by vaivaswatha

-0.15%

another test update

ea8a754

8 days ago

by vaivaswatha

-0.08%

address review comments

e346be3

8 days ago

by vaivaswatha

+0.01%

Merge branch 'vaivaswatha/unit_ret_skip' of github.com:FuelLabs/sway into vaivaswatha/unit_ret_skip

ba24299

8 days ago

by vaivaswatha

+0.06%

Merge branch 'master' into vaivaswatha/unit_ret_skip

30bc3da

8 days ago

by vaivaswatha

Home Terms Privacy Docs