Comparing
tritao:fix-trait-constraint-type-check-order
(805bc3d
) withmaster
(f46a2dc
)0%
- Improvements
- 0
- Regressions
- 0
- Untouched
- 22
- New
- 0
- Dropped
- 0
- Ignored
- 0
Benchmarks
Passed
format
sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::format+1%
471.1 ms
465.9 ms
did_change_with_caching
sway-lsp/benches/lsp_benchmarks/compile.rs::benches::benchmarks::did_change_with_caching+1%
524.9 ms
521.6 ms
semantic_tokens
sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::semantic_tokens+1%
3.2 ms
3.2 ms
goto_definition
sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::goto_definition0%
1.7 ms
1.7 ms
traverse
sway-lsp/benches/lsp_benchmarks/compile.rs::benches::benchmarks::traverse0%
229.2 ms
228.8 ms
token_at_position
sway-lsp/benches/lsp_benchmarks/token_map.rs::benches::benchmarks::token_at_position0%
1.7 ms
1.7 ms
highlight
sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::highlight0%
44.6 ms
44.6 ms
rename
sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::rename0%
47.2 ms
47.1 ms
find_all_references
sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::find_all_references0%
47.1 ms
47.1 ms
completion
sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::completion0%
20.9 ms
20.9 ms
compile
sway-lsp/benches/lsp_benchmarks/compile.rs::benches::benchmarks::compile0%
4.9 s
4.9 s
parent_decl_at_position
sway-lsp/benches/lsp_benchmarks/token_map.rs::benches::benchmarks::parent_decl_at_position0%
18.7 ms
18.7 ms
tokens_at_position
sway-lsp/benches/lsp_benchmarks/token_map.rs::benches::benchmarks::tokens_at_position0%
18.7 ms
18.7 ms
inlay_hints
sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::inlay_hints0%
18.6 ms
18.6 ms
code_action
sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::code_action0%
28.1 ms
28.1 ms
on_enter
sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::on_enter0%
125.8 µs
126 µs
prepare_rename
sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::prepare_rename0%
1.7 ms
1.7 ms
hover
sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::hover0%
3.5 ms
3.5 ms
idents_at_position
sway-lsp/benches/lsp_benchmarks/token_map.rs::benches::benchmarks::idents_at_position0%
485.3 µs
486 µs
document_symbol
sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::document_symbol0%
18.9 ms
19 ms
tokens_for_file
sway-lsp/benches/lsp_benchmarks/token_map.rs::benches::benchmarks::tokens_for_file0%
1.7 ms
1.7 ms
code_lens
sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::code_lens-2%
5.4 µs
5.5 µs
Commits
Click on a commit to change the comparison rangeBase
master
f46a2dc
0%
Fix trait constraint type checking order.
This fixes a stack overflow caused by interaction between type checking
order for trait constraits for supertraits.
```
trait MyTrait {
fn f(self) -> bool;
} {
fn f2(self) -> bool {
self.f()
}
}
trait MyTrait2: MyTrait {
}
impl<T1> MyTrait for (T1,)
where
T1: MyTrait2,
{
fn f(self) -> bool { self.0.f() }
}
fn main() -> bool {
true
}
```
0a26815
3 months ago
by tritao-20%
Merge branch 'master' into fix-trait-constraint-type-check-order
28a1ff2
3 months ago
by JoshuaBatty+20%
Merge branch 'master' into fix-trait-constraint-type-check-order
805bc3d
2 months ago
by tritao