tritao:fix-import-broken - Branch - FuelLabs/sway

Import indirect trait impls when handling item use statements.

#7347Merged

Comparing

tritao:fix-import-broken

(

070e779

) with

master

(

65d6520

)

Untouched: 25

Benchmarks

Passed

code_lens

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::code_lens

+1%

4.9 µs4.8 µs

tokens_for_program

sway-lsp/benches/lsp_benchmarks/token_map.rs::benches::benchmarks::tokens_for_program

+1%

528.3 µs523.5 µs

traverse

sway-lsp/benches/lsp_benchmarks/compile.rs::benches::benchmarks::traverse

+1%

114.4 ms113.6 ms

format

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::format

+1%

471.3 ms468.7 ms

build_std_lib_docs

forc-plugins/forc-doc/benches/bench_main.rs::benches::benchmarks::build_std_lib_docs

301.5 ms300.2 ms

parent_decl_at_position

sway-lsp/benches/lsp_benchmarks/token_map.rs::benches::benchmarks::parent_decl_at_position

2.8 ms2.8 ms

tokens_at_position

sway-lsp/benches/lsp_benchmarks/token_map.rs::benches::benchmarks::tokens_at_position

2.8 ms2.8 ms

hover

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::hover

1.6 ms1.6 ms

token_at_position

sway-lsp/benches/lsp_benchmarks/token_map.rs::benches::benchmarks::token_at_position

1.5 ms1.5 ms

highlight

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::highlight

5.4 ms5.4 ms

rename

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::rename

5 ms5 ms

find_all_references

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::find_all_references

5 ms5 ms

code_action

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::code_action

5 ms5 ms

idents_at_position

sway-lsp/benches/lsp_benchmarks/token_map.rs::benches::benchmarks::idents_at_position

468.7 µs468.5 µs

goto_definition

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::goto_definition

1.5 ms1.5 ms

completion

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::completion

4.9 ms4.9 ms

inlay_hints

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::inlay_hints

1.9 ms1.9 ms

document_symbol

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::document_symbol

2.8 ms2.8 ms

did_change_with_caching

sway-lsp/benches/lsp_benchmarks/compile.rs::benches::benchmarks::did_change_with_caching

3.8 ms3.8 ms

tokens_for_file

sway-lsp/benches/lsp_benchmarks/token_map.rs::benches::benchmarks::tokens_for_file

1.4 ms1.4 ms

semantic_tokens

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::semantic_tokens

2.8 ms2.8 ms

on_enter

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::on_enter

-1%

124.4 µs125.2 µs

prepare_rename

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::prepare_rename

-1%

1.5 ms1.5 ms

open_all_example_workspace_members

sway-lsp/benches/lsp_benchmarks/compile.rs::benches::benchmarks::open_all_example_workspace_members

-1%

9.7 s9.8 s

compile

sway-lsp/benches/lsp_benchmarks/compile.rs::benches::benchmarks::compile

-1%

5.4 s5.5 s

Commits

Click on a commit to change the comparison range

Base

master

65d6520

-0.02%

Import indirect trait impls when handling item use statements. This updates `TraitMap::filter_by_type_item_import` to scan the trait map for indirect trait impls with generic types matching any of imported item types. This makes sure cases like an impl of a `StorageKey<T>` work, when importing T from a given scope. Fixes https://github.com/FuelLabs/sway/issues/7330

070e779

29 days ago

by tritao

Home Terms Privacy Docs