josh/panic_on_save - Branch - FuelLabs/sway

fix OOB slab panic when creating runnables on a did_save event

#6575Merged

Comparing

josh/panic_on_save

(

8cc5062

) with

master

(

28c8ae4

)

-18%

Regressions: 1

Untouched: 21

Benchmarks

Failed

document_symbol

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks

Regression

-18%

4.4 ms5.4 ms

Passed

format

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks

+1%

380.7 ms378.6 ms

traverse

sway-lsp/benches/lsp_benchmarks/compile.rs::benches::benchmarks

223.9 ms223.4 ms

goto_definition

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks

1.6 ms1.6 ms

did_change_with_caching

sway-lsp/benches/lsp_benchmarks/compile.rs::benches::benchmarks

503.8 ms503.3 ms

prepare_rename

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks

1.6 ms1.6 ms

compile

sway-lsp/benches/lsp_benchmarks/compile.rs::benches::benchmarks

5.7 s5.7 s

completion

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks

23 ms23 ms

parent_decl_at_position

sway-lsp/benches/lsp_benchmarks/token_map.rs::benches::benchmarks

18.7 ms18.7 ms

highlight

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks

44 ms44 ms

code_lens

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks

6 µs6 µs

idents_at_position

sway-lsp/benches/lsp_benchmarks/token_map.rs::benches::benchmarks

459.9 µs459.9 µs

tokens_at_position

sway-lsp/benches/lsp_benchmarks/token_map.rs::benches::benchmarks

18.7 ms18.7 ms

rename

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks

46.3 ms46.3 ms

find_all_references

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks

46.3 ms46.3 ms

code_action

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks

25.7 ms25.7 ms

inlay_hints

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks

3.2 ms3.2 ms

on_enter

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks

127.2 µs127.3 µs

hover

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks

1.7 ms1.7 ms

token_at_position

sway-lsp/benches/lsp_benchmarks/token_map.rs::benches::benchmarks

1.6 ms1.6 ms

semantic_tokens

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks

-1%

3 ms3 ms

tokens_for_file

sway-lsp/benches/lsp_benchmarks/token_map.rs::benches::benchmarks

-3%

1.6 ms1.6 ms

Commits

Click on a commit to change the comparison range

Base

master

28c8ae4

-17.56%

fix oob concurrent slab panic when creating runnables on a did save event

fbe92d4

1 year ago

by JoshuaBatty

-0.68%

remove print

39f8063

1 year ago

by JoshuaBatty

+0.18%

temp disable optimised builds from did_change events

8cc5062

1 year ago

by JoshuaBatty

Home Terms Privacy Docs