josh/fix_function_slab_gc - Branch - FuelLabs/sway

Fix `function_cache` garbage collection bug

#6555Merged

Comparing

josh/fix_function_slab_gc

(

cddd31a

) with

master

(

e82c72b

)

-18%

Regressions: 1

Untouched: 21

Benchmarks

Failed

document_symbolRegression

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::document_symbol

-18%

4.3 ms5.3 ms

Passed

tokens_for_file

sway-lsp/benches/lsp_benchmarks/token_map.rs::benches::benchmarks::tokens_for_file

+1%

1.6 ms1.6 ms

did_change_with_caching

sway-lsp/benches/lsp_benchmarks/compile.rs::benches::benchmarks::did_change_with_caching

504.5 ms503.3 ms

completion

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::completion

22.9 ms22.9 ms

token_at_position

sway-lsp/benches/lsp_benchmarks/token_map.rs::benches::benchmarks::token_at_position

1.6 ms1.6 ms

code_action

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::code_action

25.7 ms25.7 ms

parent_decl_at_position

sway-lsp/benches/lsp_benchmarks/token_map.rs::benches::benchmarks::parent_decl_at_position

18.7 ms18.7 ms

find_all_references

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::find_all_references

46.3 ms46.3 ms

tokens_at_position

sway-lsp/benches/lsp_benchmarks/token_map.rs::benches::benchmarks::tokens_at_position

18.7 ms18.7 ms

rename

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::rename

46.3 ms46.3 ms

highlight

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::highlight

44 ms44 ms

idents_at_position

sway-lsp/benches/lsp_benchmarks/token_map.rs::benches::benchmarks::idents_at_position

460 µs460.1 µs

on_enter

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::on_enter

126.6 µs126.6 µs

inlay_hints

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::inlay_hints

3.2 ms3.2 ms

prepare_rename

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::prepare_rename

1.6 ms1.6 ms

goto_definition

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::goto_definition

1.6 ms1.6 ms

hover

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::hover

1.7 ms1.7 ms

traverse

sway-lsp/benches/lsp_benchmarks/compile.rs::benches::benchmarks::traverse

222.9 ms223.8 ms

code_lens

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::code_lens

6.2 µs6.2 µs

compile

sway-lsp/benches/lsp_benchmarks/compile.rs::benches::benchmarks::compile

5.4 s5.4 s

semantic_tokens

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::semantic_tokens

-2%

3 ms3 ms

format

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::format

-4%

360.6 ms377.4 ms

Commits

Click on a commit to change the comparison range

Base

master

e82c72b

-0.15%

add gc test for minimal scripts

a61f3a1

1 year ago

by JoshuaBatty

+0.1%

Refactor QueryEngine to use CowCache for programs and function caches instead of Arc<RwLock>.

8a5ed05

1 year ago

by JoshuaBatty

-0.22%

fix typo

a40b441

1 year ago

by JoshuaBatty

-0.04%

Add a commit method to QueryEngine to commit changes in all caches and update ServerState to use it.

41e4cf9

1 year ago

by JoshuaBatty

+0.47%

Merge branch 'master' into josh/fix_function_slab_gc

9c949d0

1 year ago

by sdankel

+18.83%

Merge branch 'master' into josh/fix_function_slab_gc

7cc28ce

1 year ago

by JoshuaBatty

-37.35%

Merge branch 'master' into josh/fix_function_slab_gc

cddd31a

1 year ago

by JoshuaBatty

Home Terms Privacy Docs