BlogDocs

Fix `function_cache` garbage collection bug (#6555)

Merged
Merging
josh/fix_function_slab_gc
(
cddd31a
) into
master
(
e82c72b
)
-18%
IMPROVEMENTS
0
REGRESSIONS
1
UNTOUCHED
21
NEW
0
DROPPED
0
IGNORED
0

Benchmarks

Failed

document_symbolRegression
sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::document_symbol
-18%
4.3 ms
5.3 ms

Passed

tokens_for_file
sway-lsp/benches/lsp_benchmarks/token_map.rs::benches::benchmarks::tokens_for_file
+1%
1.6 ms
1.6 ms
did_change_with_caching
sway-lsp/benches/lsp_benchmarks/compile.rs::benches::benchmarks::did_change_with_caching
0%
504.5 ms
503.3 ms
completion
sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::completion
0%
22.9 ms
22.9 ms
token_at_position
sway-lsp/benches/lsp_benchmarks/token_map.rs::benches::benchmarks::token_at_position
0%
1.6 ms
1.6 ms
code_action
sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::code_action
0%
25.7 ms
25.7 ms
parent_decl_at_position
sway-lsp/benches/lsp_benchmarks/token_map.rs::benches::benchmarks::parent_decl_at_position
0%
18.7 ms
18.7 ms
find_all_references
sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::find_all_references
0%
46.3 ms
46.3 ms
tokens_at_position
sway-lsp/benches/lsp_benchmarks/token_map.rs::benches::benchmarks::tokens_at_position
0%
18.7 ms
18.7 ms
rename
sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::rename
0%
46.3 ms
46.3 ms
highlight
sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::highlight
0%
44 ms
44 ms
idents_at_position
sway-lsp/benches/lsp_benchmarks/token_map.rs::benches::benchmarks::idents_at_position
0%
460 µs
460.1 µs
on_enter
sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::on_enter
0%
126.6 µs
126.6 µs
inlay_hints
sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::inlay_hints
0%
3.2 ms
3.2 ms
prepare_rename
sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::prepare_rename
0%
1.6 ms
1.6 ms
goto_definition
sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::goto_definition
0%
1.6 ms
1.6 ms
hover
sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::hover
0%
1.7 ms
1.7 ms
traverse
sway-lsp/benches/lsp_benchmarks/compile.rs::benches::benchmarks::traverse
0%
222.9 ms
223.8 ms
code_lens
sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::code_lens
0%
6.2 µs
6.2 µs
compile
sway-lsp/benches/lsp_benchmarks/compile.rs::benches::benchmarks::compile
0%
5.4 s
5.4 s
semantic_tokens
sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::semantic_tokens
-2%
3 ms
3 ms
format
sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::format
-4%
360.6 ms
377.4 ms

Commits

Click on a commit to change the comparison range
base
master
e82c72b
0%
add gc test for minimal scripts
a61f3a1
3 days ago
by JoshuaBatty
0%
Refactor QueryEngine to use CowCache for programs and function caches instead of Arc<RwLock>.
8a5ed05
3 days ago
by JoshuaBatty
0%
fix typo
a40b441
3 days ago
by JoshuaBatty
0%
Add a commit method to QueryEngine to commit changes in all caches and update ServerState to use it.
41e4cf9
3 days ago
by JoshuaBatty
0%
Merge branch 'master' into josh/fix_function_slab_gc
9c949d0
2 days ago
by sdankel
+19%
Merge branch 'master' into josh/fix_function_slab_gc
7cc28ce
2 days ago
by JoshuaBatty
-37%
Merge branch 'master' into josh/fix_function_slab_gc
cddd31a
2 days ago
by JoshuaBatty
ResourcesHomePricingDocsBlogGitHubChangelog
Copyright © 2024 CodSpeed Technology SAS. All rights reserved.