BlogDocs

Fixes mismatched types in ABI cast.(#6489)

Merged
Merging
esdrubal/fix_code_block_first_pass_abi
(
40639a8
) into
master
(
2538442
)
0%
IMPROVEMENTS
0
REGRESSIONS
0
UNTOUCHED
21
NEW
0
DROPPED
0
IGNORED
0

Benchmarks

Passed

format
sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::format
+6%
384.2 ms
362 ms
traverse
sway-lsp/benches/lsp_benchmarks/compile.rs::benches::benchmarks::traverse
0%
222.1 ms
221.5 ms
compile
sway-lsp/benches/lsp_benchmarks/compile.rs::benches::benchmarks::compile
0%
5 s
5 s
goto_definition
sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::goto_definition
0%
1.6 ms
1.6 ms
token_at_position
sway-lsp/benches/lsp_benchmarks/token_map.rs::benches::benchmarks::token_at_position
0%
1.6 ms
1.6 ms
document_symbol
sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::document_symbol
0%
5.2 ms
5.2 ms
hover
sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::hover
0%
1.7 ms
1.7 ms
highlight
sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::highlight
0%
44 ms
44 ms
rename
sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::rename
0%
46.2 ms
46.2 ms
code_action
sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::code_action
0%
25.6 ms
25.6 ms
parent_decl_at_position
sway-lsp/benches/lsp_benchmarks/token_map.rs::benches::benchmarks::parent_decl_at_position
0%
18.7 ms
18.7 ms
idents_at_position
sway-lsp/benches/lsp_benchmarks/token_map.rs::benches::benchmarks::idents_at_position
0%
459.8 µs
459.8 µs
tokens_at_position
sway-lsp/benches/lsp_benchmarks/token_map.rs::benches::benchmarks::tokens_at_position
0%
18.7 ms
18.7 ms
prepare_rename
sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::prepare_rename
0%
1.6 ms
1.6 ms
inlay_hints
sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::inlay_hints
0%
3.2 ms
3.2 ms
semantic_tokens
sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::semantic_tokens
0%
3 ms
3 ms
on_enter
sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::on_enter
0%
125.6 µs
125.8 µs
completion
sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::completion
0%
22.9 ms
22.9 ms
did_change_with_caching
sway-lsp/benches/lsp_benchmarks/compile.rs::benches::benchmarks::did_change_with_caching
0%
499.5 ms
500.3 ms
tokens_for_file
sway-lsp/benches/lsp_benchmarks/token_map.rs::benches::benchmarks::tokens_for_file
-1%
1.6 ms
1.6 ms
code_lens
sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::code_lens
-1%
6.1 µs
6.2 µs

Commits

Click on a commit to change the comparison range
base
master
2538442
-11%
Fixes mismatched types in ABI cast. ABI cast generates TypeInfo::ContractCaller which contains an address that is an expression. While doing the first and second code block passes we would obtain different expressions because of first passes optimizations. This PR disables first pass optimizations while type checking address expression so there isn't any mismatched types.
a889078
16 days ago
by esdrubal
+10%
Merge branch 'master' into esdrubal/fix_code_block_first_pass_abi
753351b
15 days ago
by IGI-111
+1%
Merge branch 'master' into esdrubal/fix_code_block_first_pass_abi
40639a8
12 days ago
by sdankel
ResourcesHomePricingDocsBlogGitHubChangelog
Copyright © 2024 CodSpeed Technology SAS. All rights reserved.