Avatar for the FuelLabs user
FuelLabs
sway
BlogDocsChangelog

Fixes mismatched types in ABI cast.

#6489Merged
Comparing
esdrubal/fix_code_block_first_pass_abi
(
40639a8
) with
master
(
2538442
)
CodSpeed Performance Gauge
0%
Improvements
0
Regressions
0
Untouched
21
New
0
Dropped
0
Ignored
0

Benchmarks

Passed

format
sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::format
CodSpeed Performance Gauge
+6%
384.2 ms
362 ms
traverse
sway-lsp/benches/lsp_benchmarks/compile.rs::benches::benchmarks::traverse
CodSpeed Performance Gauge
0%
222.1 ms
221.5 ms
compile
sway-lsp/benches/lsp_benchmarks/compile.rs::benches::benchmarks::compile
CodSpeed Performance Gauge
0%
5 s
5 s
goto_definition
sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::goto_definition
CodSpeed Performance Gauge
0%
1.6 ms
1.6 ms
token_at_position
sway-lsp/benches/lsp_benchmarks/token_map.rs::benches::benchmarks::token_at_position
CodSpeed Performance Gauge
0%
1.6 ms
1.6 ms
document_symbol
sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::document_symbol
CodSpeed Performance Gauge
0%
5.2 ms
5.2 ms
hover
sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::hover
CodSpeed Performance Gauge
0%
1.7 ms
1.7 ms
highlight
sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::highlight
CodSpeed Performance Gauge
0%
44 ms
44 ms
rename
sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::rename
CodSpeed Performance Gauge
0%
46.2 ms
46.2 ms
code_action
sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::code_action
CodSpeed Performance Gauge
0%
25.6 ms
25.6 ms
parent_decl_at_position
sway-lsp/benches/lsp_benchmarks/token_map.rs::benches::benchmarks::parent_decl_at_position
CodSpeed Performance Gauge
0%
18.7 ms
18.7 ms
idents_at_position
sway-lsp/benches/lsp_benchmarks/token_map.rs::benches::benchmarks::idents_at_position
CodSpeed Performance Gauge
0%
459.8 µs
459.8 µs
tokens_at_position
sway-lsp/benches/lsp_benchmarks/token_map.rs::benches::benchmarks::tokens_at_position
CodSpeed Performance Gauge
0%
18.7 ms
18.7 ms
prepare_rename
sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::prepare_rename
CodSpeed Performance Gauge
0%
1.6 ms
1.6 ms
inlay_hints
sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::inlay_hints
CodSpeed Performance Gauge
0%
3.2 ms
3.2 ms
semantic_tokens
sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::semantic_tokens
CodSpeed Performance Gauge
0%
3 ms
3 ms
on_enter
sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::on_enter
CodSpeed Performance Gauge
0%
125.6 µs
125.8 µs
completion
sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::completion
CodSpeed Performance Gauge
0%
22.9 ms
22.9 ms
did_change_with_caching
sway-lsp/benches/lsp_benchmarks/compile.rs::benches::benchmarks::did_change_with_caching
CodSpeed Performance Gauge
0%
499.5 ms
500.3 ms
tokens_for_file
sway-lsp/benches/lsp_benchmarks/token_map.rs::benches::benchmarks::tokens_for_file
CodSpeed Performance Gauge
-1%
1.6 ms
1.6 ms
code_lens
sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::code_lens
CodSpeed Performance Gauge
-1%
6.1 µs
6.2 µs

Commits

Click on a commit to change the comparison range
Base
master
2538442
-11%
Fixes mismatched types in ABI cast. ABI cast generates TypeInfo::ContractCaller which contains an address that is an expression. While doing the first and second code block passes we would obtain different expressions because of first passes optimizations. This PR disables first pass optimizations while type checking address expression so there isn't any mismatched types.
a889078
5 months ago
by esdrubal
+10%
Merge branch 'master' into esdrubal/fix_code_block_first_pass_abi
753351b
4 months ago
by IGI-111
+1%
Merge branch 'master' into esdrubal/fix_code_block_first_pass_abi
40639a8
4 months ago
by sdankel
Home Terms PrivacyDocs