esdrubal/fix_code_block_first_pass_abi - Branch - FuelLabs/sway

Fixes mismatched types in ABI cast.

#6489Merged

Comparing

esdrubal/fix_code_block_first_pass_abi

(

40639a8

) with

master

(

2538442

)

Untouched: 21

Benchmarks

Passed

format

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks

+6%

384.2 ms362 ms

traverse

sway-lsp/benches/lsp_benchmarks/compile.rs::benches::benchmarks

222.1 ms221.5 ms

compile

sway-lsp/benches/lsp_benchmarks/compile.rs::benches::benchmarks

5 s5 s

goto_definition

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks

1.6 ms1.6 ms

token_at_position

sway-lsp/benches/lsp_benchmarks/token_map.rs::benches::benchmarks

1.6 ms1.6 ms

document_symbol

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks

5.2 ms5.2 ms

hover

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks

1.7 ms1.7 ms

highlight

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks

44 ms44 ms

rename

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks

46.2 ms46.2 ms

code_action

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks

25.6 ms25.6 ms

parent_decl_at_position

sway-lsp/benches/lsp_benchmarks/token_map.rs::benches::benchmarks

18.7 ms18.7 ms

idents_at_position

sway-lsp/benches/lsp_benchmarks/token_map.rs::benches::benchmarks

459.8 µs459.8 µs

tokens_at_position

sway-lsp/benches/lsp_benchmarks/token_map.rs::benches::benchmarks

18.7 ms18.7 ms

prepare_rename

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks

1.6 ms1.6 ms

inlay_hints

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks

3.2 ms3.2 ms

semantic_tokens

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks

3 ms3 ms

on_enter

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks

125.6 µs125.8 µs

completion

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks

22.9 ms22.9 ms

did_change_with_caching

sway-lsp/benches/lsp_benchmarks/compile.rs::benches::benchmarks

499.5 ms500.3 ms

tokens_for_file

sway-lsp/benches/lsp_benchmarks/token_map.rs::benches::benchmarks

-1%

1.6 ms1.6 ms

code_lens

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks

-1%

6.1 µs6.2 µs

Commits

Click on a commit to change the comparison range

Base

master

2538442

-10.58%

Fixes mismatched types in ABI cast. ABI cast generates TypeInfo::ContractCaller which contains an address that is an expression. While doing the first and second code block passes we would obtain different expressions because of first passes optimizations. This PR disables first pass optimizations while type checking address expression so there isn't any mismatched types.

a889078

1 year ago

by esdrubal

+9.96%

Merge branch 'master' into esdrubal/fix_code_block_first_pass_abi

753351b

1 year ago

by IGI-111

+0.84%

Merge branch 'master' into esdrubal/fix_code_block_first_pass_abi

40639a8

1 year ago

by sdankel

Home Terms Privacy Docs