esdrubal/6395 - Branch - FuelLabs/sway

Fixes `for` specific error message.

#6758Merged

Comparing

esdrubal/6395

(

0806797

) with

master

(

a02e8ea

)

Untouched: 22

Benchmarks

Passed

hover

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks

1.8 ms1.8 ms

idents_at_position

sway-lsp/benches/lsp_benchmarks/token_map.rs::benches::benchmarks

482.7 µs481.7 µs

on_enter

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks

126.4 µs126.1 µs

traverse

sway-lsp/benches/lsp_benchmarks/compile.rs::benches::benchmarks

212.6 ms212.2 ms

prepare_rename

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks

1.7 ms1.7 ms

completion

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks

21 ms21 ms

parent_decl_at_position

sway-lsp/benches/lsp_benchmarks/token_map.rs::benches::benchmarks

18.7 ms18.7 ms

highlight

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks

44.1 ms44.1 ms

inlay_hints

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks

18.6 ms18.6 ms

rename

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks

46.6 ms46.6 ms

find_all_references

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks

46.6 ms46.6 ms

tokens_at_position

sway-lsp/benches/lsp_benchmarks/token_map.rs::benches::benchmarks

18.7 ms18.7 ms

code_action

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks

25.9 ms25.9 ms

goto_definition

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks

1.7 ms1.7 ms

did_change_with_caching

sway-lsp/benches/lsp_benchmarks/compile.rs::benches::benchmarks

505.6 ms507.1 ms

token_at_position

sway-lsp/benches/lsp_benchmarks/token_map.rs::benches::benchmarks

1.7 ms1.7 ms

compile

sway-lsp/benches/lsp_benchmarks/compile.rs::benches::benchmarks

5.4 s5.5 s

tokens_for_file

sway-lsp/benches/lsp_benchmarks/token_map.rs::benches::benchmarks

1.7 ms1.7 ms

code_lens

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks

-1%

5.3 µs5.3 µs

format

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks

-1%

462.5 ms467.7 ms

semantic_tokens

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks

-3%

3.1 ms3.2 ms

document_symbol

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks

-3%

5.3 ms5.5 ms

Commits

Click on a commit to change the comparison range

Base

master

a02e8ea

+0.28%

Fixes for specific error message. The added test case was emitting a wrong/confusing error message, because a for loop only gets type-checked in its desugared form, as a while loop. The error message was `A while loop's loop body cannot implicitly return a value. Try assigning it to a mutable variable declared outside of the loop instead.` Corrected to: `A for loop's loop body cannot implicitly return a value. Try assigning it to a mutable variable declared outside of the loop instead.`

f4d9fba

11 months ago

by esdrubal

-0.7%

Merge branch 'master' into esdrubal/6395

0806797

11 months ago

by IGI-111

Home Terms Privacy Docs