esdrubal/redundant_unify_checks_6394 - Branch - FuelLabs/sway

Removes redundant checks from unifier.

#6912Merged

Comparing

esdrubal/redundant_unify_checks_6394

(

699f082

) with

master

(

bb7c99b

)

Untouched: 22

Benchmarks

Passed

format

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks

+1%

476.3 ms470.9 ms

semantic_tokens

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks

+1%

3.1 ms3.1 ms

compile

sway-lsp/benches/lsp_benchmarks/compile.rs::benches::benchmarks

5.1 s5.1 s

did_change_with_caching

sway-lsp/benches/lsp_benchmarks/compile.rs::benches::benchmarks

540.4 ms539.5 ms

code_action

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks

27.8 ms27.8 ms

goto_definition

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks

1.7 ms1.7 ms

document_symbol

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks

19 ms19 ms

hover

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks

3.5 ms3.5 ms

traverse

sway-lsp/benches/lsp_benchmarks/compile.rs::benches::benchmarks

226.3 ms226.3 ms

rename

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks

46.7 ms46.7 ms

find_all_references

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks

46.7 ms46.7 ms

highlight

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks

44.1 ms44.1 ms

completion

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks

20.9 ms20.9 ms

code_lens

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks

5.4 µs5.4 µs

inlay_hints

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks

18.6 ms18.6 ms

parent_decl_at_position

sway-lsp/benches/lsp_benchmarks/token_map.rs::benches::benchmarks

18.7 ms18.7 ms

prepare_rename

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks

1.7 ms1.7 ms

tokens_at_position

sway-lsp/benches/lsp_benchmarks/token_map.rs::benches::benchmarks

18.7 ms18.7 ms

token_at_position

sway-lsp/benches/lsp_benchmarks/token_map.rs::benches::benchmarks

1.7 ms1.7 ms

idents_at_position

sway-lsp/benches/lsp_benchmarks/token_map.rs::benches::benchmarks

483.3 µs483.6 µs

on_enter

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks

125.2 µs125.7 µs

tokens_for_file

sway-lsp/benches/lsp_benchmarks/token_map.rs::benches::benchmarks

1.7 ms1.7 ms

Commits

Click on a commit to change the comparison range

Base

master

bb7c99b

-34.82%

Removes redundant checks from unifier. unify_structs was also unifying the fields and unify_enums was also unifying the variants. This was removed because comparing call paths and type parameters is enough. Fixes #6394 Signed-off-by: Marcos Henrich <marcoshenrich@gmail.com>

04f71f1

10 months ago

by esdrubal

+34.9%

Merge branch 'master' into esdrubal/redundant_unify_checks_6394

699f082

10 months ago

by tritao

Home Terms Privacy Docs