esdrubal/6389 - Branch - FuelLabs/sway

Fixes qualified call path without as trait.

#6764Merged

Comparing

esdrubal/6389

(

d3322b2

) with

master

(

33d3674

)

-71%

Regressions: 1

Untouched: 21

Benchmarks

Failed

document_symbolRegression

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::document_symbol

-71%

5.5 ms18.9 ms

Passed

semantic_tokens

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::semantic_tokens

+4%

3.2 ms3.1 ms

code_lens

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::code_lens

+1%

5.4 µs5.3 µs

on_enter

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::on_enter

+1%

126.5 µs125.8 µs

token_at_position

sway-lsp/benches/lsp_benchmarks/token_map.rs::benches::benchmarks::token_at_position

1.7 ms1.7 ms

did_change_with_caching

sway-lsp/benches/lsp_benchmarks/compile.rs::benches::benchmarks::did_change_with_caching

506.6 ms506.1 ms

completion

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::completion

21 ms20.9 ms

hover

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::hover

1.8 ms1.8 ms

tokens_at_position

sway-lsp/benches/lsp_benchmarks/token_map.rs::benches::benchmarks::tokens_at_position

18.7 ms18.7 ms

find_all_references

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::find_all_references

46.6 ms46.6 ms

rename

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::rename

46.6 ms46.6 ms

idents_at_position

sway-lsp/benches/lsp_benchmarks/token_map.rs::benches::benchmarks::idents_at_position

481.7 µs481.7 µs

parent_decl_at_position

sway-lsp/benches/lsp_benchmarks/token_map.rs::benches::benchmarks::parent_decl_at_position

18.7 ms18.7 ms

goto_definition

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::goto_definition

1.7 ms1.7 ms

highlight

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::highlight

44.1 ms44.1 ms

code_action

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::code_action

25.9 ms25.9 ms

inlay_hints

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::inlay_hints

18.6 ms18.6 ms

traverse

sway-lsp/benches/lsp_benchmarks/compile.rs::benches::benchmarks::traverse

212.2 ms212.4 ms

compile

sway-lsp/benches/lsp_benchmarks/compile.rs::benches::benchmarks::compile

5.5 s5.5 s

prepare_rename

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::prepare_rename

1.7 ms1.7 ms

tokens_for_file

sway-lsp/benches/lsp_benchmarks/token_map.rs::benches::benchmarks::tokens_for_file

-1%

1.7 ms1.7 ms

format

sway-lsp/benches/lsp_benchmarks/requests.rs::benches::benchmarks::format

-1%

458.4 ms464.7 ms

Commits

Click on a commit to change the comparison range

Base

master

33d3674

+0.35%

Fixes qualified call path without as trait. The parser no longer parses qualified call path without the `as` token and trait. This invalidates code that was previously accepted such as: `let x: <u8>::S::<u8> = S::<u8>{x: 8};`` Fixes #6389

14744a8

10 months ago

by esdrubal

-71.22%

Merge branch 'master' into esdrubal/6389

d3322b2

10 months ago

by JoshuaBatty

Home Terms Privacy Docs