Don't include engine.h when OPENSSL_NO_ENGINE is defined
#124Comparing
fork-11328-tiran/engine-include
(7a1927b
) withmain
(8250f67
)0%
- Improvements
- 0
- Regressions
- 0
- Untouched
- 20
- New
- 0
- Dropped
- 0
- Ignored
- 0
Benchmarks
Passed
test_sha256
tests/bench/test_hashes.py::test_sha256+1%
63.3 µs
62.4 µs
test_aki_public_bytes
tests/bench/test_x509.py::test_aki_public_bytes+1%
29.6 µs
29.4 µs
test_fernet_encrypt
tests/bench/test_fernet.py::test_fernet_encrypt0%
199.8 µs
199.1 µs
test_aesccm_decrypt
tests/bench/test_aead.py::test_aesccm_decrypt0%
48.2 µs
48.1 µs
test_chacha20poly1305_encrypt
tests/bench/test_aead.py::test_chacha20poly1305_encrypt0%
58.3 µs
58.2 µs
test_aessiv_encrypt
tests/bench/test_aead.py::test_aessiv_encrypt0%
45.2 µs
45.2 µs
test_aesocb3_encrypt
tests/bench/test_aead.py::test_aesocb3_encrypt0%
42.5 µs
42.4 µs
test_aesocb3_decrypt
tests/bench/test_aead.py::test_aesocb3_decrypt0%
42.6 µs
42.5 µs
test_aessiv_decrypt
tests/bench/test_aead.py::test_aessiv_decrypt0%
44.5 µs
44.5 µs
test_hmac_sha256
tests/bench/test_hmac.py::test_hmac_sha2560%
68.2 µs
68.2 µs
test_load_pem_certificate
tests/bench/test_x509.py::test_load_pem_certificate0%
114.2 µs
114.2 µs
test_chacha20poly1305_decrypt
tests/bench/test_aead.py::test_chacha20poly1305_decrypt0%
53 µs
53 µs
test_load_ec_private_numbers
tests/bench/test_ec_load.py::test_load_ec_private_numbers0%
236.5 µs
236.7 µs
test_aesgcm_decrypt
tests/bench/test_aead.py::test_aesgcm_decrypt0%
50.1 µs
50.2 µs
test_aesccm_encrypt
tests/bench/test_aead.py::test_aesccm_encrypt0%
49.5 µs
49.6 µs
test_verify_docs_python_org
tests/bench/test_x509.py::test_verify_docs_python_org0%
890 µs
891.4 µs
test_load_der_certificate
tests/bench/test_x509.py::test_load_der_certificate0%
44.9 µs
45 µs
test_load_ec_public_numbers
tests/bench/test_ec_load.py::test_load_ec_public_numbers0%
116.7 µs
117.2 µs
test_object_identifier_constructor
tests/bench/test_x509.py::test_object_identifier_constructor-1%
19.5 µs
19.6 µs
test_aesgcm_encrypt
tests/bench/test_aead.py::test_aesgcm_encrypt-1%
50.5 µs
50.9 µs
Commits
Click on a commit to change the comparison rangeBase
main
8250f67
0%
Don't include engine.h when OPENSSL_NO_ENGINE is defined
Fedora 41 and RHEL 10 are deprecating and phasing out OpenSSL ENGINE
support. Downstream has moved `openssl/engine.h` into a separate RPM
package and is recompiling packages with `-DOPENSSL_NO_ENGINE=1`. The
compiler flag disables PyCA cryptography's ENGINE support successfully.
We also like to build the downstream package without the `engine.h`
header file present.
This commit makes the include conditional. The `ENGINE` type is
defined in `openssl/types.h`.
See: https://src.fedoraproject.org/rpms/openssl/c/e67e9d9c40cd2cb9547e539c658e2b63f2736762?branch=rawhide
See: https://issues.redhat.com/browse/RHEL-33747
Signed-off-by: Christian Heimes <christian@python.org>
7a1927b
8 months ago
by tiran