skbeh:socket-leak-on-connect-error - Branch - Bluetooth-Devices/dbus-fast

fix(message_bus): prevent socket leak on connection error

#491

Comparing

skbeh:socket-leak-on-connect-error

(

b5577e1

) with

main

(

5afc3a9

)

-1%

Untouched: 6

Benchmarks

Passed

test_marshall_bluez_get_managed_objects_message

tests/benchmarks/test_marshall.py::test_marshall_bluez_get_managed_objects_message

+1%

68.9 µs68.5 µs

test_unmarshall_multiple_bluez_properties_message

tests/benchmarks/test_unmarshall.py::test_unmarshall_multiple_bluez_properties_message

96 µs96.3 µs

test_unmarshall_bluez_properties_message

tests/benchmarks/test_unmarshall.py::test_unmarshall_bluez_properties_message

42.4 µs42.6 µs

test_unmarshall_bluez_rssi_message

tests/benchmarks/test_unmarshall.py::test_unmarshall_bluez_rssi_message

-1%

43.5 µs43.7 µs

test_unmarshall_multiple_bluez_properties_message_socket

tests/benchmarks/test_unmarshall.py::test_unmarshall_multiple_bluez_properties_message_socket

-1%

96.5 µs97.4 µs

test_unmarshall_bluez_interfaces_added_message

tests/benchmarks/test_unmarshall.py::test_unmarshall_bluez_interfaces_added_message

-2%

64.9 µs66 µs

Commits

Click on a commit to change the comparison range

Base

main

5afc3a9

-0.53%

fix(message_bus): prevent socket leak on connection error In the `_setup_socket` method, if an exception occurred during the connection attempt, the underlying socket file descriptor was not being closed. This commit refactors the socket connection logic to ensure that if an error is present after trying all available bus addresses, the socket is explicitly closed before the connection error is raised.

b5577e1

1 month ago

by skbeh

Home Terms Privacy Docs