Avatar for the ngriffiths13 user
ngriffiths13
polars-trading
BlogDocs

fix(daily_vol): update daily vol to use the last price at least 24 hours previous

#7Merged
Comparing
fix/weekend-returns-daily-vol
(
3743610
) with
main
(
e098b35
)
+1%
Improvements
0
Regressions
0
Untouched
10
New
0
Dropped
0
Ignored
0

Benchmarks

Passed

test__fixed_time_return_classification__benchmark[trade_data0]
tests/labels/test_labels.py::test__fixed_time_return_classification__benchmark[trade_data0]
+4%
57.5 ms
55.5 ms
test__volume_bars__polars_benchmark[trade_data0]
tests/test_bars.py::test__volume_bars__polars_benchmark[trade_data0]
+2%
61.3 ms
60.4 ms
test__dollar_bars__polars_benchmark[trade_data0]
tests/test_bars.py::test__dollar_bars__polars_benchmark[trade_data0]
+1%
62.9 ms
62 ms
test__time_bars__polars_benchmark[trade_data0]
tests/test_bars.py::test__time_bars__polars_benchmark[trade_data0]
+1%
7.3 ms
7.3 ms
test__validate_columns__default_args
tests/test__utils.py::test__validate_columns__default_args
0%
950.2 µs
947.1 µs
test__validate_columns__df_not_passed
tests/test__utils.py::test__validate_columns__df_not_passed
0%
288.5 µs
287.9 µs
test__validate_columns__invalid
tests/test__utils.py::test__validate_columns__invalid
0%
993.3 µs
993.6 µs
test__validate_columns__valid
tests/test__utils.py::test__validate_columns__valid
0%
921.7 µs
923.9 µs
test__tick_bars__polars_benchmark[trade_data0]
tests/test_bars.py::test__tick_bars__polars_benchmark[trade_data0]
-1%
12.5 ms
12.6 ms
test__daily_vol__polars_benchmark[trade_data0]
tests/labels/test_dynamic_labels.py::test__daily_vol__polars_benchmark[trade_data0]
-1%
132.9 ms
134.1 ms

Commits

Click on a commit to change the comparison range
Base
main
e098b35
+1%
fix(daily_vol): update daily vol to use the last price at least 24 hours previous This makes it so every monday we don't get a 0 return because there were no prices on sunday. It will use end of day friday price instead.
3743610
2 months ago
Home Terms PrivacyDocs