egraphs-good
egglog
BlogDocs

Fix `eval_lit` performance bug

#441Closed
Comparing
Alex-Fischman:eval-lit-performance
(
840308a
) with
main
(
43de12f
)
+17%
Improvements
1
Regressions
0
Untouched
5
New
0
Dropped
0
Ignored
81

Benchmarks

Improved

eggcc-extraction
benches/example_benchmarks.rs::benches::criterion_benchmark::eggcc-extraction
+17%
5.5 s
4.7 s

Passed

math-microbenchmark
benches/example_benchmarks.rs::benches::criterion_benchmark::math-microbenchmark
0%
4.2 s
4.2 s
lambda
benches/example_benchmarks.rs::benches::criterion_benchmark::lambda
0%
145.1 ms
145 ms
cykjson
benches/example_benchmarks.rs::benches::criterion_benchmark::cykjson
0%
338.6 ms
338.6 ms
typeinfer
benches/example_benchmarks.rs::benches::criterion_benchmark::typeinfer
0%
400.1 ms
400.3 ms
herbie
benches/example_benchmarks.rs::benches::criterion_benchmark::herbie
0%
285.5 ms
285.8 ms

Ignored

antiunifyIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::antiunify
0%
2.1 ms
2.1 ms
arrayIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::array
+1%
26.8 ms
26.6 ms
bddIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::bdd
0%
15.2 ms
15.2 ms
before-proofsIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::before-proofs
0%
1.6 ms
1.6 ms
birewriteIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::birewrite
+1%
1.3 ms
1.3 ms
bitwiseIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::bitwise
0%
672.2 µs
671 µs
boolIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::bool
0%
1.4 ms
1.4 ms
calcIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::calc
0%
5.4 ms
5.4 ms
combinatorsIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::combinators
0%
18.5 ms
18.4 ms
combined-nestedIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::combined-nested
+2%
1 ms
1 ms
container-rebuildIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::container-rebuild
+1%
2 ms
2 ms
cykIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::cyk
0%
11.3 ms
11.3 ms
datatypesIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::datatypes
-7%
549.2 µs
593.6 µs
deleteIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::delete
-4%
623.7 µs
651.3 µs
eqsat-basicIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::eqsat-basic
0%
1.6 ms
1.6 ms
eqsolveIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::eqsolve
+1%
31.2 ms
30.8 ms
f64Ignored
benches/example_benchmarks.rs::benches::criterion_benchmark::f64
0%
927.9 µs
931.3 µs
fail_wrong_assertionIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::fail_wrong_assertion
+1%
1.3 ms
1.2 ms
fibonacciIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::fibonacci
-1%
1.6 ms
1.6 ms
fibonacci-demandIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::fibonacci-demand
-1%
2.1 ms
2.1 ms
fusionIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::fusion
+2%
44.2 ms
43.3 ms
herbie-tutorialIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::herbie-tutorial
0%
12.7 ms
12.7 ms
i64Ignored
benches/example_benchmarks.rs::benches::criterion_benchmark::i64
0%
350.6 µs
349.9 µs
includeIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::include
0%
1.2 ms
1.2 ms
integer_mathIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::integer_math
0%
12.1 ms
12.2 ms
intersectionIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::intersection
0%
1.9 ms
1.9 ms
intervalIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::interval
-1%
2.7 ms
2.7 ms
knapsackIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::knapsack
0%
5.7 ms
5.7 ms
levenshtein-distanceIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::levenshtein-distance
+1%
15.2 ms
15.1 ms
listIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::list
-1%
4.8 ms
4.8 ms
mapIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::map
0%
652.5 µs
652 µs
mathIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::math
+1%
36.8 ms
36.6 ms
matrixIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::matrix
0%
11.5 ms
11.5 ms
merge-during-rebuildIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::merge-during-rebuild
0%
1 ms
1 ms
merge-saturatesIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::merge-saturates
0%
3 ms
3 ms
name-resolutionIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::name-resolution
0%
1.2 ms
1.1 ms
pathIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::path
0%
1 ms
1 ms
path-unionIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::path-union
0%
1.1 ms
1.1 ms
pathproofIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::pathproof
0%
1.5 ms
1.5 ms
points-toIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::points-to
0%
2 ms
2 ms
primitivesIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::primitives
0%
521 µs
523.5 µs
primsIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::prims
0%
5.4 ms
5.4 ms
push-popIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::push-pop
-1%
640 µs
645.1 µs
rationalIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::rational
+1%
887.5 µs
882.5 µs
repro-defineIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::repro-define
0%
691 µs
692.1 µs
repro-desugar-143Ignored
benches/example_benchmarks.rs::benches::criterion_benchmark::repro-desugar-143
-1%
8.4 ms
8.5 ms
repro-empty-queryIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::repro-empty-query
0%
613.9 µs
613.8 µs
repro-equal-constantIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::repro-equal-constant
0%
665.9 µs
666.8 µs
repro-equal-constant2Ignored
benches/example_benchmarks.rs::benches::criterion_benchmark::repro-equal-constant2
0%
649 µs
651.3 µs
repro-noteqbugIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::repro-noteqbug
0%
744 µs
745 µs
repro-primitive-queryIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::repro-primitive-query
0%
684.3 µs
681 µs
repro-querybugIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::repro-querybug
0%
925.8 µs
925.6 µs
repro-querybug2Ignored
benches/example_benchmarks.rs::benches::criterion_benchmark::repro-querybug2
0%
665.9 µs
664.1 µs
repro-querybug3Ignored
benches/example_benchmarks.rs::benches::criterion_benchmark::repro-querybug3
0%
2 ms
2 ms
repro-querybug4Ignored
benches/example_benchmarks.rs::benches::criterion_benchmark::repro-querybug4
0%
713.8 µs
713.2 µs
repro-should-saturateIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::repro-should-saturate
0%
647.6 µs
647.1 µs
repro-silly-panicIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::repro-silly-panic
0%
916.5 µs
916.6 µs
repro-typechecking-scheduleIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::repro-typechecking-schedule
0%
459.7 µs
460 µs
repro-unsoundIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::repro-unsound
-1%
268.9 ms
271 ms
repro-unsound-htutorialIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::repro-unsound-htutorial
0%
846.8 µs
847.9 µs
repro-vec-unequalIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::repro-vec-unequal
0%
764.2 µs
762.5 µs
resolutionIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::resolution
0%
4.1 ms
4.1 ms
rw-analysisIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::rw-analysis
0%
39.8 ms
39.7 ms
schedule-demoIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::schedule-demo
+2%
2.2 ms
2.2 ms
semi_naive_set_functionIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::semi_naive_set_function
+1%
41.7 ms
41.3 ms
setIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::set
0%
2.7 ms
2.7 ms
stratifiedIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::stratified
0%
899 µs
895.8 µs
stringIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::string
+8%
541.6 µs
500.3 µs
string_quotesIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::string_quotes
+10%
475.3 µs
431.6 µs
subsumeIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::subsume
+2%
1.5 ms
1.5 ms
test-combinedIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::test-combined
+4%
1.3 ms
1.3 ms
test-combined-stepsIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::test-combined-steps
+2%
2.9 ms
2.9 ms
towers-of-hanoiIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::towers-of-hanoi
+1%
5.3 ms
5.2 ms
tricky-type-checkingIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::tricky-type-checking
-1%
11.5 ms
11.6 ms
type-constraints-testsIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::type-constraints-tests
-8%
534.7 µs
580.5 µs
typecheckIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::typecheck
-1%
5.7 ms
5.8 ms
unification-points-toIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::unification-points-to
0%
7.8 ms
7.8 ms
unifyIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::unify
0%
1.1 ms
1.1 ms
unstable-fnIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::unstable-fn
0%
5.7 ms
5.7 ms
untilIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::until
0%
2.7 ms
2.7 ms
vecIgnored
benches/example_benchmarks.rs::benches::criterion_benchmark::vec
0%
970.3 µs
971.8 µs

Commits

Click on a commit to change the comparison range
Base
main
43de12f
+17%
Fix eval_lit performance bug
840308a
2 months ago
by Alex-Fischman
Home Terms PrivacyDocs