devbird/fix-compress-comparisons-side-effects - Branch - swc-project/swc

fix(es/minifier): Prevent compress.comparisons from transforming expressions with side effects

#11256

Comparing

devbird/fix-compress-comparisons-side-effects

(

37bb093

) with

main

(

2cea7dd

)

Untouched: 138

Ignored: 1

Benchmarks

Passed

html/document_fragment/visitor/compare/clone

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1 ms1 ms

css_spec

crates/swc_html_minifier/benches/full.rs::files_document_fragment::bench_files_document_fragment::html/minify/document_fragment

196.4 ms196.2 ms

stackoverflow

crates/swc_html_minifier/benches/full.rs::files_document::bench_files_document::html/minify/document

36.2 ms36.2 ms

css_spec

crates/swc_html_minifier/benches/full.rs::files_document::bench_files_document::html/minify/document

196.7 ms196.5 ms

github

crates/swc_html_minifier/benches/full.rs::files_document_fragment::bench_files_document_fragment::html/minify/document_fragment

41.7 ms41.7 ms

es2020_nullish_coalescing

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

291.6 µs291.4 µs

stackoverflow

crates/swc_html_minifier/benches/full.rs::files_document_fragment::bench_files_document_fragment::html/minify/document_fragment

37.5 ms37.5 ms

es/parser/angular

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

17.8 ms17.8 ms

es2015_sticky_regex

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

274.3 µs274.2 µs

es/full-target/es2016

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::full_group

578.5 µs578.3 µs

es/lints/libs/jquery

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

6.5 ms6.5 ms

es/transform/baseline/base

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::baseline_group

260.3 µs260.2 µs

github

crates/swc_html_minifier/benches/full.rs::files_document::bench_files_document::html/minify/document

42.4 ms42.3 ms

es/codegen/large

crates/swc_ecma_codegen/benches/bench.rs::benches::bench_cases

639.8 µs639.7 µs

es2015_instanceof

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

278.6 µs278.6 µs

es/target/es2020

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::version_group

459.6 µs459.4 µs

es/lints/libs/lodash

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

6.2 ms6.2 ms

es/transform/baseline/common_typescript

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::baseline_group

371.1 µs371 µs

es/preset-env/usage/property

crates/swc_ecma_preset_env/benches/polyfills.rs::benches::bench_cases

113.3 µs113.3 µs

es2015_shorthand_property

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

274.8 µs274.8 µs

es2019_optional_catch_binding

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

272.3 µs272.2 µs

es2015_destructuring

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

346.1 µs346 µs

es/minifier/libs/lodash

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

115.2 ms115.2 ms

es2015_block_scoping

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

458.2 µs458.2 µs

es2015_fn_name

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

281.3 µs281.3 µs

es2015_duplicate_keys

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

281.5 µs281.5 µs

es2015_typeof_symbol

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

276.4 µs276.4 µs

es2015_computed_props

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

274.1 µs274.1 µs

es/lints/libs/vue

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

8.3 ms8.3 ms

es2015_block_scoped_fn

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

292.4 µs292.4 µs

es2020_optional_chaining

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

338.7 µs338.6 µs

es/lints/libs/typescript

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

276.4 ms276.4 ms

html/parser/parser_document_fragment/css_2021_spec

crates/swc_html_parser/benches/parser.rs::benches::bench_files

71.9 ms71.9 ms

es/target/es3

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::version_group

398.9 µs398.9 µs

es/target/es2017

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::version_group

276.5 µs276.4 µs

es2017_async_to_generator

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

277.5 µs277.4 µs

es2015_arrow

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

300.1 µs300 µs

es2015_spread

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

273.5 µs273.5 µs

es/transform/baseline/common_reserved_word

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::baseline_group

278.3 µs278.3 µs

css/visitor/compare/fold_span

crates/swc_css_parser/benches/compare.rs::benches::bench_cases

5.8 ms5.8 ms

html/document_fragment/visitor/compare/fold_span_panic

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.2 ms1.2 ms

es2015_for_of

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

294.2 µs294.2 µs

es/minifier/libs/typescript

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

3.8 s3.8 s

es2015_classes

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

391.4 µs391.3 µs

es2018_object_rest_spread

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

291.2 µs291.1 µs

es/target/es2016

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::version_group

292.3 µs292.3 µs

es/visitor/compare/visit_mut_span_panic

crates/swc_ecma_parser/benches/compare.rs::benches::bench_cases

6 ms6 ms

html/parser/parser_document/github_com_17_05_2022

crates/swc_html_parser/benches/parser.rs::benches::bench_files

22.5 ms22.5 ms

es/lints/libs/moment

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

4.2 ms4.2 ms

es/resolver_with_hygiene/typescript

crates/swc_ecma_transforms_base/benches/base.rs::benches::bench_cases

747.7 ms747.7 ms

es2016_exponentiation

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

292.5 µs292.5 µs

es/visitor/compare/visit_mut_span

crates/swc_ecma_parser/benches/compare.rs::benches::bench_cases

6 ms6 ms

es/minifier/libs/echarts

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

1.5 s1.5 s

es/parser/backbone

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

2.7 ms2.7 ms

css/lexer/bootstrap_5_1_3

crates/swc_css_parser/benches/lexer.rs::benches::bench_files

11 ms11 ms

es/visitor/compare/fold_span_panic

crates/swc_ecma_parser/benches/compare.rs::benches::bench_cases

6.8 ms6.8 ms

es/target/es2018

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::version_group

310.4 µs310.4 µs

css/visitor/compare/fold_span_panic

crates/swc_css_parser/benches/compare.rs::benches::bench_cases

5.8 ms5.8 ms

parse_and_babelify_jquery

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

99.4 ms99.4 ms

parse_and_babelify_yui

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

67.6 ms67.6 ms

es/codegen/with-parser/large

crates/swc_ecma_codegen/benches/with_parse.rs::benches::bench_cases

1.2 ms1.2 ms

parse_and_babelify_underscore

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

13.1 ms13.1 ms

es/lexer/jquery mobile

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

7.2 ms7.2 ms

es/lexer/backbone

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

875.6 µs875.6 µs

parse_and_babelify_angular

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

160.5 ms160.5 ms

parse_and_babelify_backbone

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

15.4 ms15.4 ms

parse_and_babelify_mootools

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

72.7 ms72.7 ms

css/parser/bootstrap_5_1_3

crates/swc_css_parser/benches/parser.rs::benches::bench_files

46.5 ms46.5 ms

html/lexer/css_2021_spec

crates/swc_html_parser/benches/lexer.rs::benches::bench_files

40 ms40 ms

es/lexer/jquery

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

4.6 ms4.6 ms

es/minifier/libs/react

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

19.7 ms19.7 ms

es/lexer/yui

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

4 ms4 ms

html/lexer/github_com_17_05_2022

crates/swc_html_parser/benches/lexer.rs::benches::bench_files

14.4 ms14.4 ms

parse_and_babelify_jquery_mobile

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

169.9 ms169.9 ms

css/visitor/compare/visit_mut_span

crates/swc_css_parser/benches/compare.rs::benches::bench_cases

5.1 ms5.1 ms

es/lexer/underscore

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

737.5 µs737.5 µs

es/lexer/mootools

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

3.6 ms3.6 ms

html/lexer/stackoverflow_com_17_05_2022

crates/swc_html_parser/benches/lexer.rs::benches::bench_files

14.5 ms14.5 ms

html/parser/parser_document/css_2021_spec

crates/swc_html_parser/benches/parser.rs::benches::bench_files

72.3 ms72.3 ms

es/parser/yui

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

10.9 ms10.9 ms

css/visitor/compare/visit_mut_span_panic

crates/swc_css_parser/benches/compare.rs::benches::bench_cases

5.1 ms5.1 ms

css/parser/tailwind_3_1_1

crates/swc_css_parser/benches/parser.rs::benches::bench_files

7.2 ms7.2 ms

es/lexer/cal-com

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

13.1 ms13.1 ms

html/document/visitor/compare/clone

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1 ms1 ms

es/parser/jquery

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

14.1 ms14.1 ms

es/target/es2015

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::version_group

1.2 ms1.2 ms

es/lexer/angular

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

6.7 ms6.7 ms

es/visitor/compare/clone

crates/swc_ecma_parser/benches/compare.rs::benches::bench_cases

5.5 ms5.5 ms

es/lints/libs/victory

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

70.8 ms70.8 ms

es/parser/jquery mobile

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

21.9 ms21.9 ms

html/parser/parser_document/stackoverflow_com_17_05_2022

crates/swc_html_parser/benches/parser.rs::benches::bench_files

22.7 ms22.7 ms

css/parser/foundation_6_7_4

crates/swc_css_parser/benches/parser.rs::benches::bench_files

37 ms37 ms

html/parser/parser_document_fragment/stackoverflow_com_17_05_2022

crates/swc_html_parser/benches/parser.rs::benches::bench_files

22.6 ms22.6 ms

typescript/fast-strip

crates/swc_ts_fast_strip/benches/assets.rs::benches::fast_ts

420.9 µs420.9 µs

css/lexer/foundation_6_7_4

crates/swc_css_parser/benches/lexer.rs::benches::bench_files

9 ms9 ms

es/minifier/libs/victory

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

860.1 ms860.1 ms

css/lexer/tailwind_3_1_1

crates/swc_css_parser/benches/lexer.rs::benches::bench_files

1.8 ms1.8 ms

es/full-target/es2017

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::full_group

542.9 µs543 µs

babelify-only

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

2.1 ms2.1 ms

es/parser/mootools

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

11 ms11 ms

html/parser/parser_document_fragment/github_com_17_05_2022

crates/swc_html_parser/benches/parser.rs::benches::bench_files

22.5 ms22.5 ms

es/resolver/typescript

crates/swc_ecma_transforms_base/benches/base.rs::benches::bench_cases

243.4 ms243.4 ms

es2022_class_properties

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

385.2 µs385.2 µs

es/lexer/three

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

18.3 ms18.3 ms

es/parser/typescript

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

380.7 ms380.7 ms

es/full-target/es2018

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::full_group

524.1 µs524.2 µs

es/lints/libs/three

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

50.2 ms50.2 ms

es2015_parameters

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

333.2 µs333.2 µs

es/lexer/typescript

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

107.7 ms107.7 ms

es/minifier/libs/moment

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

63.2 ms63.2 ms

es/lints/libs/echarts

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

114.2 ms114.3 ms

es/preset-env/usage/builtin_type

crates/swc_ecma_preset_env/benches/polyfills.rs::benches::bench_cases

243.7 µs243.7 µs

html/document_fragment/visitor/compare/fold_span

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.2 ms1.2 ms

es/parser/cal-com

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

56.7 ms56.7 ms

es/minifier/libs/d3

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

397.4 ms397.5 ms

css/visitor/compare/clone

crates/swc_css_parser/benches/compare.rs::benches::bench_cases

4.8 ms4.8 ms

html/document/visitor/compare/fold_span_panic

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.2 ms1.2 ms

es/parser/colors

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

81.9 µs81.9 µs

es/parser/underscore

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

2.4 ms2.4 ms

html/document/visitor/compare/fold_span

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.2 ms1.2 ms

es/parser/three

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

67.7 ms67.7 ms

es/lints/libs/antd

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

156.3 ms156.3 ms

es/visitor/compare/fold_span

crates/swc_ecma_parser/benches/compare.rs::benches::bench_cases

6.8 ms6.8 ms

html/document/visitor/compare/visit_mut_span

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.1 ms1.1 ms

es/fixer/typescript

crates/swc_ecma_transforms_base/benches/base.rs::benches::bench_cases

202.1 ms202.2 ms

es/lints/libs/react

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

1.3 ms1.3 ms

es/codegen/with-parser/colors

crates/swc_ecma_codegen/benches/with_parse.rs::benches::bench_cases

158.1 µs158.2 µs

html/document/visitor/compare/visit_mut_span_panic

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.1 ms1.1 ms

es/minifier/libs/vue

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

144.2 ms144.3 ms

es/minifier/libs/jquery

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

97.6 ms97.7 ms

html/document_fragment/visitor/compare/visit_mut_span

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.1 ms1.1 ms

es/codegen/colors

crates/swc_ecma_codegen/benches/bench.rs::benches::bench_cases

68.2 µs68.3 µs

html/document_fragment/visitor/compare/visit_mut_span_panic

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.1 ms1.1 ms

es/lexer/colors

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

27 µs27 µs

es/minifier/libs/antd

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

1.9 s1.9 s

es/hygiene/typescript

crates/swc_ecma_transforms_base/benches/base.rs::benches::bench_cases

424 ms425.6 ms

es/minifier/libs/three

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

646.9 ms649.8 ms

es/minifier/libs/terser

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

-1%

350.4 ms352.3 ms

Ignored

es/preset-env/entry/import

crates/swc_ecma_preset_env/benches/polyfills.rs::benches::bench_cases

Ignored

29.3 µs29.4 µs

Commits

Click on a commit to change the comparison range

Base

main

2cea7dd

+0.02%

fix(es/minifier): Prevent compress.comparisons from transforming expressions with side effects This commit fixes issue #11255 where the compress.comparisons optimization was incorrectly transforming comparisons containing expressions with side effects (like ++PC), changing the program's behavior. The fix introduces a helper function `contains_update_or_assign()` that checks if an expression contains update expressions (++, --) or assignments that would make duplicate evaluations produce different results. Changes: - Added `contains_update_or_assign()` helper function in ops.rs and bools.rs - Updated comparison optimizations to skip expressions with update/assign - Added test case for issue #11255 The optimization now correctly preserves expressions like: Stack[Code[++PC]] === Stack[Code[++PC]] Instead of incorrectly converting them to ==, which would change semantics. Fixes #11255 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

c25fca5

2 days ago

by github-actions[bot]

-0.02%

fix(es/minifier): Refine side-effect check to only apply when comparing identical expressions The previous fix was too conservative, preventing valid optimizations. The side-effect check should only apply when we're treating two expressions as identical (e.g., `x === x`), not when we're just converting `===` to `==` based on type compatibility. This fixes the 23 failing tests while preserving the fix for issue #11255. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

526bbd1

2 days ago

by github-actions[bot]

+0.01%

fix: Remove unused contains_update_or_assign function from bools.rs This function was no longer being used after refining the side-effect checks. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

49dc58b

2 days ago

by github-actions[bot]

-0.02%

fix: Remove trailing newline in bools.rs to fix cargo fmt check 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

063d2f3

2 days ago

by github-actions[bot]

test(es/minifier): Add missing output.mangleOnly.js for issue #11255 test Add the missing mangled output file for the issue_11255_side_effects test case. This file is required by the test framework to verify that the minifier correctly preserves expressions with side effects during name mangling. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

37bb093

2 days ago

by github-actions[bot]

Home Terms Privacy Docs