justinweng-instaclustr:handle-offline-shotover-nodes - Branch - shotover/shotover-proxy

Exclude offline shotover nodes when rewriting responses

#1770Merged

Comparing

justinweng-instaclustr:handle-offline-shotover-nodes

(

6f5edc2

) with

main

(

de0fca3

)

Improvements: 0

Regressions: 0

Untouched: 38

New: 0

Dropped: 0

Ignored: 0

Benchmarks

Passed

encode_system.local_query_v4_no_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::encode_system.local_query_v4_no_compression

+5%

14.5 µs

13.9 µs

encode_request_fetch

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec::encode_request_fetch

+4%

12.4 µs

12 µs

decode_request_list_offsets_drop

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec::decode_request_list_offsets_drop

+3%

4 µs

3.9 µs

encode_request_metadata

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec::encode_request_metadata

+2%

11.7 µs

11.4 µs

encode_system.local_query_v4_lz4_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::encode_system.local_query_v4_lz4_compression

+2%

13.8 µs

13.6 µs

decode_request_fetch_drop

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec::decode_request_fetch_drop

+1%

4.1 µs

4 µs

encode_system.local_query_v5_lz4_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::encode_system.local_query_v5_lz4_compression

+1%

26.7 µs

26.4 µs

decode_request_fetch_create

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec::decode_request_fetch_create

+1%

13 µs

12.8 µs

encode_request_list_offsets

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec::encode_request_list_offsets

+1%

11.9 µs

11.8 µs

decode_request_produce_drop

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec::decode_request_produce_drop

+1%

4.1 µs

encode_system.local_query_v5_no_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::encode_system.local_query_v5_no_compression

+1%

15 µs

14.9 µs

decode_system.local_result_v4_no_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::decode_system.local_result_v4_no_compression

+1%

14.8 µs

14.7 µs

decode_system.local_query_v5_no_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::decode_system.local_query_v5_no_compression

+1%

57 µs

56.7 µs

decode_system.local_query_v4_no_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::decode_system.local_query_v4_no_compression

+1%

55.2 µs

54.9 µs

decode_system.local_query_v4_lz4_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::decode_system.local_query_v4_lz4_compression

55.2 µs

55 µs

cassandra_rewrite_peers_passthrough

shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform::cassandra_rewrite_peers_passthrough

81.4 µs

81.1 µs

decode_system.local_result_v5_no_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::decode_system.local_result_v5_no_compression

14.9 µs

decode_request_produce_create

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec::decode_request_produce_create

14.4 µs

14.3 µs

cassandra_protect_protected

shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform::cassandra_protect_protected

74 µs

73.8 µs

decode_system.local_result_v5_lz4_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::decode_system.local_result_v5_lz4_compression

45 µs

44.8 µs

cassandra_protect_unprotected

shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform::cassandra_protect_unprotected

41.4 µs

41.3 µs

encode_all

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec::encode_all

19.3 µs

19.2 µs

encode_system.local_result_v4_no_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::encode_system.local_result_v4_no_compression

93.1 µs

92.8 µs

decode_system.local_result_v4_lz4_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::decode_system.local_result_v4_lz4_compression

45 µs

cassandra_request_throttling_unparsed

shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform::cassandra_request_throttling_unparsed

14.6 µs

decode_request_list_offsets_create

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec::decode_request_list_offsets_create

11.6 µs

decode_system.local_query_v5_lz4_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::decode_system.local_query_v5_lz4_compression

56.7 µs

56.8 µs

encode_request_produce

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec::encode_request_produce

8.5 µs

8.6 µs

encode_system.local_result_v5_lz4_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::encode_system.local_result_v5_lz4_compression

199.4 µs

200 µs

encode_system.local_result_v4_lz4_compression

shotover/benches/benches/codec/cassandra.rs::benches::criterion_benchmark::cassandra_codec::encode_system.local_result_v4_lz4_compression

201.6 µs

202.4 µs

query_counter_fresh

shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform::query_counter_fresh

-1%

14.6 µs

redis_filter

shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform::redis_filter

-1%

22.8 µs

22.9 µs

query_counter_pre_used

shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform::query_counter_pre_used

-1%

11.3 µs

11.4 µs

loopback

shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform::loopback

-1%

6.4 µs

6.5 µs

decode_request_metadata_create

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec::decode_request_metadata_create

-1%

10.2 µs

10.3 µs

redis_cluster_ports_rewrite

shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform::redis_cluster_ports_rewrite

-1%

18.1 µs

18.2 µs

nullsink

shotover/benches/benches/chain.rs::benches::criterion_benchmark::transform::nullsink

-1%

14.1 µs

14.3 µs

decode_request_metadata_drop

shotover/benches/benches/codec/kafka.rs::benches::criterion_benchmark::kafka_codec::decode_request_metadata_drop

-4%

3.3 µs

3.4 µs

Commits

Click on a commit to change the comparison range

Base

main

de0fca3

-23%

renaming

132ff42

2 months ago

by justinweng-instaclustr

+23%

Merge branch 'main' into handle-offline-shotover-nodes

d7f553a

2 months ago

by justinweng-instaclustr

change shotovernode visibility

f45682c

2 months ago

by justinweng-instaclustr

+11%

Merge branch 'refs/heads/main' into handle-offline-shotover-nodes

1b90587

2 months ago

by justinweng-instaclustr

-10%

update test case

5fd897c

2 months ago

by justinweng-instaclustr

fix test

98c71d8

2 months ago

by justinweng-instaclustr

add doco about new config field

f9be00d

2 months ago

by justinweng-instaclustr

update test

c6c63c2

2 months ago

by justinweng-instaclustr

fix log format

57a8a03

2 months ago

by justinweng-instaclustr

fix infinite loop when shotover_peers is empty

ff16443

2 months ago

by justinweng-instaclustr

-14%

add new config for tests

1ae95b3

2 months ago

by justinweng-instaclustr

update changelog

9c9ec2e

2 months ago

by justinweng-instaclustr

-1%

address comments

db16134

2 months ago

by justinweng-instaclustr

+2%

add expected warn logs

eeb8f54

2 months ago

by justinweng-instaclustr

+12%

add expected warn logs

74c41d3

2 months ago

by justinweng-instaclustr

-12%

Merge branch 'main' into handle-offline-shotover-nodes

b1e7742

2 months ago

by justinweng-instaclustr

+12%

exclude down shotover nodes when rewriting responses

848813c

2 months ago

by justinweng-instaclustr

add fallback to out of rack shotover nodes

b4a2eb4

2 months ago

by justinweng-instaclustr

-14%

Merge branch 'refs/heads/main' into handle-offline-shotover-nodes # Conflicts: # shotover/src/transforms/kafka/sink_cluster/mod.rs

a82ea8e

2 months ago

by justinweng-instaclustr

+14%

address comments

0b845bb

1 month ago

by justinweng-instaclustr

Merge branch 'main' into handle-offline-shotover-nodes

58b5b60

1 month ago

by justinweng-instaclustr

update test cases

3b4a34e

1 month ago

by justinweng-instaclustr

disable tests for cpp driver

d4b3a6a

1 month ago

by justinweng-instaclustr

update tests

6f5edc2

1 month ago

by justinweng-instaclustr

Home Terms Privacy Docs