08-08-refactor_data_structures_remove_pointerext_trait - Branch - oxc-project/oxc

refactor(data_structures)!: remove `PointerExt` trait

#12903Merged

Comparing

08-08-refactor_data_structures_remove_pointerext_trait

(

128b527

) with

main

(

281f939

)

Untouched: 34

This report only contains results for the CPU Simulation instrument. To view results for the Wall Time instrument, click here.

Benchmarks

Passed

minifier[cal.com.tsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

38.9 ms38.7 ms

codegen[cal.com.tsx]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

35.6 ms35.5 ms

formatter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

308.3 µs307.8 µs

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

76.7 µs76.6 µs

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

26.8 ms26.8 ms

codegen[react.development.js]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

1.9 ms1.9 ms

linter[react.development.js]

tasks/benchmark/benches/linter.rs::linter::bench_linter

52.2 ms52.1 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_isolated_declarations

57.3 ms57.3 ms

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

133.2 µs133.2 µs

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

83.8 µs83.8 µs

linter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

2.5 ms2.5 ms

formatter[cal.com.tsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

170.1 ms170.1 ms

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

1.2 s1.2 s

linter[binder.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

146.4 ms146.4 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5.8 ms5.8 ms

semantic[react.development.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

1.7 ms1.7 ms

estree[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_estree

104.5 ms104.5 ms

lexer[binder.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

930 µs930.1 µs

formatter[react.development.js]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

10.7 ms10.7 ms

semantic[binder.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

4.3 ms4.3 ms

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

27.9 ms27.9 ms

lexer[react.development.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

383.8 µs383.9 µs

transformer[binder.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

1.7 ms1.7 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

26.7 ms26.7 ms

parser[binder.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

3.3 ms3.3 ms

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

2.7 ms2.7 ms

transformer[react.development.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

717.8 µs718.7 µs

codegen[binder.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

4.2 ms4.2 ms

formatter[binder.ts]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

21.4 ms21.4 ms

minifier[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

80.4 µs80.6 µs

parser[react.development.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

1.3 ms1.3 ms

minifier[binder.ts]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

4.9 ms4.9 ms

codegen[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

122.8 µs123 µs

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

-1%

20.7 µs20.9 µs

Commits

Click on a commit to change the comparison range

Base

main

281f939

-0.04%

refactor(data_structures)!: remove `PointerExt` trait (#12903) `PointerExt` trait was introduced to allow using `NonNull::offset_from_unsigned` (and similar APIs) on Rust v1.87.0 and above, without breaking code on earlier Rust versions where these APIs did not exist. Our MSRV is now v1.87.0 (#12900), so we can just use these methods directly, and `PointerExt` is not required any more. Remove it.

128b527

3 months ago

by overlookmotel

Home Terms Privacy Docs