MatthewMckee4:incorrect-subdiagnostic-for-unresolved-reference - Branch - astral-sh/ruff

[ty] Don't add incorrect subdiagnostic for unresolved reference

#18487Merged

Comparing

MatthewMckee4:incorrect-subdiagnostic-for-unresolved-reference

(

ba648f9

) with

main

(

57bd7d0

)

Untouched: 39

This report only contains results for the CPU Simulation instrument. To view results for the Wall Time instrument, click here.

Benchmarks

Passed

attrs

crates/ruff_benchmark/benches/ty.rs::project::attrs::project

375.4 ms374.9 ms

lexer[numpy/globals.py]

crates/ruff_benchmark/benches/lexer.rs::lexer::benchmark_lexer

29.3 µs29.2 µs

parser[numpy/globals.py]

crates/ruff_benchmark/benches/parser.rs::parser::benchmark_parser

105.8 µs105.7 µs

ty_micro[complex_constrained_attributes_1]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_complex_constrained_attributes_1

56.8 ms56.8 ms

lexer[unicode/pypinyin.py]

crates/ruff_benchmark/benches/lexer.rs::lexer::benchmark_lexer

75.4 µs75.4 µs

parser[unicode/pypinyin.py]

crates/ruff_benchmark/benches/parser.rs::parser::benchmark_parser

320.9 µs320.8 µs

lexer[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/lexer.rs::lexer::benchmark_lexer

218.4 µs218.4 µs

formatter[unicode/pypinyin.py]

crates/ruff_benchmark/benches/formatter.rs::formatter::benchmark_formatter

665.1 µs665 µs

linter/all-with-preview-rules[numpy/globals.py]

crates/ruff_benchmark/benches/linter.rs::preview_rules::benchmark_preview_rules

794.8 µs794.8 µs

parser[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/parser.rs::parser::benchmark_parser

930.9 µs930.8 µs

lexer[pydantic/types.py]

crates/ruff_benchmark/benches/lexer.rs::lexer::benchmark_lexer

488.5 µs488.5 µs

parser[large/dataset.py]

crates/ruff_benchmark/benches/parser.rs::parser::benchmark_parser

4.9 ms4.9 ms

linter/all-with-preview-rules[unicode/pypinyin.py]

crates/ruff_benchmark/benches/linter.rs::preview_rules::benchmark_preview_rules

2.1 ms2.1 ms

linter/all-rules[numpy/globals.py]

crates/ruff_benchmark/benches/linter.rs::all_rules::benchmark_all_rules

697.2 µs697.2 µs

parser[pydantic/types.py]

crates/ruff_benchmark/benches/parser.rs::parser::benchmark_parser

2 ms2 ms

formatter[large/dataset.py]

crates/ruff_benchmark/benches/formatter.rs::formatter::benchmark_formatter

9.5 ms9.5 ms

lexer[large/dataset.py]

crates/ruff_benchmark/benches/lexer.rs::lexer::benchmark_lexer

1.1 ms1.1 ms

formatter[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/formatter.rs::formatter::benchmark_formatter

1.9 ms1.9 ms

formatter[pydantic/types.py]

crates/ruff_benchmark/benches/formatter.rs::formatter::benchmark_formatter

3.6 ms3.6 ms

linter/default-rules[pydantic/types.py]

crates/ruff_benchmark/benches/linter.rs::default_rules::benchmark_default_rules

2 ms2 ms

linter/all-with-preview-rules[large/dataset.py]

crates/ruff_benchmark/benches/linter.rs::preview_rules::benchmark_preview_rules

20.9 ms20.9 ms

linter/default-rules[large/dataset.py]

crates/ruff_benchmark/benches/linter.rs::default_rules::benchmark_default_rules

4.1 ms4.1 ms

linter/all-rules[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/linter.rs::all_rules::benchmark_all_rules

4.1 ms4.1 ms

linter/all-rules[large/dataset.py]

crates/ruff_benchmark/benches/linter.rs::all_rules::benchmark_all_rules

17.3 ms17.3 ms

linter/all-with-preview-rules[pydantic/types.py]

crates/ruff_benchmark/benches/linter.rs::preview_rules::benchmark_preview_rules

9.9 ms9.9 ms

linter/all-rules[unicode/pypinyin.py]

crates/ruff_benchmark/benches/linter.rs::all_rules::benchmark_all_rules

1.8 ms1.8 ms

linter/all-rules[pydantic/types.py]

crates/ruff_benchmark/benches/linter.rs::all_rules::benchmark_all_rules

8.4 ms8.4 ms

linter/all-with-preview-rules[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/linter.rs::preview_rules::benchmark_preview_rules

4.8 ms4.8 ms

linter/default-rules[unicode/pypinyin.py]

crates/ruff_benchmark/benches/linter.rs::default_rules::benchmark_default_rules

382.6 µs382.6 µs

formatter[numpy/globals.py]

crates/ruff_benchmark/benches/formatter.rs::formatter::benchmark_formatter

241.6 µs241.6 µs

linter/default-rules[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/linter.rs::default_rules::benchmark_default_rules

973.1 µs973.2 µs

ty_check_file[cold]

crates/ruff_benchmark/benches/ty.rs::check_file::benchmark_cold

124.4 ms124.5 ms

linter/default-rules[numpy/globals.py]

crates/ruff_benchmark/benches/linter.rs::default_rules::benchmark_default_rules

194.8 µs194.9 µs

ty_micro[complex_constrained_attributes_2]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_complex_constrained_attributes_2

6.3 s6.3 s

anyio

crates/ruff_benchmark/benches/ty.rs::project::anyio::project

900.3 ms900.6 ms

ty_micro[many_string_assignments]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_many_string_assignments

73.9 ms74 ms

ty_check_file[incremental]

crates/ruff_benchmark/benches/ty.rs::check_file::benchmark_incremental

5.7 ms5.7 ms

hydra-zen

crates/ruff_benchmark/benches/ty.rs::project::hydra::project

763.5 ms764 ms

ty_micro[many_tuple_assignments]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_many_tuple_assignments

130 ms130.1 ms

Commits

Click on a commit to change the comparison range

Base

main

57bd7d0

-0.02%

Dont add subdiagnostic for unresolved reference in staticmethod, and change message for classmethod

7da74c3

5 months ago

by MatthewMckee4

Use class_context

1ac9d1a

5 months ago

by MatthewMckee4

-4.38%

Update snapshot

cefcb63

5 months ago

by MatthewMckee4

Merge branch 'main' into incorrect-subdiagnostic-for-unresolved-reference

bb48d57

5 months ago

by MatthewMckee4

Add lifetime

09f7f27

5 months ago

by MatthewMckee4

+4.36%

Fix tests

cf3b2c2

5 months ago

by MatthewMckee4

+0.01%

Use first argument in diagnostic

348cd5a

5 months ago

by MatthewMckee4

+0.03%

Merge branch 'main' into incorrect-subdiagnostic-for-unresolved-reference * main: (71 commits) Bump 0.12.0 (#18724) Revert "[ty] Offer "Did you mean...?" suggestions for unresolved `from` imports and unresolved attributes (#18705)" (#18721) [`flake8-return`] Stabilize only add `return None` at the end when fixing `implicit-return` (`RET503`) (#18516) [`pyupgrade`] Stabilize `non-pep695-generic-function` (`UP047`) (#18524) [`pyupgrade`] Stabilize `non-pep695-generic-class` (`UP046`) (#18519) [`pandas-vet`] Deprecate `pandas-df-variable-name` (`PD901`) (#18618) [`flake8-bandit`] Remove `suspicious-xmle-tree-usage` (`S320`) (#18617) Stabilize `dataclass-enum` (`RUF049`) (#18570) Stabilize `unnecessary-dict-index-lookup` (`PLR1733`) (#18571) Remove rust-toolchain.toml from sdist (#17925) Stabilize `starmap-zip` (`RUF058`) (#18525) [`flake8-logging`] Stabilize `exc-info-outside-except-handler` (`LOG014`) (#18517) [`pyupgrade`] Stabilize `non-pep604-annotation-optional` (`UP045`) and preview behavior for `non-pep604-annotation-union` (`UP007`) (#18505) Stabilize `pytest-warns-too-broad` (`PT030`) (#18568) Stabilize `for-loop-writes` (`FURB122`) (#18565) Stabilize `pytest-warns-with-multiple-statements` (`PT031`) (#18569) Stabilize `pytest-parameter-with-default-argument` (`PT028`) (#18566) Stabilize `nan-comparison` (`PLW0177`) (#18559) Stabilize `check-and-remove-from-set` (`FURB132`) (#18560) Stabilize `unnecessary-round` (`RUF057`) (#18563) ...

bef7491

5 months ago

by carljm

Adjust some test prose and a docstring

410c137

5 months ago

by carljm

Code cleanup

d77a965

5 months ago

by carljm

-0.47%

Merge branch 'main' into incorrect-subdiagnostic-for-unresolved-reference

c30c744

5 months ago

by MatthewMckee4

+0.48%

Merge branch 'main' into incorrect-subdiagnostic-for-unresolved-reference

eb32858

5 months ago

by AlexWaygood

+0.39%

avoid `file_expression_type` where unnecessary

9e9b744

5 months ago

by AlexWaygood

-0.38%

simplifications

ba648f9

5 months ago

by AlexWaygood

Home Terms Privacy Docs