Avatar for the PyO3 user
PyO3
pyo3
BlogDocsChangelog

Fix a soundness bug with `PyClassInitializer`

#4454Merged
Comparing
ChayimFriedman2:fix-unsound-pyclassinitializer
(
01edfde
) with
main
(
57d85b1
)
CodSpeed Performance Gauge
0%
Improvements
0
Regressions
0
Untouched
74
New
0
Dropped
0
Ignored
18

Benchmarks

Passed

first_time_init
pyo3-benches/benches/bench_pyclass.rs::benches::criterion_benchmark::first_time_init
CodSpeed Performance Gauge
+3%
39.1 µs
37.8 µs
extract_bigint_small
pyo3-benches/benches/bench_bigint.rs::benches::criterion_benchmark::extract_bigint_small
CodSpeed Performance Gauge
+2%
2.9 µs
2.8 µs
ordered_dunder_methods
pyo3-benches/benches/bench_comparisons.rs::benches::criterion_benchmark::ordered_dunder_methods
CodSpeed Performance Gauge
+2%
2.9 µs
2.9 µs
test_args_kwargs_py
pytests/tests/test_pyfunctions.py::test_args_kwargs_py
CodSpeed Performance Gauge
+1%
21.1 µs
20.8 µs
decimal_via_extract
pyo3-benches/benches/bench_decimal.rs::benches::criterion_benchmark::decimal_via_extract
CodSpeed Performance Gauge
+1%
14.8 µs
14.6 µs
vec_into_pyobject
pyo3-benches/benches/bench_intopyobject.rs::benches::criterion_benchmark::vec_into_pyobject
CodSpeed Performance Gauge
+1%
2.5 µs
2.5 µs
ordered_richcmp
pyo3-benches/benches/bench_comparisons.rs::benches::criterion_benchmark::ordered_richcmp
CodSpeed Performance Gauge
+1%
2.8 µs
2.7 µs
clean_acquire_gil
pyo3-benches/benches/bench_gil.rs::benches::criterion_benchmark::clean_acquire_gil
CodSpeed Performance Gauge
+1%
3.3 µs
3.3 µs
identify_object_type
pyo3-benches/benches/bench_any.rs::benches::criterion_benchmark::identify_object_type
CodSpeed Performance Gauge
+1%
14.9 µs
14.8 µs
extract_bigint_huge_positive
pyo3-benches/benches/bench_bigint.rs::benches::criterion_benchmark::extract_bigint_huge_positive
CodSpeed Performance Gauge
+1%
11.9 µs
11.8 µs
not_a_list_via_extract_enum
pyo3-benches/benches/bench_frompyobject.rs::benches::criterion_benchmark::not_a_list_via_extract_enum
CodSpeed Performance Gauge
+1%
13.2 µs
13.1 µs
enum_from_pyobject
pyo3-benches/benches/bench_frompyobject.rs::benches::criterion_benchmark::enum_from_pyobject
CodSpeed Performance Gauge
+1%
19.1 µs
18.9 µs
extract_bigint_huge_negative
pyo3-benches/benches/bench_bigint.rs::benches::criterion_benchmark::extract_bigint_huge_negative
CodSpeed Performance Gauge
0%
13.3 µs
13.2 µs
test_simple_kwargs_rs
pytests/tests/test_pyfunctions.py::test_simple_kwargs_rs
CodSpeed Performance Gauge
0%
20.6 µs
20.5 µs
err_new_restore_and_fetch
pyo3-benches/benches/bench_err.rs::benches::criterion_benchmark::err_new_restore_and_fetch
CodSpeed Performance Gauge
0%
7.8 µs
7.8 µs
test_simple_rs
pytests/tests/test_pyfunctions.py::test_simple_rs
CodSpeed Performance Gauge
0%
18.4 µs
18.3 µs
extract_bigint_extract_fail
pyo3-benches/benches/bench_bigint.rs::benches::criterion_benchmark::extract_bigint_extract_fail
CodSpeed Performance Gauge
0%
11.7 µs
11.7 µs
drop_many_objects_without_gil
pyo3-benches/benches/bench_pyobject.rs::benches::criterion_benchmark::drop_many_objects_without_gil
CodSpeed Performance Gauge
0%
43.4 µs
43.3 µs
test_simple_args_rs
pytests/tests/test_pyfunctions.py::test_simple_args_rs
CodSpeed Performance Gauge
0%
20.1 µs
20 µs
extract_hashset
pyo3-benches/benches/bench_set.rs::benches::criterion_benchmark::extract_hashset
CodSpeed Performance Gauge
0%
20.4 ms
20.4 ms
call_0
pyo3-benches/benches/bench_call.rs::benches::criterion_benchmark::call_0
CodSpeed Performance Gauge
0%
205.4 µs
205.4 µs
extract_hashmap
pyo3-benches/benches/bench_dict.rs::benches::criterion_benchmark::extract_hashmap
CodSpeed Performance Gauge
0%
19.5 ms
19.5 ms
call_method_0
pyo3-benches/benches/bench_call.rs::benches::criterion_benchmark::call_method_0
CodSpeed Performance Gauge
0%
593 µs
592.9 µs
extract_btreemap
pyo3-benches/benches/bench_dict.rs::benches::criterion_benchmark::extract_btreemap
CodSpeed Performance Gauge
0%
36.3 ms
36.3 ms
dict_new
pyo3-benches/benches/bench_dict.rs::benches::criterion_benchmark::dict_new
CodSpeed Performance Gauge
0%
25.3 ms
25.3 ms
collect_generic_iterator
pyo3-benches/benches/bench_any.rs::benches::criterion_benchmark::collect_generic_iterator
CodSpeed Performance Gauge
0%
106.2 ms
106.2 ms
list_get_item_unchecked
pyo3-benches/benches/bench_list.rs::benches::criterion_benchmark::list_get_item_unchecked
CodSpeed Performance Gauge
0%
3.3 ms
3.3 ms
extract_bigint_big_negative
pyo3-benches/benches/bench_bigint.rs::benches::criterion_benchmark::extract_bigint_big_negative
CodSpeed Performance Gauge
0%
3.9 µs
3.9 µs
extract_bigint_big_positive
pyo3-benches/benches/bench_bigint.rs::benches::criterion_benchmark::extract_bigint_big_positive
CodSpeed Performance Gauge
0%
3.6 µs
3.6 µs
extract_str_extract_fail
pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark::extract_str_extract_fail
CodSpeed Performance Gauge
0%
1.8 µs
1.8 µs
not_a_list_via_extract
pyo3-benches/benches/bench_frompyobject.rs::benches::criterion_benchmark::not_a_list_via_extract
CodSpeed Performance Gauge
0%
1.8 µs
1.8 µs
dirty_acquire_gil
pyo3-benches/benches/bench_gil.rs::benches::criterion_benchmark::dirty_acquire_gil
CodSpeed Performance Gauge
0%
4.9 µs
4.9 µs
getattr_intern
pyo3-benches/benches/bench_intern.rs::benches::criterion_benchmark::getattr_intern
CodSpeed Performance Gauge
0%
3 µs
3 µs
byte_slice_into_pyobject_medium
pyo3-benches/benches/bench_intopyobject.rs::benches::criterion_benchmark::byte_slice_into_pyobject_medium
CodSpeed Performance Gauge
0%
1.6 µs
1.6 µs
bytes_new_medium
pyo3-benches/benches/bench_intopyobject.rs::benches::criterion_benchmark::bytes_new_medium
CodSpeed Performance Gauge
0%
1.6 µs
1.6 µs
tuple_into_py
pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark::tuple_into_py
CodSpeed Performance Gauge
0%
2.9 µs
2.9 µs
test_simple_kwargs_py
pytests/tests/test_pyfunctions.py::test_simple_kwargs_py
CodSpeed Performance Gauge
0%
22.1 µs
22.1 µs
test_simple_py
pytests/tests/test_pyfunctions.py::test_simple_py
CodSpeed Performance Gauge
0%
17.5 µs
17.5 µs
list_new
pyo3-benches/benches/bench_list.rs::benches::criterion_benchmark::list_new
CodSpeed Performance Gauge
0%
7.2 ms
7.2 ms
iter_set
pyo3-benches/benches/bench_set.rs::benches::criterion_benchmark::iter_set
CodSpeed Performance Gauge
0%
9.8 ms
9.8 ms
set_new
pyo3-benches/benches/bench_set.rs::benches::criterion_benchmark::set_new
CodSpeed Performance Gauge
0%
16.4 ms
16.4 ms
tuple_new
pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark::tuple_new
CodSpeed Performance Gauge
0%
7.1 ms
7.1 ms
byte_slice_into_pyobject_large
pyo3-benches/benches/bench_intopyobject.rs::benches::criterion_benchmark::byte_slice_into_pyobject_large
CodSpeed Performance Gauge
0%
176.9 µs
176.9 µs
list_get_item
pyo3-benches/benches/bench_list.rs::benches::criterion_benchmark::list_get_item
CodSpeed Performance Gauge
0%
3.8 ms
3.8 ms
dict_get_item
pyo3-benches/benches/bench_dict.rs::benches::criterion_benchmark::dict_get_item
CodSpeed Performance Gauge
0%
16.1 ms
16.1 ms
iter_dict
pyo3-benches/benches/bench_dict.rs::benches::criterion_benchmark::iter_dict
CodSpeed Performance Gauge
0%
10.8 ms
10.8 ms
bytes_new_large
pyo3-benches/benches/bench_intopyobject.rs::benches::criterion_benchmark::bytes_new_large
CodSpeed Performance Gauge
0%
176.8 µs
176.8 µs
iter_list
pyo3-benches/benches/bench_list.rs::benches::criterion_benchmark::iter_list
CodSpeed Performance Gauge
0%
6.1 ms
6.1 ms
tuple_to_list
pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark::tuple_to_list
CodSpeed Performance Gauge
0%
1.6 ms
1.6 ms
tuple_new_list
pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark::tuple_new_list
CodSpeed Performance Gauge
0%
2.2 ms
2.2 ms
iter_tuple
pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark::iter_tuple
CodSpeed Performance Gauge
0%
5.3 ms
5.3 ms
tuple_get_item_unchecked
pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark::tuple_get_item_unchecked
CodSpeed Performance Gauge
0%
3.3 ms
3.3 ms
tuple_get_borrowed_item
pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark::tuple_get_borrowed_item
CodSpeed Performance Gauge
0%
3.6 ms
3.6 ms
tuple_get_item
pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark::tuple_get_item
CodSpeed Performance Gauge
0%
3.8 ms
3.8 ms
tuple_get_borrowed_item_unchecked
pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark::tuple_get_borrowed_item_unchecked
CodSpeed Performance Gauge
0%
3.1 ms
3.1 ms
extract_btreeset
pyo3-benches/benches/bench_set.rs::benches::criterion_benchmark::extract_btreeset
CodSpeed Performance Gauge
0%
14.9 ms
15 ms
test_simple_args_kwargs_py
pytests/tests/test_pyfunctions.py::test_simple_args_kwargs_py
CodSpeed Performance Gauge
0%
21.3 µs
21.4 µs
extract_float_extract_fail
pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark::extract_float_extract_fail
CodSpeed Performance Gauge
0%
11.8 µs
11.8 µs
extract_int_extract_fail
pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark::extract_int_extract_fail
CodSpeed Performance Gauge
0%
11.6 µs
11.7 µs
drop_many_objects
pyo3-benches/benches/bench_pyobject.rs::benches::criterion_benchmark::drop_many_objects
CodSpeed Performance Gauge
0%
11.4 µs
11.4 µs
vec_into_py
pyo3-benches/benches/bench_intopyobject.rs::benches::criterion_benchmark::vec_into_py
CodSpeed Performance Gauge
0%
10 µs
10 µs
test_simple_args_py
pytests/tests/test_pyfunctions.py::test_simple_args_py
CodSpeed Performance Gauge
0%
18.1 µs
18.2 µs
test_method_call
pytests/tests/test_pyclasses.py::test_method_call
CodSpeed Performance Gauge
0%
13.3 µs
13.4 µs
test_none_py
pytests/tests/test_pyfunctions.py::test_none_py
CodSpeed Performance Gauge
0%
11.9 µs
12 µs
test_simple_args_kwargs_rs
pytests/tests/test_pyfunctions.py::test_simple_args_kwargs_rs
CodSpeed Performance Gauge
-1%
19.8 µs
19.9 µs
test_empty_class_init
pytests/tests/test_pyclasses.py::test_empty_class_init
CodSpeed Performance Gauge
-1%
21 µs
21.1 µs
test_none_rs
pytests/tests/test_pyfunctions.py::test_none_rs
CodSpeed Performance Gauge
-1%
11.9 µs
12 µs
test_args_kwargs_rs
pytests/tests/test_pyfunctions.py::test_args_kwargs_rs
CodSpeed Performance Gauge
-1%
15.6 µs
15.8 µs
test_proto_call_py
pytests/tests/test_pyclasses.py::test_proto_call_py
CodSpeed Performance Gauge
-1%
13.7 µs
13.9 µs
test_method_call_py
pytests/tests/test_pyclasses.py::test_method_call_py
CodSpeed Performance Gauge
-1%
13.5 µs
13.6 µs
test_empty_class_init_py
pytests/tests/test_pyclasses.py::test_empty_class_init_py
CodSpeed Performance Gauge
-1%
15.1 µs
15.3 µs
test_proto_call
pytests/tests/test_pyclasses.py::test_proto_call
CodSpeed Performance Gauge
-2%
12.9 µs
13.1 µs
byte_slice_into_py
pyo3-benches/benches/bench_intopyobject.rs::benches::criterion_benchmark::byte_slice_into_py
CodSpeed Performance Gauge
-2%
1.6 µs
1.6 µs
err_new_without_gil
pyo3-benches/benches/bench_err.rs::benches::criterion_benchmark::err_new_without_gil
CodSpeed Performance Gauge
-2%
1.3 µs
1.3 µs

Ignored

mapping_from_dictIgnored
pyo3-benches/benches/bench_dict.rs::benches::criterion_benchmark::mapping_from_dict
CodSpeed Performance Gauge
-10%
270.8 ns
300 ns
extract_float_downcast_failIgnored
pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark::extract_float_downcast_fail
CodSpeed Performance Gauge
-7%
396.7 ns
425.8 ns
extract_float_downcast_successIgnored
pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark::extract_float_downcast_success
CodSpeed Performance Gauge
0%
149.2 ns
149.2 ns
extract_float_extract_successIgnored
pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark::extract_float_extract_success
CodSpeed Performance Gauge
0%
332.2 ns
332.2 ns
extract_int_downcast_failIgnored
pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark::extract_int_downcast_fail
CodSpeed Performance Gauge
0%
213.1 ns
213.1 ns
extract_int_downcast_successIgnored
pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark::extract_int_downcast_success
CodSpeed Performance Gauge
-11%
492.2 ns
550.6 ns
extract_int_extract_successIgnored
pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark::extract_int_extract_success
CodSpeed Performance Gauge
-12%
427.8 ns
486.1 ns
extract_str_downcast_failIgnored
pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark::extract_str_downcast_fail
CodSpeed Performance Gauge
+32%
241.9 ns
183.6 ns
extract_str_downcast_successIgnored
pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark::extract_str_downcast_success
CodSpeed Performance Gauge
-5%
522.8 ns
551.9 ns
extract_str_extract_successIgnored
pyo3-benches/benches/bench_extract.rs::benches::criterion_benchmark::extract_str_extract_success
CodSpeed Performance Gauge
+6%
517.5 ns
488.3 ns
list_via_downcastIgnored
pyo3-benches/benches/bench_frompyobject.rs::benches::criterion_benchmark::list_via_downcast
CodSpeed Performance Gauge
0%
178.3 ns
178.3 ns
list_via_extractIgnored
pyo3-benches/benches/bench_frompyobject.rs::benches::criterion_benchmark::list_via_extract
CodSpeed Performance Gauge
0%
183.3 ns
183.3 ns
not_a_list_via_downcastIgnored
pyo3-benches/benches/bench_frompyobject.rs::benches::criterion_benchmark::not_a_list_via_downcast
CodSpeed Performance Gauge
+14%
241.9 ns
212.8 ns
getattr_directIgnored
pyo3-benches/benches/bench_intern.rs::benches::criterion_benchmark::getattr_direct
CodSpeed Performance Gauge
-1%
6.5 µs
6.6 µs
byte_slice_into_pyobject_smallIgnored
pyo3-benches/benches/bench_intopyobject.rs::benches::criterion_benchmark::byte_slice_into_pyobject_small
CodSpeed Performance Gauge
0%
394.4 ns
394.4 ns
bytes_new_smallIgnored
pyo3-benches/benches/bench_intopyobject.rs::benches::criterion_benchmark::bytes_new_small
CodSpeed Performance Gauge
0%
365.3 ns
365.3 ns
sequence_from_listIgnored
pyo3-benches/benches/bench_list.rs::benches::criterion_benchmark::sequence_from_list
CodSpeed Performance Gauge
-11%
241.7 ns
270.8 ns
sequence_from_tupleIgnored
pyo3-benches/benches/bench_tuple.rs::benches::criterion_benchmark::sequence_from_tuple
CodSpeed Performance Gauge
-10%
270.3 ns
299.4 ns

Commits

Click on a commit to change the comparison range
Base
main
57d85b1
0%
Fix a soundness bug with `PyClassInitializer` From now you cannot initialize a `PyClassInitializer<SubClass>` with `PyClassInitializer::from(Py<BaseClass>).add_subclass(SubClass)`. This was out of bounds write. Now it panics. See details at https://github.com/PyO3/pyo3/issues/4452.
01edfde
6 months ago
by ChayimFriedman2
© 2025 CodSpeed Technology
Home Terms PrivacyDocs